From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B988F21962301 for ; Tue, 25 Dec 2018 00:43:44 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Dec 2018 00:43:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,395,1539673200"; d="scan'208";a="109828183" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 25 Dec 2018 00:43:43 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 25 Dec 2018 00:43:43 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 25 Dec 2018 00:43:43 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0415.000; Tue, 25 Dec 2018 16:43:41 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Ni, Ruiyu" , "Zeng, Star" Thread-Topic: [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper and CharToUpper Thread-Index: AQHUnCpIfdJt3ZL7DkeAKtv18P38eKWPI38w Date: Tue, 25 Dec 2018 08:43:40 +0000 Message-ID: References: <20181225081717.2776-1-shenglei.zhang@intel.com> <20181225081717.2776-5-shenglei.zhang@intel.com> In-Reply-To: <20181225081717.2776-5-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper and CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Dec 2018 08:43:45 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zhang, Shenglei > Sent: Tuesday, December 25, 2018 4:17 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star > Subject: [PATCH v4 4/7] MdeModulePkg/EbcDebugger: Use AsciiToUpper > and CharToUpper >=20 > InternalUnicodeToUpper and InternalAsciiToUpper are internal functions, > so they are substituted by public functions AsciiToUpper and CharToUpper. > And their implements are removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1369 >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++----------------- > 1 file changed, 4 insertions(+), 35 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > index 02e1876ffa..c8d9fdcb2a 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > @@ -307,37 +307,6 @@ AsciiAtoi ( > return RetVal; > } >=20 > -/** > - > - Convert the character to upper case. > - > - @param Chr the character to be converted. > - > -**/ > -STATIC > -CHAR16 > -InternalUnicodeToUpper ( > - IN CHAR16 Chr > - ) > -{ > - return (Chr >=3D L'a' && Chr <=3D L'z') ? Chr - (L'a' - L'A') : Chr; > -} > - > -/** > - > - Convert the character to upper case. > - > - @param Chr the character to be converted. > - > -**/ > -STATIC > -CHAR8 > -InternalAsciiToUpper ( > - IN CHAR8 Chr > - ) > -{ > - return (Chr >=3D 'a' && Chr <=3D 'z') ? Chr - ('a' - 'A') : Chr; > -} >=20 > /** > Compare the Unicode and Ascii string pointed by String to the string > pointed by String2. > @@ -390,12 +359,12 @@ StriCmp ( > ) > { > while ((*String !=3D L'\0') && > - (InternalUnicodeToUpper (*String) =3D=3D InternalUnicodeToUpper > (*String2))) { > + (CharToUpper (*String) =3D=3D CharToUpper (*String2))) { > String++; > String2++; > } >=20 > - return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper > (*String2); > + return CharToUpper (*String) - CharToUpper (*String2); > } >=20 > /** > @@ -418,12 +387,12 @@ StriCmpUnicodeAndAscii ( > ) > { > while ((*String !=3D L'\0') && > - (InternalUnicodeToUpper (*String) =3D=3D (CHAR16)InternalAsciiT= oUpper > (*String2))) { > + (CharToUpper (*String) =3D=3D (CHAR16)AsciiToUpper (*String2)))= { > String++; > String2++; > } >=20 > - return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper > (*String2); > + return CharToUpper (*String) - (CHAR16)AsciiToUpper (*String2); > } >=20 > /** > -- > 2.18.0.windows.1