Re: [PATCH v4 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiToUpper

["Wu, Hao A" <hao.a.wu@intel.com>]

Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Tuesday, December 25, 2018 4:17 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ruiyu; Zeng, Star
> Subject: [PATCH v4 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api
> AsciiToUpper
> 
> Substitute HttpIoCharToUpper with AsciiToUpper which is a public function
> with the same effect. And remove the implement of HttpIoCharToUpper.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1369
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +-------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> index 2fc3da8a2d..36f66a2708 100644
> --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> @@ -898,27 +898,6 @@ typedef struct {
>    UINTN                         CurrentChunkParsedSize;
>  } HTTP_BODY_PARSER;
> 
> -/**
> -
> -  Convert an Ascii char to its uppercase.
> -
> -  @param[in]       Char           Ascii character.
> -
> -  @return          Uppercase value of the input Char.
> -
> -**/
> -CHAR8
> -HttpIoCharToUpper (
> -  IN      CHAR8                    Char
> -  )
> -{
> -  if (Char >= 'a' && Char <= 'z') {
> -    return  Char - ('a' - 'A');
> -  }
> -
> -  return Char;
> -}
> -
>  /**
>    Convert an hexadecimal char to a value of type UINTN.
> 
> @@ -936,7 +915,7 @@ HttpIoHexCharToUintn (
>      return Char - '0';
>    }
> 
> -  return (10 + HttpIoCharToUpper (Char) - 'A');
> +  return (10 + AsciiToUpper (Char) - 'A');
>  }
> 
>  /**
> --
> 2.18.0.windows.1