Re: [PATCH V3 09/17] MdeModulePkg: Refine description a little for PcdEmuVariableNvStoreReserved

["Wu, Hao A" <hao.a.wu@intel.com>]

Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, January 15, 2019 6:30 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Wang, Jian J; Wu, Hao A
> Subject: [PATCH V3 09/17] MdeModulePkg: Refine description a little for
> PcdEmuVariableNvStoreReserved
> 
> This patch is not related directly to
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323
> Merge EmuVariable and Real variable driver.
> 
> PcdEmuVariableNvStoreReserved actually defines the base address of
> reserved memory range.
> 
> This patch refines description a little for PcdEmuVariableNvStoreReserved.
> 
> Suggested-by: Jian J Wang <jian.j.wang@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 6 +++---
>  MdeModulePkg/MdeModulePkg.uni | 4 ++--
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index 2be77022c948..e5c32d15edcd 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1594,9 +1594,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
> PcdsDynamic, PcdsDynamicEx]
>    # @Prompt EMU variable NV mode enable.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|FALSE
> |BOOLEAN|0x01100001
> 
> -  ## This PCD defines a reserved memory range for EMU variable NV storage.
> -  #  The range is valid if non-zero. The memory range size must be
> PcdVariableStoreSize.
> -  # @Prompt Reserved memory range for EMU variable NV storage.
> +  ## This PCD defines the base address of reserved memory range for EMU
> variable NV storage.
> +  #  A non-ZERO value indicates a valid range reserved with size given by
> PcdVariableStoreSize.
> +  # @Prompt Base of reserved memory range for EMU variable NV storage.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0|UI
> NT64|0x40000008
> 
>    ## This PCD defines the times to print hello world string.
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index 2f437d78eba2..787fdf2282c3 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -397,9 +397,9 @@
>                                                                                    "TRUE  - An EMU variable NV
> storage will be allocated or reserved for NV variables.<BR>"
>                                                                                    "FALSE - No EMU variable NV
> storage will be allocated or reserved for NV variables.<BR>"
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved
> _PROMPT  #language en-US "Reserved memory range for EMU variable NV
> storage"
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved
> _PROMPT  #language en-US "Base of reserved memory range for EMU
> variable NV storage"
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved
> _HELP  #language en-US "This PCD defines a reserved memory range for
> EMU variable NV storage. The range is valid if non-zero. The memory range
> size must be PcdVariableStoreSize."
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved
> _HELP  #language en-US "This PCD defines the base address of reserved
> memory range for EMU variable NV storage. A non-ZERO value indicates a
> valid range reserved with size given by PcdVariableStoreSize."
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintTimes_PROM
> PT  #language en-US "HelloWorld print times"
> 
> --
> 2.7.0.windows.1