From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 974AF211B5A25 for ; Tue, 15 Jan 2019 23:28:59 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 23:28:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,485,1539673200"; d="scan'208";a="128153141" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 15 Jan 2019 23:28:58 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 15 Jan 2019 23:28:57 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 15 Jan 2019 23:28:57 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.150]) with mapi id 14.03.0415.000; Wed, 16 Jan 2019 15:28:56 +0800 From: "Wu, Hao A" To: "Zeng, Star" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH V3 09/17] MdeModulePkg: Refine description a little for PcdEmuVariableNvStoreReserved Thread-Index: AQHUrL1E6sBKprQ5d0S0aS+GD8F2vqWxGNvA Date: Wed, 16 Jan 2019 07:28:54 +0000 Message-ID: References: <1547548179-42552-1-git-send-email-star.zeng@intel.com> <1547548179-42552-10-git-send-email-star.zeng@intel.com> In-Reply-To: <1547548179-42552-10-git-send-email-star.zeng@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V3 09/17] MdeModulePkg: Refine description a little for PcdEmuVariableNvStoreReserved X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Jan 2019 07:28:59 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 15, 2019 6:30 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star; Wang, Jian J; Wu, Hao A > Subject: [PATCH V3 09/17] MdeModulePkg: Refine description a little for > PcdEmuVariableNvStoreReserved >=20 > This patch is not related directly to > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1323 > Merge EmuVariable and Real variable driver. >=20 > PcdEmuVariableNvStoreReserved actually defines the base address of > reserved memory range. >=20 > This patch refines description a little for PcdEmuVariableNvStoreReserved= . >=20 > Suggested-by: Jian J Wang > Cc: Jian J Wang > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > MdeModulePkg/MdeModulePkg.dec | 6 +++--- > MdeModulePkg/MdeModulePkg.uni | 4 ++-- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 2be77022c948..e5c32d15edcd 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1594,9 +1594,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, > PcdsDynamic, PcdsDynamicEx] > # @Prompt EMU variable NV mode enable. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvModeEnable|FALSE > |BOOLEAN|0x01100001 >=20 > - ## This PCD defines a reserved memory range for EMU variable NV storag= e. > - # The range is valid if non-zero. The memory range size must be > PcdVariableStoreSize. > - # @Prompt Reserved memory range for EMU variable NV storage. > + ## This PCD defines the base address of reserved memory range for EMU > variable NV storage. > + # A non-ZERO value indicates a valid range reserved with size given b= y > PcdVariableStoreSize. > + # @Prompt Base of reserved memory range for EMU variable NV storage. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdEmuVariableNvStoreReserved|0|UI > NT64|0x40000008 >=20 > ## This PCD defines the times to print hello world string. > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index 2f437d78eba2..787fdf2282c3 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -397,9 +397,9 @@ > = "TRUE - An EMU variable NV > storage will be allocated or reserved for NV variables.
" > = "FALSE - No EMU variable NV > storage will be allocated or reserved for NV variables.
" >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved > _PROMPT #language en-US "Reserved memory range for EMU variable NV > storage" > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved > _PROMPT #language en-US "Base of reserved memory range for EMU > variable NV storage" >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved > _HELP #language en-US "This PCD defines a reserved memory range for > EMU variable NV storage. The range is valid if non-zero. The memory range > size must be PcdVariableStoreSize." > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdEmuVariableNvStoreReserved > _HELP #language en-US "This PCD defines the base address of reserved > memory range for EMU variable NV storage. A non-ZERO value indicates a > valid range reserved with size given by PcdVariableStoreSize." >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintTimes_PROM > PT #language en-US "HelloWorld print times" >=20 > -- > 2.7.0.windows.1