From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Wu, Jiaxin" <jiaxin.wu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>,
"Fu, Siyuan" <siyuan.fu@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH v3 0/3] Remove unnecessary NULL pointer check.
Date: Tue, 22 Jan 2019 08:25:24 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8802BE@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190118071747.18260-1-Jiaxin.wu@intel.com>
> -----Original Message-----
> From: Wu, Jiaxin
> Sent: Friday, January 18, 2019 3:18 PM
> To: edk2-devel@lists.01.org
> Cc: Ye, Ting; Fu, Siyuan; Wu, Hao A; Gao, Liming; Wu
> Subject: [PATCH v3 0/3] Remove unnecessary NULL pointer check.
>
> v3: Updated the first patch to check the instance token.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1469
>
> Since the value retrieved from the list Entry can't be the NULL
> pointer, the unnecessary check can be removed.
The series is good to me:
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
>
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Wu Hao A <hao.a.wu@intel.com>
> Cc: Gao Liming <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com
>
> Jiaxin Wu (3):
> MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check.
> NetworkPkg/IScsiDxe: Remove unnecessary NULL pointer check.
> NetworkPkg/DnsDxe: Remove unnecessary NULL pointer check.
>
> MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c | 11 ++++------
> NetworkPkg/DnsDxe/DnsDriver.c | 22 ++++++++-----------
> NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +----
> 3 files changed, 14 insertions(+), 25 deletions(-)
>
> --
> 2.17.1.windows.2
prev parent reply other threads:[~2019-01-22 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-18 7:17 [PATCH v3 0/3] Remove unnecessary NULL pointer check Jiaxin Wu
2019-01-18 7:17 ` [PATCH v3 1/3] MdeModulePkg/Dhcp4Dxe: " Jiaxin Wu
2019-01-18 7:17 ` [PATCH v3 2/3] NetworkPkg/IScsiDxe: " Jiaxin Wu
2019-01-18 7:17 ` [PATCH v3 3/3] NetworkPkg/DnsDxe: " Jiaxin Wu
2019-01-22 8:25 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8802BE@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox