From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 374622194D387 for ; Tue, 22 Jan 2019 00:25:30 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 00:25:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,505,1539673200"; d="scan'208";a="111674533" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 22 Jan 2019 00:25:27 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 22 Jan 2019 00:25:27 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 22 Jan 2019 00:25:27 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.196]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0415.000; Tue, 22 Jan 2019 16:25:25 +0800 From: "Wu, Hao A" To: "Wu, Jiaxin" , "edk2-devel@lists.01.org" CC: "Ye, Ting" , "Fu, Siyuan" , "Gao, Liming" Thread-Topic: [PATCH v3 0/3] Remove unnecessary NULL pointer check. Thread-Index: AQHUrv31Tsd/8jy3MEuleHHz6NOez6W6+d1Q Date: Tue, 22 Jan 2019 08:25:24 +0000 Message-ID: References: <20190118071747.18260-1-Jiaxin.wu@intel.com> In-Reply-To: <20190118071747.18260-1-Jiaxin.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 0/3] Remove unnecessary NULL pointer check. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 08:25:31 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Jiaxin > Sent: Friday, January 18, 2019 3:18 PM > To: edk2-devel@lists.01.org > Cc: Ye, Ting; Fu, Siyuan; Wu, Hao A; Gao, Liming; Wu > Subject: [PATCH v3 0/3] Remove unnecessary NULL pointer check. >=20 > v3: Updated the first patch to check the instance token. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1469 >=20 > Since the value retrieved from the list Entry can't be the NULL > pointer, the unnecessary check can be removed. The series is good to me: Reviewed-by: Hao Wu Best Regards, Hao Wu >=20 > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Wu Hao A > Cc: Gao Liming > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin =20 > Jiaxin Wu (3): > MdeModulePkg/Dhcp4Dxe: Remove unnecessary NULL pointer check. > NetworkPkg/IScsiDxe: Remove unnecessary NULL pointer check. > NetworkPkg/DnsDxe: Remove unnecessary NULL pointer check. >=20 > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Io.c | 11 ++++------ > NetworkPkg/DnsDxe/DnsDriver.c | 22 ++++++++----= ------- > NetworkPkg/IScsiDxe/IScsiConfig.c | 6 +---- > 3 files changed, 14 insertions(+), 25 deletions(-) >=20 > -- > 2.17.1.windows.2