From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Chen, Chen A" <chen.a.chen@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support
Date: Fri, 25 Jan 2019 03:03:48 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C88FFC8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190117020252.7560-1-chen.a.chen@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Chen A Chen
> Sent: Thursday, January 17, 2019 10:03 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D; Zhang, Chao B; Gao, Liming
> Subject: [edk2] [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for
> enable GPT support
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1470
> This two new definitions are defined for GPT in FatPei diver.
>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Zhang Chao B <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
> ---
> MdePkg/Include/Uefi/UefiGpt.h | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/MdePkg/Include/Uefi/UefiGpt.h
> b/MdePkg/Include/Uefi/UefiGpt.h
> index f635b05390..8665c8cbc9 100644
> --- a/MdePkg/Include/Uefi/UefiGpt.h
> +++ b/MdePkg/Include/Uefi/UefiGpt.h
> @@ -24,9 +24,25 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY
> KIND, EITHER EXPRESS OR IMPLIED.
> /// EFI Partition Table Signature: "EFI PART".
> ///
> #define EFI_PTAB_HEADER_ID SIGNATURE_64 ('E','F','I',' ','P','A','R','T')
> +///
> +/// Minimum bytes reserve for EFI entry array buffer.
> +///
> +#define GPT_PART_ENTRY_MIN_SIZE 16384
May I know where this definition comes from?
Does it come from the UEFI spec?
>
> #pragma pack(1)
>
> +///
> +/// MBR Partition Entry
> +///
> +typedef struct {
> + UINT8 BootIndicator;
> + UINT8 StartingCHS[3];
> + UINT8 OSType;
> + UINT8 EndingCHS[3];
> + UINT32 StartingLBA;
> + UINT32 SizeInLBA;
> +} MBR_PARTITION_ENTRY;
> +
What about using the 'MBR_PARTITION_RECORD' definition within
edk2/MdePkg/Include/IndustryStandard/Mbr.h
and thus get rid of adding this one?
Best Regards,
Hao Wu
> ///
> /// GPT Partition Table Header.
> ///
> --
> 2.16.2.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-01-25 3:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 2:02 [PATCH 2/2] MdePkg/UefiGpt.h: Add new definition for enable GPT support Chen A Chen
2019-01-25 3:03 ` Wu, Hao A [this message]
2019-01-25 7:16 ` Chen, Chen A
2019-01-25 7:27 ` Wu, Hao A
2019-01-25 7:44 ` Chen, Chen A
2019-01-25 7:46 ` Wu, Hao A
2019-01-25 9:13 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C88FFC8@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox