From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Wang, Jian J" <jian.j.wang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec compliance status
Date: Tue, 29 Jan 2019 03:33:39 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C892055@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <D827630B58408649ACB04F44C5100036258A7FE9@SHSMSX107.ccr.corp.intel.com>
> -----Original Message-----
> From: Wang, Jian J
> Sent: Tuesday, January 29, 2019 11:28 AM
> To: Wu, Hao A; edk2-devel@lists.01.org
> Cc: Ni, Ray
> Subject: RE: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for
> spec compliance status
>
> Just two typos (see below). With them addressed,
>
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
Thanks for the catch.
I will handle them before pushing the patch.
Best Regards,
Hao Wu
>
> > -----Original Message-----
> > From: Wu, Hao A
> > Sent: Tuesday, January 29, 2019 11:14 AM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> > Ni, Ray <ray.ni@intel.com>
> > Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for
> spec
> > compliance status
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1441
> >
> > This commit will update the file-level comments within the SdMmcPciHcDxe
> > to reflect the latest specification compliance status of the driver.
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> > ---
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 5 +++--
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c | 6 ++++--
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c | 6 ++++--
> > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni | 5 +++--
> > 4 files changed, 14 insertions(+), 8 deletions(-)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > index 1246e1d88d..025fb7faba 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf
> > @@ -1,11 +1,12 @@
> > ## @file
> > # SdMmcPciHcDxe driver is used to manage those host controllers which
> > comply with SD
> > -# Host Controller Simplified Specifiction version 3.0.
> > +# Host Controller Simplified Specifiction version 3.0 plus the 64-bit System
>
> Typo: Specifiction
>
> > Addressing
> > +# support in SD Host Controller Simplified Specification version 4.20.
> > #
> > # It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending
> > SD/MMC/eMMC cmds
> > # to specified devices from upper layer.
> > #
> > -# Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
> > +# Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> > #
> > # This program and the accompanying materials
> > # are licensed and made available under the terms and conditions of the
> BSD
> > License
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > index 76c32a4dcd..b474f8decd 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c
> > @@ -1,11 +1,13 @@
> > /** @file
> > This driver is used to manage SD/MMC PCI host controllers which are
> > compliance
> > - with SD Host Controller Simplified Specification version 3.00.
> > + with SD Host Controller Simplified Specification version 3.00 plus the 64-bit
> > + System Addressing support in SD Host Controller Simplified Specification
> > version
> > + 4.20.
> >
> > It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> >
> > Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> > - Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the BSD
> > License
> > which accompanies this distribution. The full text of the license may be
> found
> > at
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > index 5aec8c6992..4c64da3b20 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c
> > @@ -1,11 +1,13 @@
> > /** @file
> > This driver is used to manage SD/MMC PCI host controllers which are
> > compliance
> > - with SD Host Controller Simplified Specification version 3.00.
> > + with SD Host Controller Simplified Specification version 3.00 plus the 64-bit
> > + System Addressing support in SD Host Controller Simplified Specification
> > version
> > + 4.20.
> >
> > It would expose EFI_SD_MMC_PASS_THRU_PROTOCOL for upper layer use.
> >
> > Copyright (c) 2018, NVIDIA CORPORATION. All rights reserved.
> > - Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
> > + Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> > This program and the accompanying materials
> > are licensed and made available under the terms and conditions of the BSD
> > License
> > which accompanies this distribution. The full text of the license may be
> found
> > at
> > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> > index 57f9fa76a1..497d2cc9f0 100644
> > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.uni
> > @@ -1,11 +1,12 @@
> > // /** @file
> > // SdMmcPciHcDxe driver is used to manage those host controllers which
> > comply with SD
> > -// Host Controller Simplified Specifiction version 3.0.
> > +// Host Controller Simplified Specifiction version 3.0 plus the 64-bit System
>
> Typo: Specifiction
>
> > Addressing
> > +// support in SD Host Controller Simplified Specification version 4.20.
> > //
> > // It will produce EFI_SD_MMC_PASS_THRU_PROTOCOL to allow sending
> > SD/MMC/eMMC cmds
> > // to specified devices from upper layer.
> > //
> > -// Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
> > +// Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
> > //
> > // This program and the accompanying materials
> > // are licensed and made available under the terms and conditions of the
> BSD
> > License
> > --
> > 2.12.0.windows.1
prev parent reply other threads:[~2019-01-29 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-29 3:14 [PATCH] MdeModulePkg/SdMmcPciHcDxe: Update comment for spec compliance status Hao Wu
2019-01-29 3:28 ` Wang, Jian J
2019-01-29 3:33 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C892055@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox