From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper
Date: Wed, 30 Jan 2019 08:04:49 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8927F1@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190130063417.11308-6-shenglei.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, January 30, 2019 2:34 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star
> Subject: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api
> AsciiCharToUpper
>
> Substitute HttpIoCharToUpper with AsciiCharToUpper which is a public function
> with the same effect. And remove the implement of HttpIoCharToUpper.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1369
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +-------------------
> 1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> index 2fc3da8a2d..3884bc8361 100644
> --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c
> @@ -898,27 +898,6 @@ typedef struct {
> UINTN CurrentChunkParsedSize;
> } HTTP_BODY_PARSER;
>
> -/**
> -
> - Convert an Ascii char to its uppercase.
> -
> - @param[in] Char Ascii character.
> -
> - @return Uppercase value of the input Char.
> -
> -**/
> -CHAR8
> -HttpIoCharToUpper (
> - IN CHAR8 Char
> - )
> -{
> - if (Char >= 'a' && Char <= 'z') {
> - return Char - ('a' - 'A');
> - }
> -
> - return Char;
> -}
> -
> /**
> Convert an hexadecimal char to a value of type UINTN.
>
> @@ -936,7 +915,7 @@ HttpIoHexCharToUintn (
> return Char - '0';
> }
>
> - return (10 + HttpIoCharToUpper (Char) - 'A');
> + return (10 + AsciiCharToUpper (Char) - 'A');
Please help to update the copyright year for file DxeHttpLib.c.
With this handled:
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
There is no need to send a new version of series for this.
Best Regards,
Hao Wu
> }
>
> /**
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-01-30 8:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 6:34 [PATCH v5 0/7] Introduce two public functions and remove internal ones Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 2/7] MdePkg/BaseLib: Introduce CharToUpper and AsciiCharToUpper publicly Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 3/7] MdePkg/BaseLib: Remove definitions of two functions Shenglei Zhang
2019-01-30 6:34 ` [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A
2019-01-30 6:34 ` [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper Shenglei Zhang
2019-01-30 8:04 ` Wu, Hao A [this message]
2019-01-30 6:34 ` [PATCH v5 6/7] ShellPkg/Shell: Use BaseLib api CharToUpper Shenglei Zhang
2019-01-30 16:13 ` Carsey, Jaben
2019-01-30 6:34 ` [PATCH v5 7/7] ShellPkg/UefiShellLib: " Shenglei Zhang
2019-01-30 16:13 ` Carsey, Jaben
2019-01-30 9:36 ` [PATCH v5 0/7] Introduce two public functions and remove internal ones Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8927F1@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox