From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.31; helo=mga06.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 81FD6211BB8B9 for ; Wed, 30 Jan 2019 00:04:52 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 00:04:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="134348947" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga001.jf.intel.com with ESMTP; 30 Jan 2019 00:04:51 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 00:04:51 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 00:04:50 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.36]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 16:04:49 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" Thread-Topic: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper Thread-Index: AQHUuGXeAoSgj+f12E67e/pXZQ3WFKXHc7DQ Date: Wed, 30 Jan 2019 08:04:49 +0000 Message-ID: References: <20190130063417.11308-1-shenglei.zhang@intel.com> <20190130063417.11308-6-shenglei.zhang@intel.com> In-Reply-To: <20190130063417.11308-6-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api AsciiCharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 08:04:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, January 30, 2019 2:34 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star > Subject: [PATCH v5 5/7] MdeModulePkg/DxeHttpLib: Use BaseLib api > AsciiCharToUpper >=20 > Substitute HttpIoCharToUpper with AsciiCharToUpper which is a public func= tion > with the same effect. And remove the implement of HttpIoCharToUpper. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1369 >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c | 23 +------------------- > 1 file changed, 1 insertion(+), 22 deletions(-) >=20 > diff --git a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c > b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c > index 2fc3da8a2d..3884bc8361 100644 > --- a/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c > +++ b/MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.c > @@ -898,27 +898,6 @@ typedef struct { > UINTN CurrentChunkParsedSize; > } HTTP_BODY_PARSER; >=20 > -/** > - > - Convert an Ascii char to its uppercase. > - > - @param[in] Char Ascii character. > - > - @return Uppercase value of the input Char. > - > -**/ > -CHAR8 > -HttpIoCharToUpper ( > - IN CHAR8 Char > - ) > -{ > - if (Char >=3D 'a' && Char <=3D 'z') { > - return Char - ('a' - 'A'); > - } > - > - return Char; > -} > - > /** > Convert an hexadecimal char to a value of type UINTN. >=20 > @@ -936,7 +915,7 @@ HttpIoHexCharToUintn ( > return Char - '0'; > } >=20 > - return (10 + HttpIoCharToUpper (Char) - 'A'); > + return (10 + AsciiCharToUpper (Char) - 'A'); Please help to update the copyright year for file DxeHttpLib.c. With this handled: Reviewed-by: Hao Wu There is no need to send a new version of series for this.=20 Best Regards, Hao Wu > } >=20 > /** > -- > 2.18.0.windows.1