Re: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, January 30, 2019 2:34 PM
> To: edk2-devel@lists.01.org
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star
> Subject: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names
> 
> Change UnicodeToUpper to InternalUnicodeToUpper.
> Change AsciiToUpper to InternalAsciiToUpper.
> These changes are committed for bisectability, or build failure will
> occur when 2/7 is applied. Because the introduced function names in
> 2/7 are the same as ones in EdbSupporting.c.
> https://bugzilla.tianocore.org/show_bug.cgi?id=1369
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> Reviewed-by: Hao Wu <hao.a.wu@intel.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> ---
>  .../Universal/EbcDxe/EbcDebugger/EdbSupportString.c  | 12 ++++++------

Please help to update the copyright year for file EdbSupportString.c.

You can keep my 'Reviewed-by' tag and do not need to send a new version of
series for this. 

Best Regards,
Hao Wu

>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
> index 78a0559079..02e1876ffa 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c
> @@ -316,7 +316,7 @@ AsciiAtoi (
>  **/
>  STATIC
>  CHAR16
> -UnicodeToUpper (
> +InternalUnicodeToUpper (
>    IN      CHAR16                    Chr
>    )
>  {
> @@ -332,7 +332,7 @@ UnicodeToUpper (
>  **/
>  STATIC
>  CHAR8
> -AsciiToUpper (
> +InternalAsciiToUpper (
>    IN      CHAR8                     Chr
>    )
>  {
> @@ -390,12 +390,12 @@ StriCmp (
>    )
>  {
>    while ((*String != L'\0') &&
> -         (UnicodeToUpper (*String) == UnicodeToUpper (*String2))) {
> +         (InternalUnicodeToUpper (*String) == InternalUnicodeToUpper
> (*String2))) {
>      String++;
>      String2++;
>    }
> 
> -  return UnicodeToUpper (*String) - UnicodeToUpper (*String2);
> +  return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper
> (*String2);
>  }
> 
>  /**
> @@ -418,12 +418,12 @@ StriCmpUnicodeAndAscii (
>    )
>  {
>    while ((*String != L'\0') &&
> -         (UnicodeToUpper (*String) == (CHAR16)AsciiToUpper (*String2))) {
> +         (InternalUnicodeToUpper (*String) == (CHAR16)InternalAsciiToUpper
> (*String2))) {
>      String++;
>      String2++;
>    }
> 
> -  return UnicodeToUpper (*String) - (CHAR16)AsciiToUpper (*String2);
> +  return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper
> (*String2);
>  }
> 
>  /**
> --
> 2.18.0.windows.1