From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 760EB211BB8B9 for ; Wed, 30 Jan 2019 00:04:55 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 00:04:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="129683451" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jan 2019 00:04:54 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 00:04:53 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.174]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 16:04:52 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" Thread-Topic: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names Thread-Index: AQHUuGXbrO5nixg0CU2kaWlv2G/qu6XHcpog Date: Wed, 30 Jan 2019 08:04:51 +0000 Message-ID: References: <20190130063417.11308-1-shenglei.zhang@intel.com> <20190130063417.11308-2-shenglei.zhang@intel.com> In-Reply-To: <20190130063417.11308-2-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 08:04:55 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, January 30, 2019 2:34 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star > Subject: [PATCH v5 1/7] MdeModulePkg/EbcDebugger: Change function names >=20 > Change UnicodeToUpper to InternalUnicodeToUpper. > Change AsciiToUpper to InternalAsciiToUpper. > These changes are committed for bisectability, or build failure will > occur when 2/7 is applied. Because the introduced function names in > 2/7 are the same as ones in EdbSupporting.c. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1369 >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Reviewed-by: Hao Wu > Reviewed-by: Liming Gao > --- > .../Universal/EbcDxe/EbcDebugger/EdbSupportString.c | 12 ++++++------ Please help to update the copyright year for file EdbSupportString.c. You can keep my 'Reviewed-by' tag and do not need to send a new version of series for this.=20 Best Regards, Hao Wu > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > index 78a0559079..02e1876ffa 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > @@ -316,7 +316,7 @@ AsciiAtoi ( > **/ > STATIC > CHAR16 > -UnicodeToUpper ( > +InternalUnicodeToUpper ( > IN CHAR16 Chr > ) > { > @@ -332,7 +332,7 @@ UnicodeToUpper ( > **/ > STATIC > CHAR8 > -AsciiToUpper ( > +InternalAsciiToUpper ( > IN CHAR8 Chr > ) > { > @@ -390,12 +390,12 @@ StriCmp ( > ) > { > while ((*String !=3D L'\0') && > - (UnicodeToUpper (*String) =3D=3D UnicodeToUpper (*String2))) { > + (InternalUnicodeToUpper (*String) =3D=3D InternalUnicodeToUpper > (*String2))) { > String++; > String2++; > } >=20 > - return UnicodeToUpper (*String) - UnicodeToUpper (*String2); > + return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper > (*String2); > } >=20 > /** > @@ -418,12 +418,12 @@ StriCmpUnicodeAndAscii ( > ) > { > while ((*String !=3D L'\0') && > - (UnicodeToUpper (*String) =3D=3D (CHAR16)AsciiToUpper (*String2= ))) { > + (InternalUnicodeToUpper (*String) =3D=3D (CHAR16)InternalAsciiT= oUpper > (*String2))) { > String++; > String2++; > } >=20 > - return UnicodeToUpper (*String) - (CHAR16)AsciiToUpper (*String2); > + return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper > (*String2); > } >=20 > /** > -- > 2.18.0.windows.1