From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5DE91211BB8B9 for ; Wed, 30 Jan 2019 00:05:01 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 00:05:00 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,540,1539673200"; d="scan'208";a="129683468" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 30 Jan 2019 00:05:00 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 30 Jan 2019 00:04:59 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.172]) with mapi id 14.03.0415.000; Wed, 30 Jan 2019 16:04:58 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" Thread-Topic: [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper Thread-Index: AQHUuGXdV1Ez311+E0SoYJTS6SuE1qXHc3PQ Date: Wed, 30 Jan 2019 08:04:57 +0000 Message-ID: References: <20190130063417.11308-1-shenglei.zhang@intel.com> <20190130063417.11308-5-shenglei.zhang@intel.com> In-Reply-To: <20190130063417.11308-5-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper and CharToUpper X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jan 2019 08:05:01 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, January 30, 2019 2:34 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star > Subject: [PATCH v5 4/7] MdeModulePkg/EbcDebugger: Use AsciiCharToUpper > and CharToUpper >=20 > InternalUnicodeToUpper and InternalAsciiToUpper are internal functions, > so they are substituted by public functions AsciiCharToUpper and CharToUp= per. > And their implements are removed. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1369 >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../EbcDxe/EbcDebugger/EdbSupportString.c | 39 ++----------------- > 1 file changed, 4 insertions(+), 35 deletions(-) >=20 > diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > index 02e1876ffa..d34acf892b 100644 > --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > @@ -307,37 +307,6 @@ AsciiAtoi ( > return RetVal; > } >=20 > -/** > - > - Convert the character to upper case. > - > - @param Chr the character to be converted. > - > -**/ > -STATIC > -CHAR16 > -InternalUnicodeToUpper ( > - IN CHAR16 Chr > - ) > -{ > - return (Chr >=3D L'a' && Chr <=3D L'z') ? Chr - (L'a' - L'A') : Chr; > -} > - > -/** > - > - Convert the character to upper case. > - > - @param Chr the character to be converted. > - > -**/ > -STATIC > -CHAR8 > -InternalAsciiToUpper ( > - IN CHAR8 Chr > - ) > -{ > - return (Chr >=3D 'a' && Chr <=3D 'z') ? Chr - ('a' - 'A') : Chr; > -} >=20 > /** > Compare the Unicode and Ascii string pointed by String to the string p= ointed > by String2. > @@ -390,12 +359,12 @@ StriCmp ( > ) > { > while ((*String !=3D L'\0') && > - (InternalUnicodeToUpper (*String) =3D=3D InternalUnicodeToUpper > (*String2))) { > + (CharToUpper (*String) =3D=3D CharToUpper (*String2))) { > String++; > String2++; > } >=20 > - return InternalUnicodeToUpper (*String) - InternalUnicodeToUpper (*Str= ing2); > + return CharToUpper (*String) - CharToUpper (*String2); > } >=20 > /** > @@ -418,12 +387,12 @@ StriCmpUnicodeAndAscii ( > ) > { > while ((*String !=3D L'\0') && > - (InternalUnicodeToUpper (*String) =3D=3D (CHAR16)InternalAsciiT= oUpper > (*String2))) { > + (CharToUpper (*String) =3D=3D (CHAR16)AsciiCharToUpper (*String= 2))) { > String++; > String2++; > } >=20 > - return InternalUnicodeToUpper (*String) - (CHAR16)InternalAsciiToUpper > (*String2); > + return CharToUpper (*String) - (CHAR16)AsciiCharToUpper (*String2); Reviewed-by: Hao Wu Best Regards, Hao Wu > } >=20 > /** > -- > 2.18.0.windows.1