From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 629DF211B76D5 for ; Thu, 31 Jan 2019 22:22:52 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 22:22:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,547,1539673200"; d="scan'208";a="296407517" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 31 Jan 2019 22:22:52 -0800 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 22:22:49 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 31 Jan 2019 22:22:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.232]) with mapi id 14.03.0415.000; Fri, 1 Feb 2019 14:22:39 +0800 From: "Wu, Hao A" To: "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [patch 1/2] MdeModulePkg: Fix coding style issues Thread-Index: AQHUufO4d3eq/QRVw0Kmu2GOH1tWXKXKeQ+Q Date: Fri, 1 Feb 2019 06:22:39 +0000 Message-ID: References: <20190201060200.40136-1-dandan.bi@intel.com> <20190201060200.40136-2-dandan.bi@intel.com> In-Reply-To: <20190201060200.40136-2-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 1/2] MdeModulePkg: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 06:22:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Bi, Dandan > Sent: Friday, February 01, 2019 2:02 PM > To: edk2-devel@lists.01.org > Cc: Ard Biesheuvel; Wang, Jian J; Wu, Hao A > Subject: [patch 1/2] MdeModulePkg: Fix coding style issues >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1479 >=20 > Fix issues that reported by Edk2 coding style check tool(ECC) that: > Comment description should end with period '.' >=20 > Cc: Ard Biesheuvel > Cc: Jian J Wang > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > .../FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 4 ++-- > .../FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c | 2 +- > .../FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c | 2 +- > .../Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h | 4 ++-- > .../Universal/Variable/RuntimeDxe/VariableStandaloneMm.c | 6 +++--- > .../Universal/Variable/RuntimeDxe/VariableTraditionalMm.c | 4 ++-- > 6 files changed, 11 insertions(+), 11 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo > mmon.h > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo > mmon.h > index 61293ca864..cf1aef7ca4 100644 > --- > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo > mmon.h > +++ > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCo > mmon.h > @@ -76,11 +76,11 @@ typedef struct { > BOOLEAN Complete; > UINT8 Data[1]; > } SMM_FTW_GET_LAST_WRITE_HEADER; >=20 > /** > - Shared entry point of the module > + Shared entry point of the module. >=20 > @retval EFI_SUCCESS The initialization finished successfully= . > @retval EFI_OUT_OF_RESOURCES Allocate memory error > @retval EFI_INVALID_PARAMETER Workspace or Spare block does not exist >=20 > @@ -107,11 +107,11 @@ FtwSmmIsBufferOutsideSmmValid ( > IN EFI_PHYSICAL_ADDRESS Buffer, > IN UINT64 Length > ); >=20 > /** > - Notify the system that the SMM FTW driver is ready > + Notify the system that the SMM FTW driver is ready. > **/ > VOID > FtwNotifySmmReady ( > VOID > ); > diff --git > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > oneMm.c > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > oneMm.c > index 8a4ea5b476..c2aa501465 100644 > --- > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > oneMm.c > +++ > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandal > oneMm.c > @@ -63,11 +63,11 @@ FtwCalculateCrc32 ( > { > return CalculateCrc32 (Buffer, Length); > } >=20 > /** > - Notify the system that the SMM FTW driver is ready > + Notify the system that the SMM FTW driver is ready. > **/ > VOID > FtwNotifySmmReady ( > VOID > ) > diff --git > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi > onalMm.c > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi > onalMm.c > index 0981c3c2a9..7c76e1f756 100644 > --- > a/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi > onalMm.c > +++ > b/MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditi > onalMm.c > @@ -70,11 +70,11 @@ FtwCalculateCrc32 ( >=20 > return ReturnValue; > } >=20 > /** > - Notify the system that the SMM FTW driver is ready > + Notify the system that the SMM FTW driver is ready. > **/ > VOID > FtwNotifySmmReady ( > VOID > ) > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h > b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h > index 0a886558f4..9b294e6b36 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/PrivilegePolymorphic.h > @@ -96,19 +96,19 @@ VOID > VariableSpeculationBarrier ( > VOID > ); >=20 > /** > - Notify the system that the SMM variable driver is ready > + Notify the system that the SMM variable driver is ready. > **/ > VOID > VariableNotifySmmReady ( > VOID > ); >=20 > /** > - Notify the system that the SMM variable write driver is ready > + Notify the system that the SMM variable write driver is ready. > **/ > VOID > VariableNotifySmmWriteReady ( > VOID > ); > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > index 1e87ccfb5d..2eed038054 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > @@ -36,31 +36,31 @@ VariableSmmIsBufferOutsideSmmValid ( > { > return TRUE; > } >=20 > /** > - Notify the system that the SMM variable driver is ready > + Notify the system that the SMM variable driver is ready. > **/ > VOID > VariableNotifySmmReady ( > VOID > ) > { > } >=20 > /** > - Notify the system that the SMM variable write driver is ready > + Notify the system that the SMM variable write driver is ready. > **/ > VOID > VariableNotifySmmWriteReady ( > VOID > ) > { > } >=20 > /** > - Variable service MM driver entry point > + Variable service MM driver entry point. >=20 > @param[in] ImageHandle A handle for the image that is initializing = this > driver > @param[in] MmSystemTable A pointer to the MM system table >=20 > diff --git > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > index 84f2d12b58..42e2c63c3a 100644 > --- > a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > +++ > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > @@ -38,11 +38,11 @@ VariableSmmIsBufferOutsideSmmValid ( > { > return SmmIsBufferOutsideSmmValid (Buffer, Length); > } >=20 > /** > - Notify the system that the SMM variable driver is ready > + Notify the system that the SMM variable driver is ready. > **/ > VOID > VariableNotifySmmReady ( > VOID > ) > @@ -59,11 +59,11 @@ VariableNotifySmmReady ( > ); > ASSERT_EFI_ERROR (Status); > } >=20 > /** > - Notify the system that the SMM variable write driver is ready > + Notify the system that the SMM variable write driver is ready. Reviewed-by: Hao Wu Best Regards, Hao Wu > **/ > VOID > VariableNotifySmmWriteReady ( > VOID > ) > -- > 2.18.0.windows.1