From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 97834211C6072 for ; Fri, 1 Feb 2019 02:54:25 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 02:54:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,548,1539673200"; d="scan'208";a="114473513" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 01 Feb 2019 02:54:24 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Feb 2019 02:54:24 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Feb 2019 02:54:23 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.102]) by shsmsx102.ccr.corp.intel.com ([169.254.2.207]) with mapi id 14.03.0415.000; Fri, 1 Feb 2019 18:54:21 +0800 From: "Wu, Hao A" To: Laszlo Ersek , "edk2-devel@lists.01.org" CC: "Zeng, Star" Thread-Topic: [edk2] [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox() Thread-Index: AQHUufGyCwWGij1LVkyqcqwYsGqUL6XKI/6AgACgEKA= Date: Fri, 1 Feb 2019 10:54:21 +0000 Message-ID: References: <20190201054728.8612-1-hao.a.wu@intel.com> <20190201054728.8612-11-hao.a.wu@intel.com> <1d5d58ca-50d8-e365-7507-8666f7eebdde@redhat.com> In-Reply-To: <1d5d58ca-50d8-e365-7507-8666f7eebdde@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v3 10/12] MdeModulePkg/SmmLockBox(PEI): Remove an ASSERT in RestoreLockBox() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2019 10:54:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBMYXN6bG8gRXJzZWsgW21haWx0 bzpsZXJzZWtAcmVkaGF0LmNvbV0NCj4gU2VudDogRnJpZGF5LCBGZWJydWFyeSAwMSwgMjAxOSA1 OjE4IFBNDQo+IFRvOiBXdSwgSGFvIEE7IGVkazItZGV2ZWxAbGlzdHMuMDEub3JnDQo+IENjOiBa ZW5nLCBTdGFyDQo+IFN1YmplY3Q6IFJlOiBbZWRrMl0gW1BBVENIIHYzIDEwLzEyXSBNZGVNb2R1 bGVQa2cvU21tTG9ja0JveChQRUkpOg0KPiBSZW1vdmUgYW4gQVNTRVJUIGluIFJlc3RvcmVMb2Nr Qm94KCkNCj4gDQo+IE9uIDAyLzAxLzE5IDA2OjQ3LCBIYW8gV3Ugd3JvdGU6DQo+ID4gVGhpcyBj b21taXQgaXMgb3V0IG9mIHRoZSBzY29wZSBmb3IgQlotMTQwOS4gSXQgaXMgYSByZWZpbmVtZW50 IGZvciB0aGUNCj4gPiBQRUkgbGlicmFyeSBpbnN0YW5jZSB3aXRoaW4gU21tTG9ja0JveExpYi4N Cj4gPg0KPiA+IEZvciB0aGUgYmVsb3cgQVNTRVJUIHN0YXRlbWVudCB3aXRoaW4gZnVuY3Rpb24g UmVzdG9yZUxvY2tCb3goKToNCj4gPiAgIFN0YXR1cyA9IFNtbUNvbW11bmljYXRpb25QcGktPkNv bW11bmljYXRlICgNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU21tQ29t bXVuaWNhdGlvblBwaSwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJkNv bW1CdWZmZXJbMF0sDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZDb21t U2l6ZQ0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICApOw0KPiA+ICAgaWYg KFN0YXR1cyA9PSBFRklfTk9UX1NUQVJURUQpIHsNCj4gPiAgICAgLy8NCj4gPiAgICAgLy8gUGVp IFNNTSBjb21tdW5pY2F0aW9uIG5vdCByZWFkeSB5ZXQsIHNvIHdlIGFjY2VzcyBTTVJBTSBkaXJl Y3RseQ0KPiA+ICAgICAvLw0KPiA+ICAgICBERUJVRyAoKERFQlVHX0lORk8sICJTbW1Mb2NrQm94 UGVpTGliIENvbW11bmljYXRlIC0gKCVyKVxuIiwNCj4gU3RhdHVzKSk7DQo+ID4gICAgIFN0YXR1 cyA9IEludGVybmFsUmVzdG9yZUxvY2tCb3hGcm9tU21yYW0gKEd1aWQsIEJ1ZmZlciwgTGVuZ3Ro KTsNCj4gPiAgICAgTG9ja0JveFBhcmFtZXRlclJlc3RvcmUtPkhlYWRlci5SZXR1cm5TdGF0dXMg PSAoVUlOVDY0KVN0YXR1czsNCj4gPiAgICAgaWYgKExlbmd0aCAhPSBOVUxMKSB7DQo+ID4gICAg ICAgTG9ja0JveFBhcmFtZXRlclJlc3RvcmUtPkxlbmd0aCA9IChVSU5UNjQpKkxlbmd0aDsNCj4g PiAgICAgfQ0KPiA+ICAgfQ0KPiA+ICAgQVNTRVJUX0VGSV9FUlJPUiAoU3RhdHVzKTsNCj4gPg0K PiA+IEl0IGlzIHBvc3NpYmxlIGZvciBwcmV2aW91cyBjb2RlcyB0byByZXR1cm4gYW4gZXJyb3Ig c3RhdHVzIHRoYXQgaXMNCj4gPiBwb3NzaWJsZSBmb3IgaGFwcGVuLiBPbmUgZXhhbXBsZSBpcyB0 aGF0LCB3aGVuIHRoZSAnaWYnIHN0YXRlbWVudA0KPiA+ICdpZiAoU3RhdHVzID09IEVGSV9OT1Rf U1RBUlRFRCkgeycgaXMgZW50ZXJlZCwgZnVuY3Rpb24NCj4gPiBJbnRlcm5hbFJlc3RvcmVMb2Nr Qm94RnJvbVNtcmFtKCkgaXMgcG9zc2libGUgdG8gcmV0dXJuDQo+ICdCVUZGRVJfVE9PX1NNQUxM Jw0KPiA+IGlmIHRoZSBjYWxsZXIgb2YgUmVzdG9yZUxvY2tCb3goKSBwcm92aWRlcyBhIGJ1ZmZl ciB0aGF0IGlzIHRvbyBzbWFsbCB0bw0KPiA+IGhvbGQgdGhlIGNvbnRlbnQgb2YgTG9ja0JveC4N Cj4gPg0KPiA+IFRodXMsIHRoaXMgY29tbWl0IHdpbGwgcmVtb3ZlIHRoZSBBU1NFUlQgaGVyZS4N Cj4gPg0KPiA+IFBsZWFzZSBub3RlIHRoYXQgdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2Yg UmVzdG9yZUxvY2tCb3goKSBpcw0KPiA+IGhhbmRsaW5nIHRoZSBhYm92ZS1tZW50aW9uZWQgZXJy b3IgY2FzZSBwcm9wZXJseSwgc28gbm8gYWRkaXRpb25hbCBlcnJvcg0KPiA+IGhhbmRsaW5nIGNv ZGVzIGFyZSBuZWVkZWQgaGVyZS4NCj4gPg0KPiA+IENjOiBKaWFuIEogV2FuZyA8amlhbi5qLndh bmdAaW50ZWwuY29tPg0KPiA+IENjOiBTdGFyIFplbmcgPHN0YXIuemVuZ0BpbnRlbC5jb20+DQo+ ID4gQ29udHJpYnV0ZWQtdW5kZXI6IFRpYW5vQ29yZSBDb250cmlidXRpb24gQWdyZWVtZW50IDEu MQ0KPiA+IFNpZ25lZC1vZmYtYnk6IEhhbyBXdSA8aGFvLmEud3VAaW50ZWwuY29tPg0KPiA+IFJl dmlld2VkLWJ5OiBSYXkgTmkgPHJheS5uaUBpbnRlbC5jb20+DQo+ID4gLS0tDQo+ID4gIE1kZU1v ZHVsZVBrZy9MaWJyYXJ5L1NtbUxvY2tCb3hMaWIvU21tTG9ja0JveFBlaUxpYi5jIHwgMSAtDQo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGRlbGV0aW9uKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEv TWRlTW9kdWxlUGtnL0xpYnJhcnkvU21tTG9ja0JveExpYi9TbW1Mb2NrQm94UGVpTGliLmMNCj4g Yi9NZGVNb2R1bGVQa2cvTGlicmFyeS9TbW1Mb2NrQm94TGliL1NtbUxvY2tCb3hQZWlMaWIuYw0K PiA+IGluZGV4IDlmNzM0ODAwNzAuLjhjM2U2NWJjOTYgMTAwNjQ0DQo+ID4gLS0tIGEvTWRlTW9k dWxlUGtnL0xpYnJhcnkvU21tTG9ja0JveExpYi9TbW1Mb2NrQm94UGVpTGliLmMNCj4gPiArKysg Yi9NZGVNb2R1bGVQa2cvTGlicmFyeS9TbW1Mb2NrQm94TGliL1NtbUxvY2tCb3hQZWlMaWIuYw0K PiA+IEBAIC02MjMsNyArNjIzLDYgQEAgUmVzdG9yZUxvY2tCb3ggKA0KPiA+ICAgICAgICBMb2Nr Qm94UGFyYW1ldGVyUmVzdG9yZS0+TGVuZ3RoID0gKFVJTlQ2NCkqTGVuZ3RoOw0KPiA+ICAgICAg fQ0KPiA+ICAgIH0NCj4gPiAtICBBU1NFUlRfRUZJX0VSUk9SIChTdGF0dXMpOw0KPiA+DQo+ID4g ICAgaWYgKExlbmd0aCAhPSBOVUxMKSB7DQo+ID4gICAgICAqTGVuZ3RoID0gKFVJTlROKUxvY2tC b3hQYXJhbWV0ZXJSZXN0b3JlLT5MZW5ndGg7DQo+ID4NCj4gDQo+IE9WTUYgbmV2ZXIgcmVhY2hl cyB0aGlzIGNvZGUgcGF0aCBiZWNhdXNlIGl0IGRvZXNuJ3QgaW5jbHVkZSBhbg0KPiBFRklfUEVJ X1NNTV9DT01NVU5JQ0FUSU9OX1BQSSBpbnN0YW5jZS4gVGhlcmVmb3JlIE9WTUYgYWx3YXlzIGdv ZXMNCj4gdGhyb3VnaCBJbnRlcm5hbFJlc3RvcmVMb2NrQm94RnJvbVNtcmFtKCkuDQo+IA0KPiBT ZWUgY29tbWl0IGJkM2FmZWIxZDYyYyAoIk1kZU1vZHVsZVBrZzogU21tTG9ja0JveFBlaUxpYjog d29yayB3aXRob3V0DQo+IEVGSV9QRUlfU01NX0NPTU1VTklDQVRJT05fUFBJIiwgMjAxNS0xMS0x NikuDQo+IA0KPiBJbiB0aGF0IHJlZ2FyZCwgSSdtIE9LIHdpdGggdGhpcyBwYXRjaDsgdGhpcyBh bG9uZSB3b3VsZCBzdWZmaWNlIGZvciBtZQ0KPiB0byBnaXZlIGFuIEFja2VkLWJ5Lg0KPiANCj4g SG93ZXZlciwgaGF2aW5nIHJlLXJldmlld2VkIGJkM2FmZWIxZDYyYyBub3csIEkgc2VlIHRoYXQg dGhpcyBwYXRjaCBpcw0KPiBhY3R1YWxseSB0ZWNobmljYWxseSBjb3JyZWN0LiBTbyBJIGJlbGll dmUgSSBjYW4gZ2l2ZSBhbiBSLWIgdG9vLA0KPiBkZXNwaXRlIE9WTUYgbm90IHVzaW5nIHRoZSBh ZmZlY3RlZCBjb2RlIHBhdGguDQo+IA0KPiBSZXZpZXdlZC1ieTogTGFzemxvIEVyc2VrIDxsZXJz ZWtAcmVkaGF0LmNvbT4NCj4gDQo+IE90aGVyIHRoYW4gdGhhdCwgeW91IG1pZ2h0IHdhbnQgdG8g cmV2aWV3IGV4aXN0aW5nIGNhbGxlcnMgb2YgdGhpcw0KPiBmdW5jdGlvbiwgdG8gZW5zdXJlIHRo ZXkgZG9uJ3QgcmVseSBvbiBhbnkgc3VjaCBmYWlsdXJlIGJlaW5nIGNhdWdodA0KPiBpbnRlcm5h bGx5IHRvIHRoZSBmdW5jdGlvbiAodmlhIHRoZSBBU1NFUlQgdGhhdCdzIG5vdyBiZWluZyByZW1v dmVkKS4NCj4gQWdhaW4sIHRoaXMgd291bGQgb25seSBiZSByZWxldmFudCBmb3IgcGxhdGZvcm1z IHRoYXQgcHJvZHVjZSBhbg0KPiBFRklfUEVJX1NNTV9DT01NVU5JQ0FUSU9OX1BQSSBpbnN0YW5j ZS4NCg0KU3VyZS4gVGhhbmtzIGZvciB0aGUgcmVtaW5kZXIuDQpJIHdpbGwgY2hlY2sgdGhvc2Ug Y2FsbGVycyBiZWZvcmUgcHVzaGluZyB0aGlzIGNoYW5nZS4NCg0KQmVzdCBSZWdhcmRzLA0KSGFv IFd1DQoNCj4gDQo+IFRoYW5rcw0KPiBMYXN6bG8NCg==