Re: [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jordan Justen
> Sent: Saturday, March 16, 2019 2:17 AM
> To: Ard Biesheuvel; Wu, Hao A
> Cc: edk2-devel@lists.01.org; Laszlo Ersek
> Subject: Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within
> IntelFrameworkModulePkg
> 
> On 2019-03-15 04:09:56, Ard Biesheuvel wrote:
> > On Fri, 15 Mar 2019 at 08:16, Hao Wu <hao.a.wu@intel.com> wrote:
> > >
> > > This series will update the OVMF to stop using the ISA drivers within
> > > IntelFrameworkModulePkg.
> > >
> > > As the replacement, a new OVMF Super I/O bus driver has been add
> which
> > > will install the Super I/O protocol for ISA serial and PS2 keyboard
> > > devices. By doing so, these devices can be managed by:
> > >
> > >   MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf
> > >   MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf
> > >
> > > respectively.
> > >
> >
> > Just a couple of notes from my side - I'm sure Laszlo will have a much
> > longer list :-)
> >
> > - Dropping the floppy driver is fine with me.
> > - What is OVMF specific about this driver? Is it only the hardcoded
> > list of COM1/COM2/PS2 keyboard? If so, should we split this into a
> > driver and a library class, where the driver lives in MdeModulePkg,
> > and the library is implemented in the context of OVMF?
> > - Regardless of the previous, adding the new driver should be a patch
> > of its own.
> 
> Yeah. I think the first patch should add the new driver, and update
> the .dsc files to build the new driver. But, don't update the .fdf, so
> there shouldn't be a functional change to the OVMF output after the
> first patch.
> 
> Then the second patch can modify the .dsc and .fdf files to swap out
> the drivers.

Hello Jordan,

Agree. I will follow your suggestion in the next version of the patch.
Thanks for the feedback.

Best Regards,
Hao Wu

> 
> -Jordan
> 
> > - I spotted an incorrect reference to PCI_IO_DEV in a comment (patch #2)
> >
> >
> >
> > >
> > > Tests done:
> > > A. GCC5 & VS2015x86 tool chains build pass
> > > B. Launch QEMU (2.4.50, Windows) with command:
> > >    > qemu-system-x86_64.exe -pflash <SOME_PATH>\OVMF.fd -serial
> file:1.txt -serial file:2.txt
> > >
> > >    Able to see the ISA COM1/COM2 UART and PS2Keyboard devices under
> Shell
> > >    using command 'devtree';
> > >
> > >    Both the serials and PS2 keyboard are working fine;
> > >
> > > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > > Cc: Laszlo Ersek <lersek@redhat.com>
> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > >
> > > Hao Wu (2):
> > >   OvmfPkg: Drop the ISA Floppy device support
> > >   OvmfPkg: Add an Super IO bus driver to replace the current ISA support
> > >
> > >  OvmfPkg/OvmfPkgIa32.dsc           |  10 +-
> > >  OvmfPkg/OvmfPkgIa32X64.dsc        |  10 +-
> > >  OvmfPkg/OvmfPkgX64.dsc            |  10 +-
> > >  OvmfPkg/OvmfPkgIa32.fdf           |  10 +-
> > >  OvmfPkg/OvmfPkgIa32X64.fdf        |  10 +-
> > >  OvmfPkg/OvmfPkgX64.fdf            |  10 +-
> > >  OvmfPkg/SioBusDxe/SioBusDxe.inf   |  54 ++
> > >  OvmfPkg/SioBusDxe/SioBusDxe.h     | 332 +++++++++++
> > >  OvmfPkg/SioBusDxe/SioService.h    | 221 +++++++
> > >  OvmfPkg/SioBusDxe/ComponentName.c | 167 ++++++
> > >  OvmfPkg/SioBusDxe/SioBusDxe.c     | 622 ++++++++++++++++++++
> > >  OvmfPkg/SioBusDxe/SioService.c    | 405 +++++++++++++
> > >  OvmfPkg/SioBusDxe/SioBusDxe.uni   |  21 +
> > >  13 files changed, 1846 insertions(+), 36 deletions(-)
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.inf
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.h
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioService.h
> > >  create mode 100644 OvmfPkg/SioBusDxe/ComponentName.c
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.c
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioService.c
> > >  create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.uni
> > >
> > > --
> > > 2.12.0.windows.1
> > >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel