From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2D62021959CB2 for ; Sun, 17 Mar 2019 20:47:04 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Mar 2019 20:47:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,492,1544515200"; d="scan'208";a="153257241" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 17 Mar 2019 20:47:03 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 17 Mar 2019 20:47:03 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 17 Mar 2019 20:47:03 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.113]) with mapi id 14.03.0415.000; Mon, 18 Mar 2019 11:47:01 +0800 From: "Wu, Hao A" To: "Justen, Jordan L" , Ard Biesheuvel CC: "edk2-devel@lists.01.org" , Laszlo Ersek Thread-Topic: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg Thread-Index: AQHU2v72KKi1QVwWtUSZpr1S5QC+TqYMAyMAgAB3PQCABEnDcA== Date: Mon, 18 Mar 2019 03:47:00 +0000 Message-ID: References: <20190315071603.16936-1-hao.a.wu@intel.com> <155267380200.30417.2941036035350773974@jljusten-skl> In-Reply-To: <155267380200.30417.2941036035350773974@jljusten-skl> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v1 0/2] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Mar 2019 03:47:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Jordan Justen > Sent: Saturday, March 16, 2019 2:17 AM > To: Ard Biesheuvel; Wu, Hao A > Cc: edk2-devel@lists.01.org; Laszlo Ersek > Subject: Re: [edk2] [PATCH v1 0/2] Ovmf: Stop using ISA drivers within > IntelFrameworkModulePkg >=20 > On 2019-03-15 04:09:56, Ard Biesheuvel wrote: > > On Fri, 15 Mar 2019 at 08:16, Hao Wu wrote: > > > > > > This series will update the OVMF to stop using the ISA drivers within > > > IntelFrameworkModulePkg. > > > > > > As the replacement, a new OVMF Super I/O bus driver has been add > which > > > will install the Super I/O protocol for ISA serial and PS2 keyboard > > > devices. By doing so, these devices can be managed by: > > > > > > MdeModulePkg/Bus/Pci/PciSioSerialDxe/PciSioSerialDxe.inf > > > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > > > > > respectively. > > > > > > > Just a couple of notes from my side - I'm sure Laszlo will have a much > > longer list :-) > > > > - Dropping the floppy driver is fine with me. > > - What is OVMF specific about this driver? Is it only the hardcoded > > list of COM1/COM2/PS2 keyboard? If so, should we split this into a > > driver and a library class, where the driver lives in MdeModulePkg, > > and the library is implemented in the context of OVMF? > > - Regardless of the previous, adding the new driver should be a patch > > of its own. >=20 > Yeah. I think the first patch should add the new driver, and update > the .dsc files to build the new driver. But, don't update the .fdf, so > there shouldn't be a functional change to the OVMF output after the > first patch. >=20 > Then the second patch can modify the .dsc and .fdf files to swap out > the drivers. Hello Jordan, Agree. I will follow your suggestion in the next version of the patch. Thanks for the feedback. Best Regards, Hao Wu >=20 > -Jordan >=20 > > - I spotted an incorrect reference to PCI_IO_DEV in a comment (patch #2= ) > > > > > > > > > > > > Tests done: > > > A. GCC5 & VS2015x86 tool chains build pass > > > B. Launch QEMU (2.4.50, Windows) with command: > > > > qemu-system-x86_64.exe -pflash \OVMF.fd -serial > file:1.txt -serial file:2.txt > > > > > > Able to see the ISA COM1/COM2 UART and PS2Keyboard devices under > Shell > > > using command 'devtree'; > > > > > > Both the serials and PS2 keyboard are working fine; > > > > > > Cc: Jordan Justen > > > Cc: Laszlo Ersek > > > Cc: Ard Biesheuvel > > > Cc: Ray Ni > > > > > > Hao Wu (2): > > > OvmfPkg: Drop the ISA Floppy device support > > > OvmfPkg: Add an Super IO bus driver to replace the current ISA supp= ort > > > > > > OvmfPkg/OvmfPkgIa32.dsc | 10 +- > > > OvmfPkg/OvmfPkgIa32X64.dsc | 10 +- > > > OvmfPkg/OvmfPkgX64.dsc | 10 +- > > > OvmfPkg/OvmfPkgIa32.fdf | 10 +- > > > OvmfPkg/OvmfPkgIa32X64.fdf | 10 +- > > > OvmfPkg/OvmfPkgX64.fdf | 10 +- > > > OvmfPkg/SioBusDxe/SioBusDxe.inf | 54 ++ > > > OvmfPkg/SioBusDxe/SioBusDxe.h | 332 +++++++++++ > > > OvmfPkg/SioBusDxe/SioService.h | 221 +++++++ > > > OvmfPkg/SioBusDxe/ComponentName.c | 167 ++++++ > > > OvmfPkg/SioBusDxe/SioBusDxe.c | 622 ++++++++++++++++++++ > > > OvmfPkg/SioBusDxe/SioService.c | 405 +++++++++++++ > > > OvmfPkg/SioBusDxe/SioBusDxe.uni | 21 + > > > 13 files changed, 1846 insertions(+), 36 deletions(-) > > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.inf > > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.h > > > create mode 100644 OvmfPkg/SioBusDxe/SioService.h > > > create mode 100644 OvmfPkg/SioBusDxe/ComponentName.c > > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.c > > > create mode 100644 OvmfPkg/SioBusDxe/SioService.c > > > create mode 100644 OvmfPkg/SioBusDxe/SioBusDxe.uni > > > > > > -- > > > 2.12.0.windows.1 > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel