From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8F94721959CB2 for ; Wed, 20 Mar 2019 22:22:21 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Mar 2019 22:22:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,251,1549958400"; d="scan'208";a="127288820" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 20 Mar 2019 22:22:20 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 22:22:20 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 20 Mar 2019 22:22:19 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.74]) by shsmsx102.ccr.corp.intel.com ([169.254.2.163]) with mapi id 14.03.0415.000; Thu, 21 Mar 2019 13:22:17 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , "edk2-devel@lists.01.org" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Thread-Topic: [PATCH V3 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI Thread-Index: AQHU3mg18qAuSecUHk2pB3Wc+lSrDKYVg79Q Date: Thu, 21 Mar 2019 05:22:17 +0000 Message-ID: References: <20190319152549.16104-1-zhichao.gao@intel.com> <20190319152549.16104-15-zhichao.gao@intel.com> In-Reply-To: <20190319152549.16104-15-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V3 14/17] MdeModulePkg: Add definitions for EDKII DEBUG PPI X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Mar 2019 05:22:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, March 19, 2019 11:26 PM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Broga= n; > Michael Turner; Bret Barkelew > Subject: [PATCH V3 14/17] MdeModulePkg: Add definitions for EDKII DEBUG > PPI >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 >=20 > Add a debug PPI for PEI phase. This PPI will provide basic > services of debug. PEI debug lib instance can use these > services to implement debug function to reduce the PEIMs > which consume the debug lib. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > --- > MdeModulePkg/Include/Ppi/Debug.h | 90 > ++++++++++++++++++++++++++++++++++++++++ > MdeModulePkg/MdeModulePkg.dec | 3 ++ > 2 files changed, 93 insertions(+) > create mode 100644 MdeModulePkg/Include/Ppi/Debug.h >=20 > diff --git a/MdeModulePkg/Include/Ppi/Debug.h > b/MdeModulePkg/Include/Ppi/Debug.h > new file mode 100644 > index 0000000000..40db304f3d > --- /dev/null > +++ b/MdeModulePkg/Include/Ppi/Debug.h > @@ -0,0 +1,90 @@ > +/** @file > + Define the EDKII_DEBUG_PPI that PEIMs can use to dump info to debug > port. > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions > + of the BSD License which accompanies this distribution. The > + full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > + > +**/ > + > +#ifndef __EDKII_DEBUG_PPI_H__ > +#define __EDKII_DEBUG_PPI_H__ > + > +#include > + > +// > +// Global ID for the EDKII_DEBUG_PPI > +// > +#define EDKII_DEBUG_PPI_GUID \ > + { \ > + 0x999e699c, 0xb013, 0x475e, {0xb1, 0x7b, 0xf3, 0xa8, 0xae, 0x5c, 0x4= 8, > 0x75} \ > + } > + > +/// > +/// Forward declaration for the PEI_DEBUG_LIB_DEBUG_PPI > EDKII_DEBUG_PPI > +/// > +typedef struct _EDKII_DEBUG_PPI EDKII_DEBUG_PPI; > + > +/** > + Print a debug message to debug output device if the specified error le= vel > + is enabled. > + > + @param[in] PeiServices The pointer to the PEI Services Ta= ble. > + @param[in] This The pointer to this instance of > EDKII_DEBUG_PPI > + @param[in] ErrorLevel The error level of the debug messa= ge. > + @param[in] Format Format string for the debug messag= e to print. > + @param[in] Marker BASE_LIST marker for the variable = argument > list. > + > +**/ > +typedef > +VOID > +(EFIAPI *EDKII_DEBUG_BPRINT)( > + IN CONST EFI_PEI_SERVICES **PeiServices, > + IN EDKII_DEBUG_PPI *This, > + IN UINTN ErrorLevel, > + IN CONST CHAR8 *Format, > + IN BASE_LIST Marker > + ); Hello, I checked the PEIM that implements this PPI (patch 15/17), and I did not find the parameters 'PeiServices' & 'This' are being used there. Thus, I suggest to remove those 2 parameters from the interfaces of EFIAPI *EDKII_DEBUG_BPRINT EFIAPI *EDKII_DEBUG_ASSERT Best Regards, Hao Wu > + > +/** > + Print an assert message containing a filename, line number, and > description. > + This may be followed by a breakpoint or a dead loop. > + > + @param[in] PeiServices The pointer to the PEI Services Ta= ble. > + @param[in] This The pointer to this instance of > EDKII_DEBUG_PPI > + @param[in] FileName The pointer to the name of the sou= rce file > that > + generated the assert condition. > + @param[in] LineNumber The line number in the source file= that > generated > + the assert condition > + @param[in] Description The pointer to the description of = the assert > condition. > + > +**/ > +typedef > +VOID > +(EFIAPI *EDKII_DEBUG_ASSERT)( > + IN CONST EFI_PEI_SERVICES **PeiServices, > + IN EDKII_DEBUG_PPI *This, > + IN CONST CHAR8 *FileName, > + IN UINTN LineNumber, > + IN CONST CHAR8 *Description > + ); > + > +/// > +/// This PPI contains a set of services to print message to debug output > device > +/// > +struct _EDKII_DEBUG_PPI { > + EDKII_DEBUG_BPRINT DebugBPrint; > + EDKII_DEBUG_ASSERT DebugAssert; > +}; > + > +extern EFI_GUID gEdkiiDebugPpiGuid; > + > +#endif > + > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index a2130bc439..9bbd0572f5 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -492,6 +492,9 @@ > ## Include/Ppi/AtaPassThru.h > gEdkiiPeiAtaPassThruPpiGuid =3D { 0xa16473fd, 0xd474, 0x= 4c89, { 0xae, > 0xc7, 0x90, 0xb8, 0x3c, 0x73, 0x86, 0x9 } } >=20 > + ## Include/Ppi/Debug.h > + gEdkiiDebugPpiGuid =3D { 0x999e699c, 0xb013, 0x= 475e, { 0xb1, > 0x7b, 0xf3, 0xa8, 0xae, 0x5c, 0x48, 0x75 } } > + > [Protocols] > ## Load File protocol provides capability to load and unload EFI image= into > memory and execute it. > # Include/Protocol/LoadPe32Image.h > -- > 2.16.2.windows.1