Re: [PATCH 0/3] Implement UFS info protocol to pass additional UIC programming data from platform/silicon specific driver

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Albecki, Mateusz
> Sent: Thursday, March 28, 2019 9:49 PM
> To: edk2-devel@lists.01.org
> Cc: Albecki, Mateusz; Wu; Wu, Hao A
> Subject: [PATCH 0/3] Implement UFS info protocol to pass additional UIC
> programming data from platform/silicon specific driver
> 
> UFS specification allows for additional, implementation specific, programming
> to be done during host controller initialization. Since some hosts
> might require it to allow for device detection we add a way for platform/silicon
> specific code to pass required attributes and their values to
> generic UFS driver. Please see UFS 2.0 specification for details of the host
> controller initialization sequence(JESD223B section 7.1.1 step 4).
> Patchset consists of 3 patches to achieve this. The first one is a bugfix for data
> transfers that are not aligned to DWORD boundary such as SCSI SENSE
> command. The second one is code refactoring for device presence detection
> that cleans up the function that sends UIC commands. Final patch defines
> UFS info protocol and implements driver logic for servicing it.
> 
> Tests performed:
> -Test UFS LU enumeration with UFS 2.0 card with 3 enabled LUs
> -Test that no unaligned data transfers are performed during enumeration
> -Test that UIC is programmed according to platform table

Hello Mateusz,

For the additional UIC during HC initialization change, could you help to
verify a 'reconnect -r' under Shell to see whether the UFS devices work
fine in such case? Thanks.

Best Regards,
Hao Wu


> -Test that driver operation is not impacted when no UFS info protocol is
> installed
> 
> CC: Wu, Hao A <hao.a.wu@intel.com>
> 
> Albecki, Mateusz (3):
>   MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling
>   MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection
>   MdeModulePkg/UfsPassThruDxe: Add UFS info protocol
> 
>  MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c  |  62 +++++
>  MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h  |   3 +
>  .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf      |   1 +
>  .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c        | 299 +++++++++++++++-----
> -
>  .../Include/Protocol/UfsHostControllerInfo.h       |  75 ++++++
>  MdeModulePkg/MdeModulePkg.dec                      |   3 +
>  6 files changed, 356 insertions(+), 87 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Protocol/UfsHostControllerInfo.h
> 
> --
> 2.14.1.windows.1