From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DB5ED211D38FF for ; Sun, 31 Mar 2019 23:54:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2019 23:53:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,295,1549958400"; d="scan'208";a="332545145" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 31 Mar 2019 23:53:28 -0700 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 23:53:28 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 31 Mar 2019 23:53:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Mon, 1 Apr 2019 14:53:26 +0800 From: "Wu, Hao A" To: "Albecki, Mateusz" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 0/3] Implement UFS info protocol to pass additional UIC programming data from platform/silicon specific driver Thread-Index: AQHU5Wz+bSCpyNl/+kOHqdgsTGG3A6Ym3Ebw Date: Mon, 1 Apr 2019 06:53:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] Implement UFS info protocol to pass additional UIC programming data from platform/silicon specific driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Apr 2019 06:54:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Albecki, Mateusz > Sent: Thursday, March 28, 2019 9:49 PM > To: edk2-devel@lists.01.org > Cc: Albecki, Mateusz; Wu; Wu, Hao A > Subject: [PATCH 0/3] Implement UFS info protocol to pass additional UIC > programming data from platform/silicon specific driver >=20 > UFS specification allows for additional, implementation specific, program= ming > to be done during host controller initialization. Since some hosts > might require it to allow for device detection we add a way for platform/= silicon > specific code to pass required attributes and their values to > generic UFS driver. Please see UFS 2.0 specification for details of the h= ost > controller initialization sequence(JESD223B section 7.1.1 step 4). > Patchset consists of 3 patches to achieve this. The first one is a bugfix= for data > transfers that are not aligned to DWORD boundary such as SCSI SENSE > command. The second one is code refactoring for device presence detection > that cleans up the function that sends UIC commands. Final patch defines > UFS info protocol and implements driver logic for servicing it. >=20 > Tests performed: > -Test UFS LU enumeration with UFS 2.0 card with 3 enabled LUs > -Test that no unaligned data transfers are performed during enumeration > -Test that UIC is programmed according to platform table Hello Mateusz, For the additional UIC during HC initialization change, could you help to verify a 'reconnect -r' under Shell to see whether the UFS devices work fine in such case? Thanks. Best Regards, Hao Wu > -Test that driver operation is not impacted when no UFS info protocol is > installed >=20 > CC: Wu, Hao A >=20 > Albecki, Mateusz (3): > MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling > MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection > MdeModulePkg/UfsPassThruDxe: Add UFS info protocol >=20 > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.c | 62 +++++ > MdeModulePkg/Bus/Ufs/UfsPassThruDxe/UfsPassThru.h | 3 + > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruDxe.inf | 1 + > .../Bus/Ufs/UfsPassThruDxe/UfsPassThruHci.c | 299 +++++++++++++++= ----- > - > .../Include/Protocol/UfsHostControllerInfo.h | 75 ++++++ > MdeModulePkg/MdeModulePkg.dec | 3 + > 6 files changed, 356 insertions(+), 87 deletions(-) > create mode 100644 MdeModulePkg/Include/Protocol/UfsHostControllerInfo.h >=20 > -- > 2.14.1.windows.1