From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E3910211E9584 for ; Mon, 1 Apr 2019 18:33:07 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 18:33:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,298,1549958400"; d="scan'208";a="139179383" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 01 Apr 2019 18:33:07 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 18:33:06 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 1 Apr 2019 18:33:06 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.147]) with mapi id 14.03.0415.000; Tue, 2 Apr 2019 09:33:04 +0800 From: "Wu, Hao A" To: "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: Remove .S files Thread-Index: AQHU6GVE5xbw5sImmUCf+XSUohHeQ6YoFzZg Date: Tue, 2 Apr 2019 01:33:03 +0000 Message-ID: References: <20190401082943.4152-1-shenglei.zhang@intel.com> <20190401082943.4152-14-shenglei.zhang@intel.com> In-Reply-To: <20190401082943.4152-14-shenglei.zhang@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: Remove .S files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 01:33:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Zhang, Shenglei > Sent: Monday, April 01, 2019 4:30 PM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A > Subject: [PATCH v4 13/14] SourceLevelDebugPkg/PeCoffExtraActionLibDebug: > Remove .S files >=20 > .nasm file has been added for X86 arch. .S assembly code > is not required any more. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1594 >=20 > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > --- > .../Ia32/IntHandler.S | 28 ------------------- > .../PeCoffExtraActionLibDebug.inf | 2 -- > .../X64/IntHandler.S | 28 ------------------- > 3 files changed, 58 deletions(-) > delete mode 100644 > SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > delete mode 100644 > SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S >=20 > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > deleted file mode 100644 > index 69c903788c..0000000000 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/Ia32/IntHandler.S > +++ /dev/null > @@ -1,28 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -# > -# Copyright (c) 2013, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the = BSD > License > -# which accompanies this distribution. The full text of the license may= be > found at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# IntHandler.S > -# > -# Abstract: > -# > -# Assembly interrupt handler function. > -# > -#-----------------------------------------------------------------------= ------- > - > -ASM_GLOBAL ASM_PFX(AsmInterruptHandle) > - > -.text > -ASM_PFX(AsmInterruptHandle): > - cli > - movb $1, %al > - iretl > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > index 1c52a000b0..fd56b8c94a 100644 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > +++ > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraAction > LibDebug.inf > @@ -35,12 +35,10 @@ > [Sources.IA32] > Ia32/IntHandlerFuncs.c > Ia32/IntHandler.nasm > - Ia32/IntHandler.S >=20 > [Sources.X64] > X64/IntHandlerFuncs.c > X64/IntHandler.nasm > - X64/IntHandler.S >=20 > [Packages] > MdePkg/MdePkg.dec > diff --git > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > b/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > deleted file mode 100644 > index 108b40cf6d..0000000000 > --- > a/SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/X64/IntHandler.S > +++ /dev/null > @@ -1,28 +0,0 @@ > -#-----------------------------------------------------------------------= ------- > -# > -# Copyright (c) 2013, Intel Corporation. All rights reserved.
> -# This program and the accompanying materials > -# are licensed and made available under the terms and conditions of the = BSD > License > -# which accompanies this distribution. The full text of the license may= be > found at > -# http://opensource.org/licenses/bsd-license.php. > -# > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > BASIS, > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER > EXPRESS OR IMPLIED. > -# > -# Module Name: > -# > -# IntHandler.S > -# > -# Abstract: > -# > -# Assembly interrupt handler function. > -# > -#-----------------------------------------------------------------------= ------- > - > -ASM_GLOBAL ASM_PFX(AsmInterruptHandle) > - > -.text > -ASM_PFX(AsmInterruptHandle): > - cli > - movb $1, %al > - iretq > -- > 2.18.0.windows.1