[PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF

public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed

* [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
@ 2019-04-03  6:31 shenglei
  2019-04-03  7:26 ` Wu, Hao A
       [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>
  0 siblings, 2 replies; 4+ messages in thread
From: shenglei @ 2019-04-03  6:31 UTC (permalink / raw)
  To: edk2-devel; +Cc: Hao Wu, Shenglei Zhang

AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
And also it should be removed in SecPeiDebugAgentLib.inf and
SmmDebugAgentLib.inf.

Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
 SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 --
 SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf    | 2 --
 2 files changed, 4 deletions(-)

diff --git a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
index 03ebbb6e74..8b81795d96 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
+++ b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
@@ -39,14 +39,12 @@
   DebugAgentCommon/DebugMp.h
 
 [Sources.Ia32]
-  DebugAgentCommon/Ia32/AsmFuncs.S
   DebugAgentCommon/Ia32/AsmFuncs.nasm
   DebugAgentCommon/Ia32/ArchDebugSupport.h
   DebugAgentCommon/Ia32/ArchDebugSupport.c
   DebugAgentCommon/Ia32/DebugException.h
 
 [Sources.X64]
-  DebugAgentCommon/X64/AsmFuncs.S
   DebugAgentCommon/X64/AsmFuncs.nasm
   DebugAgentCommon/X64/ArchDebugSupport.h
   DebugAgentCommon/X64/ArchDebugSupport.c
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
index 08ed1777be..f1b32daab3 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
+++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
@@ -39,14 +39,12 @@
   DebugAgentCommon/DebugMp.h
 
 [Sources.Ia32]
-  DebugAgentCommon/Ia32/AsmFuncs.S
   DebugAgentCommon/Ia32/AsmFuncs.nasm
   DebugAgentCommon/Ia32/ArchDebugSupport.h
   DebugAgentCommon/Ia32/ArchDebugSupport.c
   DebugAgentCommon/Ia32/DebugException.h
 
 [Sources.X64]
-  DebugAgentCommon/X64/AsmFuncs.S
   DebugAgentCommon/X64/AsmFuncs.nasm
   DebugAgentCommon/X64/ArchDebugSupport.h
   DebugAgentCommon/X64/ArchDebugSupport.c
-- 
2.18.0.windows.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
  2019-04-03  6:31 [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF shenglei
@ 2019-04-03  7:26 ` Wu, Hao A
  2019-04-03  7:30   ` Wu, Hao A
       [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>
  1 sibling, 1 reply; 4+ messages in thread
From: Wu, Hao A @ 2019-04-03  7:26 UTC (permalink / raw)
  To: Zhang, Shenglei, edk2-devel@lists.01.org

Reviewed-by: Hao Wu <hao.a.wu@intel.com>

I will push this patch shortly to address the build failure for
SourceLevelDebugPkg.

Best Regards,
Hao Wu


> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, April 03, 2019 2:32 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A; Zhang, Shenglei
> Subject: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S
> in INF
> 
> AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
> And also it should be removed in SecPeiDebugAgentLib.inf and
> SmmDebugAgentLib.inf.
> 
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 --
>  SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf    | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> index 03ebbb6e74..8b81795d96 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> @@ -39,14 +39,12 @@
>    DebugAgentCommon/DebugMp.h
> 
>  [Sources.Ia32]
> -  DebugAgentCommon/Ia32/AsmFuncs.S
>    DebugAgentCommon/Ia32/AsmFuncs.nasm
>    DebugAgentCommon/Ia32/ArchDebugSupport.h
>    DebugAgentCommon/Ia32/ArchDebugSupport.c
>    DebugAgentCommon/Ia32/DebugException.h
> 
>  [Sources.X64]
> -  DebugAgentCommon/X64/AsmFuncs.S
>    DebugAgentCommon/X64/AsmFuncs.nasm
>    DebugAgentCommon/X64/ArchDebugSupport.h
>    DebugAgentCommon/X64/ArchDebugSupport.c
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> index 08ed1777be..f1b32daab3 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> @@ -39,14 +39,12 @@
>    DebugAgentCommon/DebugMp.h
> 
>  [Sources.Ia32]
> -  DebugAgentCommon/Ia32/AsmFuncs.S
>    DebugAgentCommon/Ia32/AsmFuncs.nasm
>    DebugAgentCommon/Ia32/ArchDebugSupport.h
>    DebugAgentCommon/Ia32/ArchDebugSupport.c
>    DebugAgentCommon/Ia32/DebugException.h
> 
>  [Sources.X64]
> -  DebugAgentCommon/X64/AsmFuncs.S
>    DebugAgentCommon/X64/AsmFuncs.nasm
>    DebugAgentCommon/X64/ArchDebugSupport.h
>    DebugAgentCommon/X64/ArchDebugSupport.c
> --
> 2.18.0.windows.1



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
  2019-04-03  7:26 ` Wu, Hao A
@ 2019-04-03  7:30   ` Wu, Hao A
  0 siblings, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2019-04-03  7:30 UTC (permalink / raw)
  To: Wu, Hao A, Zhang, Shenglei, edk2-devel@lists.01.org

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Wu, Hao A
> Sent: Wednesday, April 03, 2019 3:27 PM
> To: Zhang, Shenglei; edk2-devel@lists.01.org
> Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> 
> Reviewed-by: Hao Wu <hao.a.wu@intel.com>
> 
> I will push this patch shortly to address the build failure for
> SourceLevelDebugPkg.

Pushed via commit 7ed72121b753a7493a8c5bf3711b5efbc5e80491.


> 
> Best Regards,
> Hao Wu
> 
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Wednesday, April 03, 2019 2:32 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A; Zhang, Shenglei
> > Subject: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S
> > in INF
> >
> > AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
> > And also it should be removed in SecPeiDebugAgentLib.inf and
> > SmmDebugAgentLib.inf.
> >
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 -
> -
> >  SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf    | 2 -
> -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git
> > a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > index 03ebbb6e74..8b81795d96 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > diff --git
> > a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > index 08ed1777be..f1b32daab3 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > --
> > 2.18.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>]

* Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF
       [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>
@ 2019-04-04  3:15   ` shenglei.zhang
  0 siblings, 0 replies; 4+ messages in thread
From: shenglei.zhang @ 2019-04-04  3:15 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io

A commit(50cb4b90311fa5353df921fce42de5ad188da658) has been pushed to fix the build failure.

Thanks,
Shenglei

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, April 3, 2019 7:31 PM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: RE: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> 
> Do you check CI result?
> 
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> shenglei
> > Sent: Wednesday, April 3, 2019 2:32 PM
> > To: edk2-devel@lists.01.org
> > Cc: Wu, Hao A <hao.a.wu@intel.com>
> > Subject: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove
> AsmFuncs.S in INF
> >
> > AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680.
> > And also it should be removed in SecPeiDebugAgentLib.inf and
> > SmmDebugAgentLib.inf.
> >
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> >  SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 -
> -
> >  SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf    | 2 -
> -
> >  2 files changed, 4 deletions(-)
> >
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > index 03ebbb6e74..8b81795d96 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > index 08ed1777be..f1b32daab3 100644
> > --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf
> > @@ -39,14 +39,12 @@
> >    DebugAgentCommon/DebugMp.h
> >
> >  [Sources.Ia32]
> > -  DebugAgentCommon/Ia32/AsmFuncs.S
> >    DebugAgentCommon/Ia32/AsmFuncs.nasm
> >    DebugAgentCommon/Ia32/ArchDebugSupport.h
> >    DebugAgentCommon/Ia32/ArchDebugSupport.c
> >    DebugAgentCommon/Ia32/DebugException.h
> >
> >  [Sources.X64]
> > -  DebugAgentCommon/X64/AsmFuncs.S
> >    DebugAgentCommon/X64/AsmFuncs.nasm
> >    DebugAgentCommon/X64/ArchDebugSupport.h
> >    DebugAgentCommon/X64/ArchDebugSupport.c
> > --
> > 2.18.0.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-04  3:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-03  6:31 [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF shenglei
2019-04-03  7:26 ` Wu, Hao A
2019-04-03  7:30   ` Wu, Hao A
     [not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E41EA35@SHSMSX104.ccr.corp.intel.com>
2019-04-04  3:15   ` [edk2] " shenglei.zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox