From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=hao.a.wu@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 77302211E830C for ; Wed, 3 Apr 2019 00:30:51 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2019 00:30:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,303,1549958400"; d="scan'208";a="128208463" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 03 Apr 2019 00:30:50 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 00:30:50 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Apr 2019 00:30:50 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Wed, 3 Apr 2019 15:30:48 +0800 From: "Wu, Hao A" To: "Wu, Hao A" , "Zhang, Shenglei" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF Thread-Index: AQHU6eclbCvtPHY/0UScjckCMWiRs6YqCRAwgAABTRA= Date: Wed, 3 Apr 2019 07:30:48 +0000 Message-ID: References: <20190403063135.10428-1-shenglei.zhang@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove AsmFuncs.S in INF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Apr 2019 07:30:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Wu, Hao A > Sent: Wednesday, April 03, 2019 3:27 PM > To: Zhang, Shenglei; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg/DebugAgent: Remove > AsmFuncs.S in INF >=20 > Reviewed-by: Hao Wu >=20 > I will push this patch shortly to address the build failure for > SourceLevelDebugPkg. Pushed via commit 7ed72121b753a7493a8c5bf3711b5efbc5e80491. >=20 > Best Regards, > Hao Wu >=20 >=20 > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Wednesday, April 03, 2019 2:32 PM > > To: edk2-devel@lists.01.org > > Cc: Wu, Hao A; Zhang, Shenglei > > Subject: [PATCH] SourceLevelDebugPkg/DebugAgent: Remove > AsmFuncs.S > > in INF > > > > AsmFuncs.S is removed at c7d22535f7dc90b8fef70153ef98549228569680. > > And also it should be removed in SecPeiDebugAgentLib.inf and > > SmmDebugAgentLib.inf. > > > > Cc: Hao Wu > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Shenglei Zhang > > --- > > SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf | 2 - > - > > SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf | 2 - > - > > 2 files changed, 4 deletions(-) > > > > diff --git > > a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > > index 03ebbb6e74..8b81795d96 100644 > > --- a/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > > +++ > b/SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > > @@ -39,14 +39,12 @@ > > DebugAgentCommon/DebugMp.h > > > > [Sources.Ia32] > > - DebugAgentCommon/Ia32/AsmFuncs.S > > DebugAgentCommon/Ia32/AsmFuncs.nasm > > DebugAgentCommon/Ia32/ArchDebugSupport.h > > DebugAgentCommon/Ia32/ArchDebugSupport.c > > DebugAgentCommon/Ia32/DebugException.h > > > > [Sources.X64] > > - DebugAgentCommon/X64/AsmFuncs.S > > DebugAgentCommon/X64/AsmFuncs.nasm > > DebugAgentCommon/X64/ArchDebugSupport.h > > DebugAgentCommon/X64/ArchDebugSupport.c > > diff --git > > a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > > b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > > index 08ed1777be..f1b32daab3 100644 > > --- a/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > > +++ b/SourceLevelDebugPkg/Library/DebugAgent/SmmDebugAgentLib.inf > > @@ -39,14 +39,12 @@ > > DebugAgentCommon/DebugMp.h > > > > [Sources.Ia32] > > - DebugAgentCommon/Ia32/AsmFuncs.S > > DebugAgentCommon/Ia32/AsmFuncs.nasm > > DebugAgentCommon/Ia32/ArchDebugSupport.h > > DebugAgentCommon/Ia32/ArchDebugSupport.c > > DebugAgentCommon/Ia32/DebugException.h > > > > [Sources.X64] > > - DebugAgentCommon/X64/AsmFuncs.S > > DebugAgentCommon/X64/AsmFuncs.nasm > > DebugAgentCommon/X64/ArchDebugSupport.h > > DebugAgentCommon/X64/ArchDebugSupport.c > > -- > > 2.18.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel