From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: hao.a.wu@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Sun, 07 Apr 2019 23:49:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2019 23:49:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; d="scan'208";a="133865302" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 07 Apr 2019 23:49:36 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 23:49:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 7 Apr 2019 23:49:36 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.42]) with mapi id 14.03.0415.000; Mon, 8 Apr 2019 14:49:31 +0800 From: "Wu, Hao A" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Wang, Jian J" Subject: Re: [patch V2 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Topic: [patch V2 4/7] MdeModulePkg: Move BaseUefiTianoCustomDecompressLib to Thread-Index: AQHU7c2wSNEEXeznmUCP2f1roPGcPKYx0pCQ Date: Mon, 8 Apr 2019 06:49:31 +0000 Message-ID: References: <20190408054044.23452-1-dandan.bi@intel.com> <20190408054044.23452-5-dandan.bi@intel.com> In-Reply-To: <20190408054044.23452-5-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable If all platform owners are fine with the temporary build failure: Reviewed-by: Hao Wu Best Regards, Hao Wu > -----Original Message----- > From: Bi, Dandan > Sent: Monday, April 08, 2019 1:41 PM > To: devel@edk2.groups.io > Cc: Gao, Liming; Wang, Jian J; Wu, Hao A > Subject: [patch V2 4/7] MdeModulePkg: Move > BaseUefiTianoCustomDecompressLib to >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1683 >=20 > We will remove IntelFrameworkModulePkg, > but BaseUefiTianoCustomDecompressLib may still need > to be used. So move BaseUefiTianoCustomDecompressLib > from IntelFrameworkModulePkg to MdeModulePkg. >=20 > Cc: Liming Gao > Cc: Jian J Wang > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec | 4 ---- > IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc | 1 - > .../Include/Guid/TianoDecompress.h | 0 > .../BaseUefiTianoCustomDecompressLib.c | 0 > .../BaseUefiTianoCustomDecompressLib.inf | 2 +- > .../BaseUefiTianoCustomDecompressLibInternals.h | 0 > .../BaseUefiTianoDecompressLib.uni | 0 > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.dsc | 1 + > 9 files changed, 6 insertions(+), 6 deletions(-) > rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Include/Guid/TianoDecompress.h (100%) > rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLib.c (100%) > rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLib.inf (94%) > rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noCustomDecompressLibInternals.h (100%) > rename {IntelFrameworkModulePkg =3D> > MdeModulePkg}/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTia > noDecompressLib.uni (100%) >=20 > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > index 5557b5a1cd..0a451dd9ee 100644 > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > @@ -40,14 +40,10 @@ >=20 > ## GUID identifies Data Hub records logged by Status Code Runtime > Protocol. > # Include/Guid/DataHubStatusCodeRecord.h > gEfiDataHubStatusCodeRecordGuid =3D { 0xD083E94C, 0x6560, 0x42E4, { 0x= B6, > 0xD4, 0x2D, 0xF7, 0x5A, 0xDF, 0x6A, 0x2A }} >=20 > - ## GUID indicates the tiano custom compress/decompress algorithm. > - # Include/Guid/TianoDecompress.h > - gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, { 0x9= 5, > 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} > - > ## Include/Guid/AcpiVariable.h > gEfiAcpiVariableCompatiblityGuid =3D { 0xc020489e, 0x6db2, 0x4ef2, {= 0x9a, > 0xa5, 0xca, 0x6, 0xfc, 0x11, 0xd3, 0x6a }} >=20 > ## Include/Guid/LegacyBios.h > gEfiLegacyBiosGuid =3D { 0x2E3044AC, 0x879F, 0x490F, {= 0x97, 0x60, > 0xBB, 0xDF, 0xAF, 0x69, 0x5F, 0x50 }} > diff --git a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > index 949a181a7b..2afda5df79 100644 > --- a/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > +++ b/IntelFrameworkModulePkg/IntelFrameworkModulePkg.dsc > @@ -117,11 +117,10 @@ > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0f > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x06 > gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xE0000000 >=20 > [Components] > - > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba > seUefiTianoCustomDecompressLib.inf >=20 > IntelFrameworkModulePkg/Library/LzmaCustomDecompressLib/LzmaCusto > mDecompressLib.inf > IntelFrameworkModulePkg/Library/PeiS3Lib/PeiS3Lib.inf > IntelFrameworkModulePkg/Library/PeiRecoveryLib/PeiRecoveryLib.inf >=20 > IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/Dx > eReportStatusCodeLib.inf >=20 > IntelFrameworkModulePkg/Library/SmmRuntimeDxeReportStatusCodeLibFr > amework/SmmRuntimeDxeReportStatusCodeLibFramework.inf > diff --git a/IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h > b/MdeModulePkg/Include/Guid/TianoDecompress.h > similarity index 100% > rename from IntelFrameworkModulePkg/Include/Guid/TianoDecompress.h > rename to MdeModulePkg/Include/Guid/TianoDecompress.h > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/ > BaseUefiTianoCustomDecompressLib.c > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLib.c > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba > seUefiTianoCustomDecompressLib.c > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLib.c > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/ > BaseUefiTianoCustomDecompressLib.inf > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLib.inf > similarity index 94% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba > seUefiTianoCustomDecompressLib.inf > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLib.inf > index ee64fa0d0e..41cc48cd24 100644 > --- > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/ > BaseUefiTianoCustomDecompressLib.inf > +++ > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLib.inf > @@ -33,11 +33,11 @@ > BaseUefiTianoCustomDecompressLibInternals.h > BaseUefiTianoCustomDecompressLib.c >=20 > [Packages] > MdePkg/MdePkg.dec > - IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec > + MdeModulePkg/MdeModulePkg.dec >=20 > [LibraryClasses] > BaseLib > DebugLib > BaseMemoryLib > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/ > BaseUefiTianoCustomDecompressLibInternals.h > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoCustomDecompressLibInternals.h > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba > seUefiTianoCustomDecompressLibInternals.h > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLibInternals.h > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/ > BaseUefiTianoDecompressLib.uni > b/MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTi > anoDecompressLib.uni > similarity index 100% > rename from > IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/Ba > seUefiTianoDecompressLib.uni > rename to > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oDecompressLib.uni > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 9bbd0572f5..546ec38b9d 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -377,10 +377,14 @@ > ## GUID indicates the LZMA custom compress/decompress algorithm. > # Include/Guid/LzmaDecompress.h > gLzmaCustomDecompressGuid =3D { 0xEE4E5898, 0x3914, 0x4259, { 0x9= D, > 0x6E, 0xDC, 0x7B, 0xD7, 0x94, 0x03, 0xCF }} > gLzmaF86CustomDecompressGuid =3D { 0xD42AE6BD, 0x1352, 0x4bfb, > { 0x90, 0x9A, 0xCA, 0x72, 0xA6, 0xEA, 0xE8, 0x89 }} >=20 > + ## GUID indicates the tiano custom compress/decompress algorithm. > + # Include/Guid/TianoDecompress.h > + gTianoCustomDecompressGuid =3D { 0xA31280AD, 0x481E, 0x41B6, { 0x9= 5, > 0xE8, 0x12, 0x7F, 0x4C, 0x98, 0x47, 0x79 }} > + > ## Include/Guid/TtyTerm.h > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0xa4= , 0x8f, 0xe2, > 0x5f, 0xdd, 0x51, 0xef, 0x94 }} >=20 > ## Include/Guid/HiiBootMaintenanceFormset.h > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { 0x= 89, 0x8a, > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc > index da2078b8d2..8905ca5814 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -317,10 +317,11 @@ > MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf >=20 > MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscove > rableDeviceRegistrationLib.inf > MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf >=20 > MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateP > rogressLibGraphics.inf >=20 > MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgr > essLibText.inf > + > MdeModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTian > oCustomDecompressLib.inf >=20 > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf >=20 > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp > p.inf > MdeModulePkg/Application/UiApp/UiApp.inf{ > > -- > 2.18.0.windows.1