From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Michael Turner" <Michael.Turner@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime safe
Date: Thu, 11 Apr 2019 08:39:15 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8BDF9A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190410070313.15092-1-zhichao.gao@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Wednesday, April 10, 2019 3:03 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen; Zhang, Chao B; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming;
> Sean Brogan; Michael Turner; Bret Barkelew
> Subject: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime
> safe
>
> Some pointer will be invalid after ExitBootServices, such as protocol pointer,
> gST, gBS and so on. Disable the functions which used that pointer.
>
> Remove SMM support of UefiDebugLibDebugPortProtocol,
> UefidebugLibConOut
> and UefiDebugLibStdErr.
> Before removing, should change the SMM instance in the dsc file which use
> them as SMM instance. And null version is safe.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> Aaron Antone (3):
> MdeModulePkg/UefiDebugLibDebugPortProtocol: Make it runtime safe
> MdeModulePkg/UefidebugLibConOut: Make it runtime safe
> MdeModule/UefiDebugLibStdErr: Make it runtime safe
Seems some typos here.
Should be MdePkg instead of MdeModulePkg (MdeModule).
Best Regards,
Hao Wu
>
> Zhichao Gao (2):
> MdeModulePkg: Change the SMM debug lib instance
> SignedCapsulePkg: Change the SMM debug lib instance
>
> MdeModulePkg/MdeModulePkg.dsc | 2 +-
> MdePkg/Library/UefiDebugLibConOut/DebugLib.c | 116 +++++++-------
> .../UefiDebugLibConOut/DebugLibConstructor.c | 72 +++++++++
> .../UefiDebugLibConOut/UefiDebugLibConOut.inf | 12 +-
> .../UefiDebugLibDebugPortProtocol/DebugLib.c | 146 +++++++++---------
> .../DebugLibConstructor.c | 72 +++++++++
> .../UefiDebugLibDebugPortProtocol.inf | 12 +-
> MdePkg/Library/UefiDebugLibStdErr/DebugLib.c | 113 +++++++-------
> .../UefiDebugLibStdErr/DebugLibConstructor.c | 72 +++++++++
> .../UefiDebugLibStdErr/UefiDebugLibStdErr.inf | 12 +-
> SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +-
> 11 files changed, 443 insertions(+), 190 deletions(-)
> create mode 100644
> MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c
> create mode 100644
> MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c
> create mode 100644
> MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c
>
> --
> 2.21.0.windows.1
>
>
>
prev parent reply other threads:[~2019-04-11 8:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 7:03 [PATCH 0/5] Make some DebugLib instance runtime safe Gao, Zhichao
2019-04-10 7:03 ` [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance Gao, Zhichao
2019-04-11 8:44 ` [edk2-devel] " Wu, Hao A
2019-04-11 9:28 ` Gao, Zhichao
2019-04-10 7:03 ` [PATCH 2/5] SignedCapsulePkg: " Gao, Zhichao
2019-04-10 7:03 ` [PATCH 3/5] MdeModulePkg/UefiDebugLibDebugPortProtocol: Make it runtime safe Gao, Zhichao
2019-04-10 7:03 ` [PATCH 4/5] MdeModulePkg/UefidebugLibConOut: " Gao, Zhichao
2019-04-10 7:03 ` [PATCH 5/5] MdeModule/UefiDebugLibStdErr: " Gao, Zhichao
2019-04-11 8:39 ` Wu, Hao A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8BDF9A@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox