From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: hao.a.wu@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Thu, 11 Apr 2019 01:39:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 01:39:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="134820877" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 11 Apr 2019 01:39:18 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 01:39:17 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.206]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 16:39:15 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Yao, Jiewen" , "Zhang, Chao B" , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , "Michael Turner" , Bret Barkelew Subject: Re: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime safe Thread-Topic: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime safe Thread-Index: AQHU72uVxanhi0d0AkS9TyrszISxq6Y2pPIQ Date: Thu, 11 Apr 2019 08:39:15 +0000 Message-ID: References: <20190410070313.15092-1-zhichao.gao@intel.com> In-Reply-To: <20190410070313.15092-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, April 10, 2019 3:03 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen; Zhang, Chao B; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, = Liming; > Sean Brogan; Michael Turner; Bret Barkelew > Subject: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime > safe >=20 > Some pointer will be invalid after ExitBootServices, such as protocol po= inter, > gST, gBS and so on. Disable the functions which used that pointer. >=20 > Remove SMM support of UefiDebugLibDebugPortProtocol, > UefidebugLibConOut > and UefiDebugLibStdErr. > Before removing, should change the SMM instance in the dsc file which us= e > them as SMM instance. And null version is safe. >=20 > Cc: Jiewen Yao > Cc: Chao Zhang > Cc: Jian J Wang > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew >=20 > Aaron Antone (3): > MdeModulePkg/UefiDebugLibDebugPortProtocol: Make it runtime safe > MdeModulePkg/UefidebugLibConOut: Make it runtime safe > MdeModule/UefiDebugLibStdErr: Make it runtime safe Seems some typos here. Should be MdePkg instead of MdeModulePkg (MdeModule). Best Regards, Hao Wu >=20 > Zhichao Gao (2): > MdeModulePkg: Change the SMM debug lib instance > SignedCapsulePkg: Change the SMM debug lib instance >=20 > MdeModulePkg/MdeModulePkg.dsc | 2 +- > MdePkg/Library/UefiDebugLibConOut/DebugLib.c | 116 +++++++------- > .../UefiDebugLibConOut/DebugLibConstructor.c | 72 +++++++++ > .../UefiDebugLibConOut/UefiDebugLibConOut.inf | 12 +- > .../UefiDebugLibDebugPortProtocol/DebugLib.c | 146 +++++++++--------- > .../DebugLibConstructor.c | 72 +++++++++ > .../UefiDebugLibDebugPortProtocol.inf | 12 +- > MdePkg/Library/UefiDebugLibStdErr/DebugLib.c | 113 +++++++------- > .../UefiDebugLibStdErr/DebugLibConstructor.c | 72 +++++++++ > .../UefiDebugLibStdErr/UefiDebugLibStdErr.inf | 12 +- > SignedCapsulePkg/SignedCapsulePkg.dsc | 4 +- > 11 files changed, 443 insertions(+), 190 deletions(-) > create mode 100644 > MdePkg/Library/UefiDebugLibConOut/DebugLibConstructor.c > create mode 100644 > MdePkg/Library/UefiDebugLibDebugPortProtocol/DebugLibConstructor.c > create mode 100644 > MdePkg/Library/UefiDebugLibStdErr/DebugLibConstructor.c >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20