From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: hao.a.wu@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 11 Apr 2019 01:44:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 01:44:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="222520852" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 11 Apr 2019 01:44:51 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 01:44:51 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 01:44:51 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 16:44:49 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Subject: Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance Thread-Topic: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance Thread-Index: AQHU72uYBt7IlKdIdEugMVfRVxNuiKY2pnUA Date: Thu, 11 Apr 2019 08:44:49 +0000 Message-ID: References: <20190410070313.15092-1-zhichao.gao@intel.com> <20190410070313.15092-2-zhichao.gao@intel.com> In-Reply-To: <20190410070313.15092-2-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, April 10, 2019 3:03 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew > Subject: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug > lib instance >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1416 >=20 > The UefiDebugLibConOut will not support DXE_SMM_DRIVER, > change UefiDebugLibConOut to PeiDxeDebugLibReportStatusCode. Is this a typo? Should be 'BaseDebugLibNull' according to your change. With this addressed, Reviewed-by: Hao Wu Best Regards, Hao Wu >=20 > Cc: Jian J Wang > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Signed-off-by: Zhichao Gao > --- > MdeModulePkg/MdeModulePkg.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc > index 7ef39af847..0da28e74c2 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -144,7 +144,7 @@ >=20 > [LibraryClasses.common.DXE_SMM_DRIVER] > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > - DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > + DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf >=20 > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe > moryAllocationLib.inf >=20 > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTabl > eLib.inf >=20 > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT > ableLib.inf > -- > 2.21.0.windows.1 >=20 >=20 >=20