From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Tue, 16 Apr 2019 19:45:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 19:45:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="224188184" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga001.jf.intel.com with ESMTP; 16 Apr 2019 19:45:30 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 19:45:30 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 19:45:30 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.39]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 10:45:28 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: "Kinney, Michael D" , "Gao, Liming" , "Zhang, Chao B" , "Yao, Jiewen" , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , Leif Lindholm , Ard Biesheuvel , "Justen, Jordan L" , Laszlo Ersek , "Steele, Kelly" , "Sun, Zailiang" , "Qian, Yi" , "Sean Brogan" , Michael Turner , Bret Barkelew Subject: Re: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Thread-Topic: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Thread-Index: AQHU8zhAzj8VtXQkD02OVYW7mMQGjKY/qB5Q Date: Wed, 17 Apr 2019 02:45:27 +0000 Message-ID: References: <20190415030611.12464-1-zhichao.gao@intel.com> In-Reply-To: <20190415030611.12464-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ga= o, > Zhichao > Sent: Monday, April 15, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Gao, Liming; Zhang, Chao B; Yao, Jiewen; Wang, Ji= an J; > Wu, Hao A; Ni, Ray; Zeng, Star; Leif Lindholm; Ard Biesheuvel; Justen, J= ordan L; > Laszlo Ersek; Steele, Kelly; Sun, Zailiang; Qian, Yi; Sean Brogan; Micha= el Turner; > Bret Barkelew > Subject: [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and > ResetSystemWithSubtype >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 > Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus > is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific > or not. > Add a new API ResetSystem to ResetSystemLib instances. The new driver ma= y > consume this new API and then it may cause a link error. For these libra= ry > instances, the new API only has a basic function. If the consumers want > the full function of this API, they should use the instance in the MdeMo= dulePkg > and make sure the depex driver is dispatched. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1458 > Add a new API ResetSystemWithSubtype to ResetUtilityLib >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao Zhang > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew >=20 > Bret Barkelew (2): > MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype > MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype >=20 > Zhichao Gao (23): > MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM > MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM > MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 > MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2 > SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset > MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem > MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem > MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem > MdeModulePkg/RuntimeResetSystemLib.c: Change comments > MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem > MdeModulePkg/ResetSystemRuntimeDxe: Change comments > MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 > MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 > MdeModulePkg/NvmExpressHci.c: Change comments For the above 9 comments update patches (patch 6~14), Reviewed-by: Hao Wu Best Regards, Hao Wu > BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem > CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem > Nt32Pkg/ResetSystemLib: Add new API ResetSystem > OvmfPkg/ResetSystemLib: Add new API ResetSystem > PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem > QuarkSocPkg/ResetSystemLib: Add new API ResetSystem > Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem > ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem > ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem >=20 > .../ArmSmcPsciResetSystemLib.c | 43 +++++++++++++++++++ > .../ArmVirtPsciResetSystemLib.c | 43 +++++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +-- > MdeModulePkg/Core/Pei/PeiMain.h | 4 +- > MdeModulePkg/Core/Pei/Reset/Reset.c | 4 +- > MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +- > .../Include/Library/ResetUtilityLib.h | 22 ++++++++++ > .../BaseResetSystemLibNull.c | 4 +- > .../DxeResetSystemLib/DxeResetSystemLib.c | 4 +- > .../PeiResetSystemLib/PeiResetSystemLib.c | 4 +- > .../Library/ResetUtilityLib/ResetUtility.c | 36 +++++++++++++--- > .../RuntimeResetSystemLib.c | 4 +- > .../Universal/ResetSystemPei/ResetSystem.c | 5 +-- > .../Universal/ResetSystemPei/ResetSystem.h | 5 +-- > .../ResetSystemRuntimeDxe/ResetSystem.c | 5 +-- > .../ResetSystemRuntimeDxe/ResetSystem.h | 5 +-- > MdePkg/Include/Library/PeiServicesLib.h | 4 +- > MdePkg/Include/Pi/PiPeiCis.h | 4 +- > MdePkg/Include/Uefi/UefiSpec.h | 5 +-- > .../Library/PeiServicesLib/PeiServicesLib.c | 4 +- > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 5 +-- > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > 28 files changed, 456 insertions(+), 64 deletions(-) >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20