From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Tue, 16 Apr 2019 20:15:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 20:15:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="338311540" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 16 Apr 2019 20:15:19 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 20:15:19 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 20:15:18 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 11:15:16 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" CC: Leif Lindholm , Ard Biesheuvel , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API ResetSystem Thread-Topic: [edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API ResetSystem Thread-Index: AQHU8zhczD4fPdmsqUSkal8rg84UEaY/sNWQ Date: Wed, 17 Apr 2019 03:15:16 +0000 Message-ID: References: <20190415030611.12464-1-zhichao.gao@intel.com> <20190415030611.12464-18-zhichao.gao@intel.com> In-Reply-To: <20190415030611.12464-18-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ga= o, > Zhichao > Sent: Monday, April 15, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Leif Lindholm; Ard Biesheuvel; Gao, Liming > Subject: [edk2-devel] [PATCH 17/25] Nt32Pkg/ResetSystemLib: Add new API > ResetSystem >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 >=20 > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers > use this new API and link to this library instance. > Notes: > This library API only provide a basic function of reset. Full > function should use the instance in the MdeModulePkg and make > sure the depex driver is dispatched. >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../Library/ResetSystemLib/ResetSystemLib.c | 43 +++++++++++++++++++ > 1 file changed, 43 insertions(+) >=20 > diff --git a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c > b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c > index ed4129d46b..02fa30169d 100644 > --- a/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c > +++ b/Nt32Pkg/Library/ResetSystemLib/ResetSystemLib.c > @@ -90,3 +90,46 @@ ResetPlatformSpecific ( > { > ResetCold (); > } > + > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWa= rm, > or EfiResetShutdown > + the data buffer starts with a Null-terminat= ed string, > optionally > + followed by additional binary data. The str= ing is a description > + that the caller may use to further indicate= the reason for the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; Please remove the extra space between 'return' & ';'. With this addressed, Reviewed-by: Hao Wu Best Regards, Hao Wu > + } > +} > -- > 2.21.0.windows.1 >=20 >=20 >=20