From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 16 Apr 2019 23:36:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 23:36:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,360,1549958400"; d="scan'208";a="143411087" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 16 Apr 2019 23:36:39 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 23:36:39 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 23:36:38 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.149]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 14:36:37 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [PATCH V2 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Thread-Topic: [PATCH V2 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Thread-Index: AQHU9ObYJond+Y4DVkyKMMrLcwwimaY/5d/w Date: Wed, 17 Apr 2019 06:36:37 +0000 Message-ID: References: <20190417062722.8568-1-zhichao.gao@intel.com> <20190417062722.8568-25-zhichao.gao@intel.com> In-Reply-To: <20190417062722.8568-25-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Gao, Zhichao > Sent: Wednesday, April 17, 2019 2:27 PM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Lim= ing; > Sean Brogan; Michael Turner > Subject: [PATCH V2 24/25] MdeModulePkg/ResetUtilityLib: Add a new API > ResetSystemWithSubtype >=20 > From: Bret Barkelew >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1458 >=20 > Add a new API ResetSystemWithSubtype's prototype declaration in > header file. Also add the required data type header file. >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Signed-off-by: Zhichao Gao > --- > .../Include/Library/ResetUtilityLib.h | 34 ++++++++++++++++--- > 1 file changed, 30 insertions(+), 4 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Library/ResetUtilityLib.h > b/MdeModulePkg/Include/Library/ResetUtilityLib.h > index ca310cdb01..656703e782 100644 > --- a/MdeModulePkg/Include/Library/ResetUtilityLib.h > +++ b/MdeModulePkg/Include/Library/ResetUtilityLib.h > @@ -1,7 +1,7 @@ > /** @file > This header describes various helper functions for resetting the syste= m. >=20 > - Copyright (c) 2017 Intel Corporation. All rights reserved.
> + Copyright (c) 2017 - 2019 Intel Corporation. All rights reserved.
> Copyright (c) 2016 Microsoft Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -10,10 +10,36 @@ > #ifndef _RESET_UTILITY_LIB_H_ > #define _RESET_UTILITY_LIB_H_ >=20 > +#include > + > +/** > + This is a shorthand helper function to reset with reset type and a sub= type > + so that the caller doesn't have to bother with a function that has hal= f > + a dozen parameters. > + > + This will generate a reset with status EFI_SUCCESS, a NULL string, and > + no custom data. The subtype will be formatted in such a way that it ca= n be > + picked up by notification registrations and custom handlers. > + > + NOTE: This call will fail if the architectural ResetSystem underpinnin= gs > + are not initialized. For DXE, you can add gEfiResetArchProtocolG= uid > + to your DEPEX. > + > + @param[in] ResetType The default EFI_RESET_TYPE of the reset. > + @param[in] ResetSubtype GUID pointer for the reset subtype to be use= d. > + > +**/ > +VOID > +EFIAPI > +ResetSystemWithSubtype ( > + IN EFI_RESET_TYPE ResetType, > + IN CONST GUID *ResetSubtype > + ); > + > /** > - This is a shorthand helper function to reset with a subtype so that > - the caller doesn't have to bother with a function that has half a doze= n > - parameters. > + This is a shorthand helper function to reset with the reset type > + 'EfiResetPlatformSpecific' and a subtype so that the caller doesn't > + have to bother with a function that has half a dozen parameters. Thanks for addressing the comments. Reviewed-by: Hao Wu Best Regards, Hao Wu >=20 > This will generate a reset with status EFI_SUCCESS, a NULL string, and > no custom data. The subtype will be formatted in such a way that it ca= n be > -- > 2.21.0.windows.1