Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Friday, April 26, 2019 9:04 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Bi,
> Dandan
> Subject: [edk2-devel] [PATCH V3 5/8]
> MdeModulePkg/FirmwarePerformanceDxe: make global variable static

After checking Laszlo's comment on V2:

'''
(1) in all of the subject lines, please replace

  Decrease the name collisions

with

  make mExitBootServicesEvent STATIC
'''

I prefer the one suggested by Laszlo, the proposed subject here gives me
the feeling of changing all the global variables in the module.

However, I am okay if you stick with the proposed subject. Anyway,
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
> 
> Add a 'static' storage-class specifier to the global variables
> that only used in a single file to minimize the name collisions.
> This is only for the variable named 'mExitBootServicesEvent'.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c  | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa
> rePerformanceDxe.c
> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa
> rePerformanceDxe.c
> index 9713048f1f..61a7704b37 100644
> ---
> a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa
> rePerformanceDxe.c
> +++
> b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa
> rePerformanceDxe.c
> @@ -5,7 +5,7 @@
>    for Firmware Basic Boot Performance Record and other boot performance
> records,
>    and install FPDT to ACPI table.
> 
> -  Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -40,7 +40,7 @@ EFI_RSC_HANDLER_PROTOCOL    *mRscHandlerProtocol
> = NULL;
>  BOOLEAN                     mLockBoxReady = FALSE;
>  EFI_EVENT                   mReadyToBootEvent;
>  EFI_EVENT                   mLegacyBootEvent;
> -EFI_EVENT                   mExitBootServicesEvent;
> +static EFI_EVENT            mExitBootServicesEvent;
>  UINTN                       mFirmwarePerformanceTableTemplateKey  = 0;
>  BOOLEAN                     mDxeCoreReportStatusCodeEnable = FALSE;
> 
> --
> 2.21.0.windows.1
> 
> 
>