From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Thu, 25 Apr 2019 22:58:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 22:58:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,396,1549958400"; d="scan'208";a="153900205" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 25 Apr 2019 22:58:27 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:58:27 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 25 Apr 2019 22:58:27 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Fri, 26 Apr 2019 13:58:25 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Gao, Zhichao" , Laszlo Ersek CC: Laszlo Ersek , "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , "Bi, Dandan" Subject: Re: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static Thread-Topic: [edk2-devel] [PATCH V3 5/8] MdeModulePkg/FirmwarePerformanceDxe: make global variable static Thread-Index: AQHU+8wQH+BsKOVm6kabERfKvDNOZKZN8QpQ Date: Fri, 26 Apr 2019 05:58:25 +0000 Message-ID: References: <20190426010404.20624-1-zhichao.gao@intel.com> <20190426010404.20624-6-zhichao.gao@intel.com> In-Reply-To: <20190426010404.20624-6-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ga= o, > Zhichao > Sent: Friday, April 26, 2019 9:04 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Lim= ing; Bi, > Dandan > Subject: [edk2-devel] [PATCH V3 5/8] > MdeModulePkg/FirmwarePerformanceDxe: make global variable static After checking Laszlo's comment on V2: ''' (1) in all of the subject lines, please replace Decrease the name collisions with make mExitBootServicesEvent STATIC ''' I prefer the one suggested by Laszlo, the proposed subject here gives me the feeling of changing all the global variables in the module. However, I am okay if you stick with the proposed subject. Anyway, Reviewed-by: Hao Wu Best Regards, Hao Wu >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740 >=20 > Add a 'static' storage-class specifier to the global variables > that only used in a single file to minimize the name collisions. > This is only for the variable named 'mExitBootServicesEvent'. >=20 > Cc: Laszlo Ersek > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Dandan Bi > Signed-off-by: Zhichao Gao > --- > .../FirmwarePerformanceDataTableDxe/FirmwarePerformanceDxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa > rePerformanceDxe.c > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa > rePerformanceDxe.c > index 9713048f1f..61a7704b37 100644 > --- > a/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa > rePerformanceDxe.c > +++ > b/MdeModulePkg/Universal/Acpi/FirmwarePerformanceDataTableDxe/Firmwa > rePerformanceDxe.c > @@ -5,7 +5,7 @@ > for Firmware Basic Boot Performance Record and other boot performance > records, > and install FPDT to ACPI table. >=20 > - Copyright (c) 2011 - 2018, Intel Corporation. All rights reserved. > + Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved. > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > **/ > @@ -40,7 +40,7 @@ EFI_RSC_HANDLER_PROTOCOL *mRscHandlerProtocol > =3D NULL; > BOOLEAN mLockBoxReady =3D FALSE; > EFI_EVENT mReadyToBootEvent; > EFI_EVENT mLegacyBootEvent; > -EFI_EVENT mExitBootServicesEvent; > +static EFI_EVENT mExitBootServicesEvent; > UINTN mFirmwarePerformanceTableTemplateKey =3D 0= ; > BOOLEAN mDxeCoreReportStatusCodeEnable =3D FALSE; >=20 > -- > 2.21.0.windows.1 >=20 >=20 >=20