From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by groups.io with SMTP; Thu, 25 Apr 2019 23:00:18 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 23:00:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,396,1549958400"; 
   d="scan'208";a="145868693"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
  by orsmga003.jf.intel.com with ESMTP; 25 Apr 2019 23:00:17 -0700
Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by
 fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 25 Apr 2019 23:00:17 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 25 Apr 2019 23:00:17 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.92]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.164]) with mapi id 14.03.0415.000;
 Fri, 26 Apr 2019 14:00:15 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>, Laszlo Ersek <lersek@redhat.com>
CC: Laszlo Ersek <lersek@redhat.com>, "Wang, Jian J" <jian.j.wang@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>, "Gao,
 Liming" <liming.gao@intel.com>, "Bi, Dandan" <dandan.bi@intel.com>
Subject: Re: [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make global variable static
Thread-Topic: [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make
 global variable static
Thread-Index: AQHU+8wbcE+AXLKhfEuGdULeFos/4qZN8rfg
Date: Fri, 26 Apr 2019 06:00:13 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8C422B@SHSMSX104.ccr.corp.intel.com>
References: <20190426010404.20624-1-zhichao.gao@intel.com>
 <20190426010404.20624-9-zhichao.gao@intel.com>
In-Reply-To: <20190426010404.20624-9-zhichao.gao@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Friday, April 26, 2019 9:04 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Limi=
ng; Bi,
> Dandan
> Subject: [PATCH V3 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: make
> global variable static

Similar comment as patch 5/8. But I will leave the decision to you.
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1740
>=20
> Add a 'static' storage-class specifier to the global variables
> that only used in a single file to minimize the name collisions.
> This is only for the variable named 'mExitBootServicesEvent'.
>=20
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Dandan Bi <dandan.bi@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../RuntimeDxe/StatusCodeHandlerRuntimeDxe.c                  | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl
> erRuntimeDxe.c
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl
> erRuntimeDxe.c
> index 0d327d40e3..79cc48fa55 100644
> ---
> a/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl
> erRuntimeDxe.c
> +++
> b/MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandl
> erRuntimeDxe.c
> @@ -2,7 +2,7 @@
>    Status Code Handler Driver which produces general handlers and hook th=
em
>    onto the DXE status code router.
>=20
> -  Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +  Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
>  **/
> @@ -10,7 +10,7 @@
>  #include "StatusCodeHandlerRuntimeDxe.h"
>=20
>  EFI_EVENT                 mVirtualAddressChangeEvent =3D NULL;
> -EFI_EVENT                 mExitBootServicesEvent     =3D NULL;
> +static EFI_EVENT          mExitBootServicesEvent     =3D NULL;
>  EFI_RSC_HANDLER_PROTOCOL  *mRscHandlerProtocol       =3D NULL;
>=20
>  /**
> --
> 2.21.0.windows.1