public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Gao, Liming" <liming.gao@intel.com>,
	"Wang, Jian J" <jian.j.wang@intel.com>
Subject: Re: [patch 11/11] MdeModulePkg: Remove PcdFrameworkCompatibilitySupport
Date: Mon, 6 May 2019 01:25:09 +0000	[thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8D0685@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190429021607.11304-12-dandan.bi@intel.com>

> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, April 29, 2019 10:16 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming; Wu, Hao A; Wang, Jian J
> Subject: [patch 11/11] MdeModulePkg: Remove
> PcdFrameworkCompatibilitySupport
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464
> 
> Currently Framework compatibility support is not needed and
> PcdFrameworkCompatibilitySupport will be removed from edk2.
> So remove the usage of this PCD firstly.
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec | 8 --------
>  MdeModulePkg/MdeModulePkg.uni | 6 ------
>  2 files changed, 14 deletions(-)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec
> index be84916cc0..095863dc07 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -735,18 +735,10 @@
>    #   TRUE  - USB KeyBoard Driver will disable the default keyboard layout.<BR>
>    #   FALSE - USB KeyBoard Driver will not disable the default keyboard
> layout.<BR>
>    # @Prompt Disable default keyboard layout in USB KeyBoard Driver.
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdDisableDefaultKeyboardLayoutInUsbKb
> Driver|FALSE|BOOLEAN|0x00010200
> 
> -  ## Indicates if backward compatibility to Framework HII and Framework
> FvHob is supported.<BR><BR>
> -  #   TRUE  - Setup Browser supports GUID opcodes generated from Framework
> HII VFR file by VFR compiler.
> -  #           the PeiCore will handle the framework FvHob and install FvInfo PPI
> for it.<BR>
> -  #   FALSE - Setup Browser doesn't support GUID opcodes generated from
> Framework HII VFR file by VFR compiler.
> -  #           the PeiCore will not handle the framework FvHob and install FvInfo
> PPI for it.<BR>
> -  # @Prompt Enable framework backward compatibility support.
> -
> gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport|FALSE
> |BOOLEAN|0x00012009
> -
>    ## Indicates if HelloWorld Application will print the verbose information.
>    #  This PCD is a sample to explain FeatureFlag PCD usage.<BR><BR>
>    #   TRUE  - HelloWorld Application will print the verbose information.<BR>
>    #   FALSE - HelloWorld Application will not print the verbose information.<BR>
>    # @Prompt Enable HelloWorld print.
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index cf2aefa7ad..b71e68617c 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -709,16 +709,10 @@
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdDisableDefaultKeyboardLayoutIn
> UsbKbDriver_HELP  #language en-US "Disable default USB keyboard layout?
> The default keyboard layout serves as the backup when no keyboard layout can
> be retrieved from HII database.<BR><BR>\n"
>                                                                                                                "TRUE  -
> disable<BR>\n"
>                                                                                                                "FALSE -
> enable<BR>"
> 
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFrameworkCompatibilitySupport_
> PROMPT  #language en-US "Enable framework backward compatibility
> support"
> -
> -#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFrameworkCompatibilitySupport_
> HELP  #language en-US "Indicates if backward compatibility to Framework HII
> and Framework FvHob is supported.<BR><BR>\n"
> -                                                                                                  "TRUE  - Setup
> Browser supports GUID opcodes generated from Framework HII VFR file by VFR
> compiler. the PeiCore will handle the framework FvHob and install FvInfo PPI
> for it.<BR>\n"
> -                                                                                                  "FALSE - Setup
> Browser doesn't support GUID opcodes generated from Framework HII VFR file
> by VFR compiler. the PeiCore will not handle the framework FvHob and install
> FvInfo PPI for it.<BR>"
> -

Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu

>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintEnable_PROMPT
> #language en-US "Enable HelloWorld print"
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintEnable_HELP
> #language en-US "Indicates if HelloWorld Application will print the verbose
> information. This PCD is a sample to explain FeatureFlag PCD
> usage.<BR><BR>\n"
>                                                                                            "TRUE  - HelloWorld
> Application will print the verbose information.<BR>\n"
>                                                                                            "FALSE - HelloWorld
> Application will not print the verbose information.<BR>"
> --
> 2.18.0.windows.1


  reply	other threads:[~2019-05-06  1:25 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  2:15 [patch 00/11] Remove PcdFrameworkCompatibilitySupport Dandan Bi
2019-04-29  2:15 ` [patch 01/11] BaseTools/VfrCompile: Remove framework VFR support Dandan Bi
2019-05-07  5:52   ` [edk2-devel] " Bob Feng
2019-05-07  6:00   ` Liming Gao
2019-04-29  2:15 ` [patch 02/11] FatPkg/FatPei: Remove PcdFrameworkCompatibilitySupport usage Dandan Bi
2019-05-05  3:25   ` [edk2-devel] " Ni, Ray
2019-04-29  2:15 ` [patch 03/11] IntelFrameworkModulePkg: " Dandan Bi
2019-05-07  5:59   ` Liming Gao
2019-04-29  2:16 ` [patch 04/11] MdeModulePkg/Core: " Dandan Bi
2019-05-06  1:22   ` [edk2-devel] " Wu, Hao A
2019-05-06  2:48     ` Dandan Bi
2019-05-06  2:54       ` Wu, Hao A
2019-05-07  7:08         ` Dandan Bi
2019-05-08  8:23           ` Liming Gao
2019-04-29  2:16 ` [patch 05/11] MdeModulePkg/CdExpress: " Dandan Bi
2019-05-06  1:05   ` Wu, Hao A
2019-04-29  2:16 ` [patch 06/11] MdeModulePkg/Setup: " Dandan Bi
2019-05-07  6:13   ` Dong, Eric
2019-04-29  2:16 ` [patch 07/11] QuarkPlatformPkg: " Dandan Bi
2019-05-07  5:58   ` [edk2-devel] " Liming Gao
2019-04-29  2:16 ` [patch 08/11] SignedCapsulePkg: " Dandan Bi
2019-04-29  2:16 ` [patch 09/11] UefiCpuPkg: " Dandan Bi
2019-04-29 15:15   ` Laszlo Ersek
2019-04-29  2:16 ` [patch 10/11] Vlv2TbltDevicePkg: " Dandan Bi
2019-05-07  8:35   ` Sun, Zailiang
2019-04-29  2:16 ` [patch 11/11] MdeModulePkg: Remove PcdFrameworkCompatibilitySupport Dandan Bi
2019-05-06  1:25   ` Wu, Hao A [this message]
     [not found] ` <1599D055711F0B7C.4588@groups.io>
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB40BD01BF@SHSMSX104.ccr.corp.intel.com>
2019-05-07  6:02     ` [edk2-devel] [patch 08/11] SignedCapsulePkg: Remove PcdFrameworkCompatibilitySupport usage Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8D0685@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox