From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: hao.a.wu@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Sun, 05 May 2019 18:25:14 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 May 2019 18:25:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,435,1549958400"; d="scan'208";a="168129793" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 05 May 2019 18:25:14 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 5 May 2019 18:25:13 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 5 May 2019 18:25:12 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.70]) with mapi id 14.03.0415.000; Mon, 6 May 2019 09:25:10 +0800 From: "Wu, Hao A" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Wang, Jian J" Subject: Re: [patch 11/11] MdeModulePkg: Remove PcdFrameworkCompatibilitySupport Thread-Topic: [patch 11/11] MdeModulePkg: Remove PcdFrameworkCompatibilitySupport Thread-Index: AQHU/jGlmBhb4DruF0WNgbikPTvAeqZdWJBg Date: Mon, 6 May 2019 01:25:09 +0000 Message-ID: References: <20190429021607.11304-1-dandan.bi@intel.com> <20190429021607.11304-12-dandan.bi@intel.com> In-Reply-To: <20190429021607.11304-12-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Bi, Dandan > Sent: Monday, April 29, 2019 10:16 AM > To: devel@edk2.groups.io > Cc: Gao, Liming; Wu, Hao A; Wang, Jian J > Subject: [patch 11/11] MdeModulePkg: Remove > PcdFrameworkCompatibilitySupport >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1464 >=20 > Currently Framework compatibility support is not needed and > PcdFrameworkCompatibilitySupport will be removed from edk2. > So remove the usage of this PCD firstly. >=20 > Cc: Liming Gao > Cc: Hao Wu > Cc: Jian J Wang > Signed-off-by: Dandan Bi > --- > MdeModulePkg/MdeModulePkg.dec | 8 -------- > MdeModulePkg/MdeModulePkg.uni | 6 ------ > 2 files changed, 14 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index be84916cc0..095863dc07 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -735,18 +735,10 @@ > # TRUE - USB KeyBoard Driver will disable the default keyboard layo= ut.
> # FALSE - USB KeyBoard Driver will not disable the default keyboard > layout.
> # @Prompt Disable default keyboard layout in USB KeyBoard Driver. >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdDisableDefaultKeyboardLayoutInUsbKb > Driver|FALSE|BOOLEAN|0x00010200 >=20 > - ## Indicates if backward compatibility to Framework HII and Framework > FvHob is supported.

> - # TRUE - Setup Browser supports GUID opcodes generated from Framewo= rk > HII VFR file by VFR compiler. > - # the PeiCore will handle the framework FvHob and install Fv= Info PPI > for it.
> - # FALSE - Setup Browser doesn't support GUID opcodes generated from > Framework HII VFR file by VFR compiler. > - # the PeiCore will not handle the framework FvHob and instal= l FvInfo > PPI for it.
> - # @Prompt Enable framework backward compatibility support. > - > gEfiMdeModulePkgTokenSpaceGuid.PcdFrameworkCompatibilitySupport|FALSE > |BOOLEAN|0x00012009 > - > ## Indicates if HelloWorld Application will print the verbose informat= ion. > # This PCD is a sample to explain FeatureFlag PCD usage.

> # TRUE - HelloWorld Application will print the verbose information.=
> # FALSE - HelloWorld Application will not print the verbose informat= ion.
> # @Prompt Enable HelloWorld print. > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index cf2aefa7ad..b71e68617c 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -709,16 +709,10 @@ >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdDisableDefaultKeyboardLayoutIn > UsbKbDriver_HELP #language en-US "Disable default USB keyboard layout? > The default keyboard layout serves as the backup when no keyboard layout = can > be retrieved from HII database.

\n" > = "TRUE - > disable
\n" > = "FALSE - > enable
" >=20 > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFrameworkCompatibilitySupport_ > PROMPT #language en-US "Enable framework backward compatibility > support" > - > -#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdFrameworkCompatibilitySupport_ > HELP #language en-US "Indicates if backward compatibility to Framework H= II > and Framework FvHob is supported.

\n" > - = "TRUE - Setup > Browser supports GUID opcodes generated from Framework HII VFR file by VF= R > compiler. the PeiCore will handle the framework FvHob and install FvInfo = PPI > for it.
\n" > - = "FALSE - Setup > Browser doesn't support GUID opcodes generated from Framework HII VFR fil= e > by VFR compiler. the PeiCore will not handle the framework FvHob and inst= all > FvInfo PPI for it.
" > - Reviewed-by: Hao Wu Best Regards, Hao Wu > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintEnable_PROMPT > #language en-US "Enable HelloWorld print" >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdHelloWorldPrintEnable_HELP > #language en-US "Indicates if HelloWorld Application will print the verbo= se > information. This PCD is a sample to explain FeatureFlag PCD > usage.

\n" > = "TRUE - HelloWorld > Application will print the verbose information.
\n" > = "FALSE - HelloWorld > Application will not print the verbose information.
" > -- > 2.18.0.windows.1