From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 08 May 2019 23:36:54 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 23:36:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga008.fm.intel.com with ESMTP; 08 May 2019 23:36:53 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 23:36:53 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 23:36:53 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000; Thu, 9 May 2019 14:36:51 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Loh, Tien Hock" , "thloh85@gmail.com" CC: tien.hock.loh , "Wang, Jian J" , "Zhu, Yonghong" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI Thread-Topic: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI Thread-Index: AQHVBMVwf/5sTk5Yz0KMpJ8gXgUqB6ZiJW3Q Date: Thu, 9 May 2019 06:36:50 +0000 Message-ID: References: <1557227281-170969-1-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1557227281-170969-1-git-send-email-tien.hock.loh@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Lo= h, > Tien Hock > Sent: Tuesday, May 07, 2019 7:08 PM > To: devel@edk2.groups.io; thloh85@gmail.com > Cc: tien.hock.loh; Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, Yonghon= g > Subject: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: > Update Mmio32 to UNI >=20 Hello Tien Hock, > From: "tien.hock.loh" Is the above information automatically generated when formatting the patch= ? It seems a bit weird to me. Also, could you help to add the Bugzilla link reference information in the commit message? Like: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1771 >=20 > Some busses doesn't allow 8 bit MMIO read/write, this adds support for > 32 bits read/write. This patch adds the UNI information on the new > Pcd introduced - PcdSerialRegisterAccessWidth >=20 > Signed-off-by: "Tien Hock, Loh" > Cc: Jian J Wang > Cc: Hao Wu > Cc: "Zhu, YongHong" >=20 > Signed-off-by: tien.hock.loh There are 2 'Signed-off' tags here, could you help to cleanup to drop the unneeded one? > --- > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index cf2aefa7ad..654dfeadb0 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -160,6 +160,12 @@ > = "TRUE - 16550 serial port > registers are in MMIO space.
\n" > = "FALSE - 16550 serial port > registers are in I/O space.
" >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_PRO > MPT #language en-US "Serial port registers access width" > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HELP > #language en-US "Sets the 16550 serial port registers access width in MM= IO > space. Default is 8 bits access.

\n" IMO, you can directly use the text: 'Indicates the access width for 16550 serial port registers.' in MdeModulePkg.dec here for STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HELP. > + = "8 - 16550 serial port > MMIO register access are in 8 bits mode.
\n" > + = "32 - 16550 serial port > MMIO registers acess are in 32 bits mode..
" acess -> access Please also help to remove the extra '.' for the above line. Best Regards, Hao Wu > + > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_P > ROMPT #language en-US "Enable serial port hardware flow control" >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_ > HELP #language en-US "Indicates if the 16550 serial port hardware flow > control will be enabled. Default is FALSE.

\n" > -- > 2.13.0 >=20 >=20 >=20