[PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI

[PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI

[Loh, Tien Hock]

From: "Tien Hock, Loh" <tien.hock.loh@intel.com>

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1771

Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write. This patch adds the UNI information on the new Pcd
introduced - PcdSerialRegisterAccessWidth

Signed-off-by: "Tien Hock, Loh" <tien.hock.loh@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: "Zhu, YongHong" <yonghong.zhu@intel.com>
--
v2
- Added Bugzilla to commit
- Fixed typo
---
 MdeModulePkg/MdeModulePkg.uni | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index cf2aefa7ad..654dfeadb0 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -160,6 +160,12 @@
                                                                                   "TRUE  - 16550 serial port registers are in MMIO space.<BR>\n"
                                                                                   "FALSE - 16550 serial port registers are in I/O space.<BR>"
 
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_PROMPT  #language en-US "Serial port registers access width"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HELP  #language en-US "Sets the 16550 serial port registers access width in MMIO space. Default is 8 bits access.<BR><BR>\n"
+                                                                                  "8  - 16550 serial port MMIO register access are in 8 bits mode.<BR>\n"
+                                                                                  "32 - 16550 serial port MMIO registers acess are in 32 bits mode..<BR>"
+
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_PROMPT  #language en-US "Enable serial port hardware flow control"
 
 #string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_HELP  #language en-US "Indicates if the 16550 serial port hardware flow control will be enabled. Default is FALSE.<BR><BR>\n"
-- 
2.19.0

Re: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI

[Wu, Hao A]

> -----Original Message-----
> From: Loh, Tien Hock
> Sent: Thursday, May 09, 2019 5:20 PM
> To: devel@edk2.groups.io; thloh85@gmail.com
> Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, Yonghong
> Subject: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing
> Pcd to UNI
> 
> From: "Tien Hock, Loh" <tien.hock.loh@intel.com>
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1771
> 
> Some busses doesn't allow 8 bit MMIO read/write, this adds support for
> 32 bits read/write. This patch adds the UNI information on the new Pcd
> introduced - PcdSerialRegisterAccessWidth
> 
> Signed-off-by: "Tien Hock, Loh" <tien.hock.loh@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: "Zhu, YongHong" <yonghong.zhu@intel.com>

Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
And the patch has been pushed via commit 70023bab7e.

Best Regards,
Hao Wu

> --
> v2
> - Added Bugzilla to commit
> - Fixed typo
> ---
>  MdeModulePkg/MdeModulePkg.uni | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.uni
> b/MdeModulePkg/MdeModulePkg.uni
> index cf2aefa7ad..654dfeadb0 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -160,6 +160,12 @@
>                                                                                    "TRUE  - 16550 serial port
> registers are in MMIO space.<BR>\n"
>                                                                                    "FALSE - 16550 serial port
> registers are in I/O space.<BR>"
> 
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_PRO
> MPT  #language en-US "Serial port registers access width"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HELP
> #language en-US "Sets the 16550 serial port registers access width in MMIO
> space. Default is 8 bits access.<BR><BR>\n"
> +                                                                                  "8  - 16550 serial port
> MMIO register access are in 8 bits mode.<BR>\n"
> +                                                                                  "32 - 16550 serial port
> MMIO registers acess are in 32 bits mode..<BR>"
> +
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_P
> ROMPT  #language en-US "Enable serial port hardware flow control"
> 
>  #string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_
> HELP  #language en-US "Indicates if the 16550 serial port hardware flow
> control will be enabled. Default is FALSE.<BR><BR>\n"
> --
> 2.19.0