From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: hao.a.wu@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Fri, 10 May 2019 01:50:03 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 May 2019 01:50:03 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 10 May 2019 01:50:03 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 10 May 2019 01:50:03 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 10 May 2019 01:50:02 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000; Fri, 10 May 2019 16:50:02 +0800 From: "Wu, Hao A" To: "Loh, Tien Hock" , "devel@edk2.groups.io" , "thloh85@gmail.com" CC: "Wang, Jian J" , "Zhu, Yonghong" Subject: Re: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI Thread-Topic: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI Thread-Index: AQHVBkhpUAHVKALDDEyO7MdS0ULvCKZkDd5g Date: Fri, 10 May 2019 08:50:02 +0000 Message-ID: References: <1557393594-129092-1-git-send-email-tien.hock.loh@intel.com> In-Reply-To: <1557393594-129092-1-git-send-email-tien.hock.loh@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Loh, Tien Hock > Sent: Thursday, May 09, 2019 5:20 PM > To: devel@edk2.groups.io; thloh85@gmail.com > Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, Yonghong > Subject: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing > Pcd to UNI >=20 > From: "Tien Hock, Loh" >=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1771 >=20 > Some busses doesn't allow 8 bit MMIO read/write, this adds support for > 32 bits read/write. This patch adds the UNI information on the new Pcd > introduced - PcdSerialRegisterAccessWidth >=20 > Signed-off-by: "Tien Hock, Loh" > Cc: Jian J Wang > Cc: Hao Wu > Cc: "Zhu, YongHong" Reviewed-by: Hao A Wu And the patch has been pushed via commit 70023bab7e. Best Regards, Hao Wu > -- > v2 > - Added Bugzilla to commit > - Fixed typo > --- > MdeModulePkg/MdeModulePkg.uni | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index cf2aefa7ad..654dfeadb0 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -160,6 +160,12 @@ > = "TRUE - 16550 serial port > registers are in MMIO space.
\n" > = "FALSE - 16550 serial port > registers are in I/O space.
" >=20 > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_PRO > MPT #language en-US "Serial port registers access width" > + > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialRegisterAccessWidth_HELP > #language en-US "Sets the 16550 serial port registers access width in MMI= O > space. Default is 8 bits access.

\n" > + = "8 - 16550 serial port > MMIO register access are in 8 bits mode.
\n" > + = "32 - 16550 serial port > MMIO registers acess are in 32 bits mode..
" > + > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_P > ROMPT #language en-US "Enable serial port hardware flow control" >=20 > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSerialUseHardwareFlowControl_ > HELP #language en-US "Indicates if the 16550 serial port hardware flow > control will be enabled. Default is FALSE.

\n" > -- > 2.19.0