Re: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif
> Lindholm
> Sent: Tuesday, May 14, 2019 11:13 PM
> To: Wu, Hao A
> Cc: devel@edk2.groups.io; Ard Biesheuvel; Kinney, Michael D
> Subject: Re: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use
> ReportStatusCodeLib in MdeModulePkg
> 
> On Tue, May 14, 2019 at 10:08:15AM +0800, Hao A Wu wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
> >
> > This commit will update the DSC file to consume the ReportStatusCodeLib
> > (DXE phase and Runtime instances) in MdeModulePkg, instead of using the
> > one in IntelFrameworkModulePkg.
> >
> > Please note that, the DXE and Runtime ReportStatusCodeLib instances are
> > almost identical between IntelFrameworkModulePkg and MdeModulePkg.
> Thus,
> > there is no functional impact for this commit.
> 
> Please reword this statement.
> Certainly the changes are minor, but there is definitely functional
> difference there.

Thanks Leif, I will refine the comments.

Actually, this patch was sent out by accident and it is already included in the series:
https://edk2.groups.io/g/devel/topic/31614319

Could you help to review that series instead? Sorry for the inconvenience.

Best Regards,
Hao Wu

> 
> No concern with the change itself.
> 
> /
>     Leif
> 
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> > ---
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > index 2d5d6f9977..8e8bb833ea 100644
> > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > @@ -163,7 +163,7 @@
> >    HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf
> >
> MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/
> DxeCoreMemoryAllocationLib.inf
> >
> DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf
> > -
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode
> LibFramework/DxeReportStatusCodeLib.inf
> > +
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep
> ortStatusCodeLib.inf
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtr
> actGuidedSectionLib.inf
> >    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >  #  PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> > @@ -173,19 +173,19 @@
> >
> >
> >  [LibraryClasses.common.DXE_DRIVER]
> > -
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode
> LibFramework/DxeReportStatusCodeLib.inf
> > +
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep
> ortStatusCodeLib.inf
> >    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> >
> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/
> DxeSecurityManagementLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance
> Lib.inf
> >
> NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverab
> leDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf
> >
> >  [LibraryClasses.common.UEFI_APPLICATION]
> > -
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode
> LibFramework/DxeReportStatusCodeLib.inf
> > +
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep
> ortStatusCodeLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance
> Lib.inf
> >    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
> >
> >  [LibraryClasses.common.UEFI_DRIVER]
> > -
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode
> LibFramework/DxeReportStatusCodeLib.inf
> > +
> ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep
> ortStatusCodeLib.inf
> >
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtr
> actGuidedSectionLib.inf
> >
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance
> Lib.inf
> >    DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf
> > @@ -193,7 +193,7 @@
> >  [LibraryClasses.common.DXE_RUNTIME_DRIVER]
> >    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> >
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemory
> AllocationLib.inf
> > -
> ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode
> LibFramework/DxeReportStatusCodeLib.inf
> > +
> ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib
> /RuntimeDxeReportStatusCodeLib.inf
> >
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> >  #  PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf
> >    PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.inf
> > --
> > 2.12.0.windows.1
> >
> 
>