From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: hao.a.wu@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Tue, 14 May 2019 17:30:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 17:30:48 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 14 May 2019 17:30:48 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 17:30:47 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 17:30:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.216]) with mapi id 14.03.0415.000; Wed, 15 May 2019 08:30:45 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: Ard Biesheuvel , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg Thread-Topic: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use ReportStatusCodeLib in MdeModulePkg Thread-Index: AQHVCfn2szNHwOP5ZkSLUNFstXXfq6ZqNPsAgAEgw5A= Date: Wed, 15 May 2019 00:30:45 +0000 Message-ID: References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-3-hao.a.wu@intel.com> <20190514151302.mdw4dfewgjotug5h@bivouac.eciton.net> In-Reply-To: <20190514151302.mdw4dfewgjotug5h@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if > Lindholm > Sent: Tuesday, May 14, 2019 11:13 PM > To: Wu, Hao A > Cc: devel@edk2.groups.io; Ard Biesheuvel; Kinney, Michael D > Subject: Re: [edk2-devel] [PATCH 1/2] Platform/BeagleBoard: Use > ReportStatusCodeLib in MdeModulePkg >=20 > On Tue, May 14, 2019 at 10:08:15AM +0800, Hao A Wu wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D1800 > > > > This commit will update the DSC file to consume the ReportStatusCodeLi= b > > (DXE phase and Runtime instances) in MdeModulePkg, instead of using th= e > > one in IntelFrameworkModulePkg. > > > > Please note that, the DXE and Runtime ReportStatusCodeLib instances ar= e > > almost identical between IntelFrameworkModulePkg and MdeModulePkg. > Thus, > > there is no functional impact for this commit. >=20 > Please reword this statement. > Certainly the changes are minor, but there is definitely functional > difference there. Thanks Leif, I will refine the comments. Actually, this patch was sent out by accident and it is already included i= n the series: https://edk2.groups.io/g/devel/topic/31614319 Could you help to review that series instead? Sorry for the inconvenience. Best Regards, Hao Wu >=20 > No concern with the change itself. >=20 > / > Leif >=20 > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Signed-off-by: Hao A Wu > > --- > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 10 +++++----= - > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > index 2d5d6f9977..8e8bb833ea 100644 > > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > @@ -163,7 +163,7 @@ > > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > > > MemoryAllocationLib|MdeModulePkg/Library/DxeCoreMemoryAllocationLib/ > DxeCoreMemoryAllocationLib.inf > > > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > > - > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode > LibFramework/DxeReportStatusCodeLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep > ortStatusCodeLib.inf > > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExt= r > actGuidedSectionLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > @@ -173,19 +173,19 @@ > > > > > > [LibraryClasses.common.DXE_DRIVER] > > - > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode > LibFramework/DxeReportStatusCodeLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep > ortStatusCodeLib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/ > DxeSecurityManagementLib.inf > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance > Lib.inf > > > NonDiscoverableDeviceRegistrationLib|MdeModulePkg/Library/NonDiscoverab > leDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > > > > [LibraryClasses.common.UEFI_APPLICATION] > > - > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode > LibFramework/DxeReportStatusCodeLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep > ortStatusCodeLib.inf > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance > Lib.inf > > HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > > > > [LibraryClasses.common.UEFI_DRIVER] > > - > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode > LibFramework/DxeReportStatusCodeLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeRep > ortStatusCodeLib.inf > > > ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExt= r > actGuidedSectionLib.inf > > > PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformance > Lib.inf > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > @@ -193,7 +193,7 @@ > > [LibraryClasses.common.DXE_RUNTIME_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemory > AllocationLib.inf > > - > ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCode > LibFramework/DxeReportStatusCodeLib.inf > > + > ReportStatusCodeLib|MdeModulePkg/Library/RuntimeDxeReportStatusCodeLib > /RuntimeDxeReportStatusCodeLib.inf > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > # PeCoffLib|MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf > > PeCoffLib|BeagleBoardPkg/Library/DxeHobPeCoffLib/DxeHobPeCoffLib.in= f > > -- > > 2.12.0.windows.1 > > >=20 >=20