From: "Wu, Hao A" <hao.a.wu@intel.com>
To: David Woodhouse <dwmw2@infradead.org>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Laszlo Ersek <lersek@redhat.com>, "Ni, Ray" <ray.ni@intel.com>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: Reviewer for the possible duplicated CSM components in OvmfPkg
Date: Mon, 20 May 2019 05:32:44 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8D4E38@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <99af0c4af27a2a57c99e88d19bc53a3724392f14.camel@infradead.org>
> -----Original Message-----
> From: David Woodhouse [mailto:dwmw2@infradead.org]
> Sent: Monday, May 20, 2019 1:11 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Laszlo Ersek; Ni, Ray; Justen, Jordan L; Ard Biesheuvel
> Subject: Re: Reviewer for the possible duplicated CSM components in OvmfPkg
>
> On Mon, 2019-05-20 at 05:08 +0000, Wu, Hao A wrote:
> > Hello David,
> >
> > According to the request in a previous mail discussion thread
> > 'Drop CSM support in OvmfPkg?':
> >
> > https://edk2.groups.io/g/devel/topic/30916686#35723
> >
> > We plan to duplicate the required CSM modules into the OvmfPkg/Csm folder,
> > so that those modules will be kept within the edk2 repo.
> >
> > Meanwhile, Laszlo suggested me to first figure out the ownership (review
> > duty) for these CSM components before such duplication:
> >
> > https://edk2.groups.io/g/devel/topic/31627718#40659
> >
> > Would you like to take such role to be the reviewer for the CSM components
> > that will be copied into the OvmfPkg?
> >
> > Thanks in advance.
>
> Yes, I believe I have sufficient motivation to spend time on that am I
> am willing to do so. My only caveat is that I haven't managed to
Thanks.
> reproduce the working CSM situation that I had when I first implemented
> this all; even by going back to those versions of OVMF + SeaBIOS.
>
> Lazslo has pointed me at some potential reasons for that, but I haven't
> yet managed to chase them up.
My thought on this is the CSM components in the framework packages are
stable for a period of time. So my guess is that the issue is not directly
related to these components.
Also, if it turns out that there are some missing components left
uncopied, we are able to get them back (from the repo history) and put
them into OvmfPkg then. I can help on that.
Does this sound good to you?
Best Regards,
Hao Wu
next prev parent reply other threads:[~2019-05-20 5:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 5:08 Reviewer for the possible duplicated CSM components in OvmfPkg Wu, Hao A
2019-05-20 5:11 ` David Woodhouse
2019-05-20 5:32 ` Wu, Hao A [this message]
2019-05-20 5:40 ` David Woodhouse
2019-05-20 5:59 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8D4E38@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox