* [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules @ 2019-05-21 15:21 Liming Gao 2019-05-22 1:44 ` [edk2-devel] " Wu, Hao A 0 siblings, 1 reply; 6+ messages in thread From: Liming Gao @ 2019-05-21 15:21 UTC (permalink / raw) To: devel; +Cc: Hao A Wu Network related modules have been included in NetworkPkg.dsc. They can be removed from MdeModulePkg.dsc. Signed-off-by: Liming Gao <liming.gao@intel.com> Cc: Hao A Wu <hao.a.wu@intel.com> --- MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index ac7111dea1..995fd805e1 100644 --- a/MdeModulePkg/MdeModulePkg.dsc +++ b/MdeModulePkg/MdeModulePkg.dsc @@ -63,11 +63,6 @@ # UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf @@ -263,12 +258,8 @@ MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllocationProfileLib.inf MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.inf MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32GuidedSectionExtractLib.inf - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedSectionExtractLib.inf MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf @@ -357,16 +348,6 @@ MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurementDxe.inf - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf - MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmentPciCfg2Pei.inf MdeModulePkg/Universal/PCD/Dxe/Pcd.inf MdeModulePkg/Universal/PCD/Pei/Pcd.inf -- 2.13.0.windows.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules 2019-05-21 15:21 [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules Liming Gao @ 2019-05-22 1:44 ` Wu, Hao A 2019-05-22 1:50 ` Liming Gao 0 siblings, 1 reply; 6+ messages in thread From: Wu, Hao A @ 2019-05-22 1:44 UTC (permalink / raw) To: devel@edk2.groups.io, Gao, Liming > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, May 21, 2019 11:22 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > to remove Network related modules > > Network related modules have been included in NetworkPkg.dsc. > They can be removed from MdeModulePkg.dsc. > > Signed-off-by: Liming Gao <liming.gao@intel.com> > Cc: Hao A Wu <hao.a.wu@intel.com> > --- > MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > b/MdeModulePkg/MdeModulePkg.dsc > index ac7111dea1..995fd805e1 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -63,11 +63,6 @@ > # > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > ib/DxeSecurityManagementLib.inf > > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > plate.inf > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > f > @@ -263,12 +258,8 @@ > > MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo > cationProfileLib.inf > > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i > nf > > MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided > SectionExtractLib.inf > - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf > - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco > l.inf > > MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS > ectionExtractLib.inf > MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > @@ -357,16 +348,6 @@ > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement > Dxe.inf > > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > - Reviewed-by: Hao A Wu <hao.a.wu@intel.com> I will let the stewards to decide whether this can be pushed at this moment. Best Regards, Hao Wu > > MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen > tPciCfg2Pei.inf > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > MdeModulePkg/Universal/PCD/Pei/Pcd.inf > -- > 2.13.0.windows.1 > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules 2019-05-22 1:44 ` [edk2-devel] " Wu, Hao A @ 2019-05-22 1:50 ` Liming Gao 2019-05-22 9:11 ` Laszlo Ersek 0 siblings, 1 reply; 6+ messages in thread From: Liming Gao @ 2019-05-22 1:50 UTC (permalink / raw) To: Wu, Hao A, devel@edk2.groups.io Cc: Laszlo Ersek (lersek@redhat.com), leif.lindholm@linaro.org, Kinney, Michael D, afish@apple.com This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. This change is to remove the duplicated one. Thanks Liming > -----Original Message----- > From: Wu, Hao A > Sent: Wednesday, May 22, 2019 9:44 AM > To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com> > Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Liming Gao > > Sent: Tuesday, May 21, 2019 11:22 PM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A > > Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > > to remove Network related modules > > > > Network related modules have been included in NetworkPkg.dsc. > > They can be removed from MdeModulePkg.dsc. > > > > Signed-off-by: Liming Gao <liming.gao@intel.com> > > Cc: Hao A Wu <hao.a.wu@intel.com> > > --- > > MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- > > 1 file changed, 19 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc > > index ac7111dea1..995fd805e1 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -63,11 +63,6 @@ > > # > > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > > > SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > > ib/DxeSecurityManagementLib.inf > > > > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > > plate.inf > > > > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > > f > > @@ -263,12 +258,8 @@ > > > > MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo > > cationProfileLib.inf > > > > MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i > > nf > > > > MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided > > SectionExtractLib.inf > > - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf > > - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco > > l.inf > > > > MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS > > ectionExtractLib.inf > > MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > > @@ -357,16 +348,6 @@ > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > > > MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement > > Dxe.inf > > > > - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > > - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - > > Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > I will let the stewards to decide whether this can be pushed at this moment. > > Best Regards, > Hao Wu > > > > > MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen > > tPciCfg2Pei.inf > > MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > MdeModulePkg/Universal/PCD/Pei/Pcd.inf > > -- > > 2.13.0.windows.1 > > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules 2019-05-22 1:50 ` Liming Gao @ 2019-05-22 9:11 ` Laszlo Ersek 2019-05-22 11:41 ` Liming Gao 0 siblings, 1 reply; 6+ messages in thread From: Laszlo Ersek @ 2019-05-22 9:11 UTC (permalink / raw) To: Gao, Liming, Wu, Hao A, devel@edk2.groups.io Cc: leif.lindholm@linaro.org, Kinney, Michael D, afish@apple.com On 05/22/19 03:50, Gao, Liming wrote: > This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. I'm not sure I'm convinced -- if this patch is not applied, what precisely is the functionality that breaks? What are the symptoms? Either way, I'll let the other stewards decide about this. Thanks Laszlo > This change is to remove the duplicated one. > > Thanks > Liming >> -----Original Message----- >> From: Wu, Hao A >> Sent: Wednesday, May 22, 2019 9:44 AM >> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com> >> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules >> >>> -----Original Message----- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> Liming Gao >>> Sent: Tuesday, May 21, 2019 11:22 PM >>> To: devel@edk2.groups.io >>> Cc: Wu, Hao A >>> Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc >>> to remove Network related modules >>> >>> Network related modules have been included in NetworkPkg.dsc. >>> They can be removed from MdeModulePkg.dsc. >>> >>> Signed-off-by: Liming Gao <liming.gao@intel.com> >>> Cc: Hao A Wu <hao.a.wu@intel.com> >>> --- >>> MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- >>> 1 file changed, 19 deletions(-) >>> >>> diff --git a/MdeModulePkg/MdeModulePkg.dsc >>> b/MdeModulePkg/MdeModulePkg.dsc >>> index ac7111dea1..995fd805e1 100644 >>> --- a/MdeModulePkg/MdeModulePkg.dsc >>> +++ b/MdeModulePkg/MdeModulePkg.dsc >>> @@ -63,11 +63,6 @@ >>> # >>> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf >>> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >>> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >>> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >>> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf >>> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >>> >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL >>> ib/DxeSecurityManagementLib.inf >>> >>> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem >>> plate.inf >>> >>> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in >>> f >>> @@ -263,12 +258,8 @@ >>> >>> MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo >>> cationProfileLib.inf >>> >>> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i >>> nf >>> >>> MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided >>> SectionExtractLib.inf >>> - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf >>> - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf >>> - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf >>> MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf >>> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf >>> - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf >>> >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco >>> l.inf >>> >>> MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS >>> ectionExtractLib.inf >>> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf >>> @@ -357,16 +348,6 @@ >>> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >>> >>> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement >>> Dxe.inf >>> >>> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf >>> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf >>> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf >>> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf >>> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf >>> - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf >>> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf >>> - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf >>> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf >>> - >> >> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> >> I will let the stewards to decide whether this can be pushed at this moment. >> >> Best Regards, >> Hao Wu >> >>> >>> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen >>> tPciCfg2Pei.inf >>> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf >>> MdeModulePkg/Universal/PCD/Pei/Pcd.inf >>> -- >>> 2.13.0.windows.1 >>> >>> >>> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules 2019-05-22 9:11 ` Laszlo Ersek @ 2019-05-22 11:41 ` Liming Gao 2019-05-22 14:33 ` Leif Lindholm 0 siblings, 1 reply; 6+ messages in thread From: Liming Gao @ 2019-05-22 11:41 UTC (permalink / raw) To: Laszlo Ersek, Wu, Hao A, devel@edk2.groups.io Cc: leif.lindholm@linaro.org, Kinney, Michael D, afish@apple.com > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, May 22, 2019 5:11 PM > To: Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io > Cc: leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com > Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > On 05/22/19 03:50, Gao, Liming wrote: > > This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. > > I'm not sure I'm convinced -- if this patch is not applied, what > precisely is the functionality that breaks? What are the symptoms? > The problem is that NetworkPkg.dsc and MdeModulePkg.dsc both builds those network drivers. I am OK to get more feedback from stewards. > Either way, I'll let the other stewards decide about this. > > Thanks > Laszlo > > > This change is to remove the duplicated one. > > > > Thanks > > Liming > >> -----Original Message----- > >> From: Wu, Hao A > >> Sent: Wednesday, May 22, 2019 9:44 AM > >> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com> > >> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > >> > >>> -----Original Message----- > >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >>> Liming Gao > >>> Sent: Tuesday, May 21, 2019 11:22 PM > >>> To: devel@edk2.groups.io > >>> Cc: Wu, Hao A > >>> Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > >>> to remove Network related modules > >>> > >>> Network related modules have been included in NetworkPkg.dsc. > >>> They can be removed from MdeModulePkg.dsc. > >>> > >>> Signed-off-by: Liming Gao <liming.gao@intel.com> > >>> Cc: Hao A Wu <hao.a.wu@intel.com> > >>> --- > >>> MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- > >>> 1 file changed, 19 deletions(-) > >>> > >>> diff --git a/MdeModulePkg/MdeModulePkg.dsc > >>> b/MdeModulePkg/MdeModulePkg.dsc > >>> index ac7111dea1..995fd805e1 100644 > >>> --- a/MdeModulePkg/MdeModulePkg.dsc > >>> +++ b/MdeModulePkg/MdeModulePkg.dsc > >>> @@ -63,11 +63,6 @@ > >>> # > >>> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > >>> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > >>> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > >>> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > >>> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > >>> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > >>> > >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > >>> ib/DxeSecurityManagementLib.inf > >>> > >>> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > >>> plate.inf > >>> > >>> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > >>> f > >>> @@ -263,12 +258,8 @@ > >>> > >>> MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo > >>> cationProfileLib.inf > >>> > >>> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i > >>> nf > >>> > >>> MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided > >>> SectionExtractLib.inf > >>> - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > >>> - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > >>> - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > >>> MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > >>> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf > >>> - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > >>> > >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco > >>> l.inf > >>> > >>> MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS > >>> ectionExtractLib.inf > >>> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > >>> @@ -357,16 +348,6 @@ > >>> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > >>> > >>> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement > >>> Dxe.inf > >>> > >>> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > >>> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > >>> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > >>> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > >>> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > >>> - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > >>> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > >>> - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > >>> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > >>> - > >> > >> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > >> I will let the stewards to decide whether this can be pushed at this moment. > >> > >> Best Regards, > >> Hao Wu > >> > >>> > >>> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen > >>> tPciCfg2Pei.inf > >>> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > >>> MdeModulePkg/Universal/PCD/Pei/Pcd.inf > >>> -- > >>> 2.13.0.windows.1 > >>> > >>> > >>> > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules 2019-05-22 11:41 ` Liming Gao @ 2019-05-22 14:33 ` Leif Lindholm 0 siblings, 0 replies; 6+ messages in thread From: Leif Lindholm @ 2019-05-22 14:33 UTC (permalink / raw) To: Gao, Liming Cc: Laszlo Ersek, Wu, Hao A, devel@edk2.groups.io, Kinney, Michael D, afish@apple.com On Wed, May 22, 2019 at 11:41:03AM +0000, Gao, Liming wrote: > > -----Original Message----- > > From: Laszlo Ersek [mailto:lersek@redhat.com] > > Sent: Wednesday, May 22, 2019 5:11 PM > > To: Gao, Liming <liming.gao@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; devel@edk2.groups.io > > Cc: leif.lindholm@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; afish@apple.com > > Subject: Re: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > > > On 05/22/19 03:50, Gao, Liming wrote: > > > This is a bug. Because NetworkPkg dsc has included all network modules, the ones in MdeModule are duplicated. > > > > I'm not sure I'm convinced -- if this patch is not applied, what > > precisely is the functionality that breaks? What are the symptoms? > > > The problem is that NetworkPkg.dsc and MdeModulePkg.dsc both builds those network drivers. > I am OK to get more feedback from stewards. I think I agree with Laszlo, then. Unless it causes issues with the generated images, the fix can wait until after the stable tag. A very minor regression in build performance does not to me justify added churn during freeze period. Mike, Andrew, what's your take? Best Regards, Leif > > Either way, I'll let the other stewards decide about this. > > > > Thanks > > Laszlo > > > > > This change is to remove the duplicated one. > > > > > > Thanks > > > Liming > > >> -----Original Message----- > > >> From: Wu, Hao A > > >> Sent: Wednesday, May 22, 2019 9:44 AM > > >> To: devel@edk2.groups.io; Gao, Liming <liming.gao@intel.com> > > >> Subject: RE: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules > > >> > > >>> -----Original Message----- > > >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > >>> Liming Gao > > >>> Sent: Tuesday, May 21, 2019 11:22 PM > > >>> To: devel@edk2.groups.io > > >>> Cc: Wu, Hao A > > >>> Subject: [edk2-devel] [Patch] MdeModulePkg: Update MdeModulePkg.dsc > > >>> to remove Network related modules > > >>> > > >>> Network related modules have been included in NetworkPkg.dsc. > > >>> They can be removed from MdeModulePkg.dsc. > > >>> > > >>> Signed-off-by: Liming Gao <liming.gao@intel.com> > > >>> Cc: Hao A Wu <hao.a.wu@intel.com> > > >>> --- > > >>> MdeModulePkg/MdeModulePkg.dsc | 19 ------------------- > > >>> 1 file changed, 19 deletions(-) > > >>> > > >>> diff --git a/MdeModulePkg/MdeModulePkg.dsc > > >>> b/MdeModulePkg/MdeModulePkg.dsc > > >>> index ac7111dea1..995fd805e1 100644 > > >>> --- a/MdeModulePkg/MdeModulePkg.dsc > > >>> +++ b/MdeModulePkg/MdeModulePkg.dsc > > >>> @@ -63,11 +63,6 @@ > > >>> # > > >>> UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > >>> UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > >>> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > >>> - IpIoLib|MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > >>> - UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > >>> - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > >>> - DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > >>> > > >>> SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementL > > >>> ib/DxeSecurityManagementLib.inf > > >>> > > >>> TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTem > > >>> plate.inf > > >>> > > >>> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.in > > >>> f > > >>> @@ -263,12 +258,8 @@ > > >>> > > >>> MdeModulePkg/Library/DxeCoreMemoryAllocationLib/DxeCoreMemoryAllo > > >>> cationProfileLib.inf > > >>> > > >>> MdeModulePkg/Library/DxeCorePerformanceLib/DxeCorePerformanceLib.i > > >>> nf > > >>> > > >>> MdeModulePkg/Library/DxeCrc32GuidedSectionExtractLib/DxeCrc32Guided > > >>> SectionExtractLib.inf > > >>> - MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > >>> - MdeModulePkg/Library/DxeIpIoLib/DxeIpIoLib.inf > > >>> - MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf > > >>> MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf > > >>> MdeModulePkg/Library/DxeResetSystemLib/DxeResetSystemLib.inf > > >>> - MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > >>> > > >>> MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protoco > > >>> l.inf > > >>> > > >>> MdeModulePkg/Library/PeiCrc32GuidedSectionExtractLib/PeiCrc32GuidedS > > >>> ectionExtractLib.inf > > >>> MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanceLib.inf > > >>> @@ -357,16 +348,6 @@ > > >>> MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > > >>> > > >>> MdeModulePkg/Universal/SmbiosMeasurementDxe/SmbiosMeasurement > > >>> Dxe.inf > > >>> > > >>> - MdeModulePkg/Universal/Network/ArpDxe/ArpDxe.inf > > >>> - MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/DpcDxe/DpcDxe.inf > > >>> - MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/MnpDxe/MnpDxe.inf > > >>> - MdeModulePkg/Universal/Network/VlanConfigDxe/VlanConfigDxe.inf > > >>> - MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > >>> - MdeModulePkg/Universal/Network/SnpDxe/SnpDxe.inf > > >>> - MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > >>> - > > >> > > >> Reviewed-by: Hao A Wu <hao.a.wu@intel.com> > > >> I will let the stewards to decide whether this can be pushed at this moment. > > >> > > >> Best Regards, > > >> Hao Wu > > >> > > >>> > > >>> MdeModulePkg/Universal/PcatSingleSegmentPciCfg2Pei/PcatSingleSegmen > > >>> tPciCfg2Pei.inf > > >>> MdeModulePkg/Universal/PCD/Dxe/Pcd.inf > > >>> MdeModulePkg/Universal/PCD/Pei/Pcd.inf > > >>> -- > > >>> 2.13.0.windows.1 > > >>> > > >>> > > >>> > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-05-22 14:33 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-05-21 15:21 [Patch] MdeModulePkg: Update MdeModulePkg.dsc to remove Network related modules Liming Gao 2019-05-22 1:44 ` [edk2-devel] " Wu, Hao A 2019-05-22 1:50 ` Liming Gao 2019-05-22 9:11 ` Laszlo Ersek 2019-05-22 11:41 ` Liming Gao 2019-05-22 14:33 ` Leif Lindholm
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox