From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>,
"Ni, Ray" <ray.ni@intel.com>, "Zeng, Star" <star.zeng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>,
Michael Turner <Michael.Turner@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless
Date: Mon, 27 May 2019 02:15:28 +0000 [thread overview]
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8D68E2@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190524024009.31600-1-zhichao.gao@intel.com>
For my understanding, the series looks like a feature rather than bug to me.
I suggest to hold this one until the stable tag is created.
Best Regards,
Hao Wu
> -----Original Message-----
> From: Gao, Zhichao
> Sent: Friday, May 24, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> Michael Turner; Bret Barkelew; Laszlo Ersek
> Subject: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless
>
> For now most platforms support display function at PEI phase.
> But the conspliter and graphics console driver would clear the
> screen at BDS connect console phase. Maybe some platforms would
> show logo in the next or maybe not. For consumers, it looks like
> the screen flashed.
> So change the behavior of graphics console devices while connect
> console devices to maintain seamless screen from PEI.
>
> Test has done on MinPlatform Kabylake-RVP3 which support PEI
> display.
>
> V2:
> Make the SetMode not clear the screen only at the first boot during
> the first conncettion of graphics device.
>
> V3:
> Abandon V2. Directly set the output mode without clear the screen
> while initialize the graphics console device. Add clear screen operation
> in stop function of graphics console device.
>
> V4:
> Fix incorrect mode check in V3.
> Initialize the mode to an invalid mode. If no perfer mode is found, it
> is better to initialize its text mode to an invalid one.
> Remove the ClearScreen fuction in the BindingStop function in V3.
> The graphics output driver may disconnect before graphics console, that
> may cause a system exception because of using released resource.
> Impact: the screen would not be cleared after reconnect the graphics device
> thru software, such as 'reconnect -r' in shell.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
>
> Aaron Antone (1):
> MdeModulePkg/ConSplitterDxe: Optimize the
> ConSplitterTextOutSetMode
>
> Zhichao Gao (1):
> MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode
>
> .../Console/ConSplitterDxe/ConSplitter.c | 33 ++++++++++-----
> .../Console/ConSplitterDxe/ConSplitter.h | 4 +-
> .../GraphicsConsoleDxe/GraphicsConsole.c | 42 ++++++++++++++-----
> .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 +
> 4 files changed, 59 insertions(+), 22 deletions(-)
>
> --
> 2.21.0.windows.1
next prev parent reply other threads:[~2019-05-27 2:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-24 2:40 [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Gao, Zhichao
2019-05-24 2:40 ` [PATCH V4 1/2] MdeModulePkg/ConSplitterDxe: Optimize the ConSplitterTextOutSetMode Gao, Zhichao
2019-05-27 1:38 ` Wu, Hao A
2019-05-24 2:40 ` [PATCH V4 2/2] MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode Gao, Zhichao
2019-05-24 9:40 ` Laszlo Ersek
2019-05-27 1:51 ` Wu, Hao A
2019-05-27 2:15 ` Wu, Hao A [this message]
2019-06-13 6:58 ` [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Wu, Hao A
2019-06-13 10:00 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B80AF82E9BFB8E4FBD8C89DA810C6A093C8D68E2@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox