From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: hao.a.wu@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Sun, 26 May 2019 19:15:35 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 May 2019 19:15:34 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 26 May 2019 19:15:31 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 26 May 2019 19:15:31 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 26 May 2019 19:15:31 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Mon, 27 May 2019 10:15:30 +0800 From: "Wu, Hao A" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew , Laszlo Ersek Subject: Re: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Thread-Topic: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Thread-Index: AQHVEdoeKy3ZU135pEWNytaSppsfGaZ+PlhA Date: Mon, 27 May 2019 02:15:28 +0000 Message-ID: References: <20190524024009.31600-1-zhichao.gao@intel.com> In-Reply-To: <20190524024009.31600-1-zhichao.gao@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For my understanding, the series looks like a feature rather than bug to me= . I suggest to hold this one until the stable tag is created. Best Regards, Hao Wu > -----Original Message----- > From: Gao, Zhichao > Sent: Friday, May 24, 2019 10:40 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Broga= n; > Michael Turner; Bret Barkelew; Laszlo Ersek > Subject: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless >=20 > For now most platforms support display function at PEI phase. > But the conspliter and graphics console driver would clear the > screen at BDS connect console phase. Maybe some platforms would > show logo in the next or maybe not. For consumers, it looks like > the screen flashed. > So change the behavior of graphics console devices while connect > console devices to maintain seamless screen from PEI. >=20 > Test has done on MinPlatform Kabylake-RVP3 which support PEI > display. >=20 > V2: > Make the SetMode not clear the screen only at the first boot during > the first conncettion of graphics device. >=20 > V3: > Abandon V2. Directly set the output mode without clear the screen > while initialize the graphics console device. Add clear screen operation > in stop function of graphics console device. >=20 > V4: > Fix incorrect mode check in V3. > Initialize the mode to an invalid mode. If no perfer mode is found, it > is better to initialize its text mode to an invalid one. > Remove the ClearScreen fuction in the BindingStop function in V3. > The graphics output driver may disconnect before graphics console, that > may cause a system exception because of using released resource. > Impact: the screen would not be cleared after reconnect the graphics devi= ce > thru software, such as 'reconnect -r' in shell. >=20 > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Liming Gao > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew > Cc: Laszlo Ersek >=20 > Aaron Antone (1): > MdeModulePkg/ConSplitterDxe: Optimize the > ConSplitterTextOutSetMode >=20 > Zhichao Gao (1): > MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode >=20 > .../Console/ConSplitterDxe/ConSplitter.c | 33 ++++++++++----- > .../Console/ConSplitterDxe/ConSplitter.h | 4 +- > .../GraphicsConsoleDxe/GraphicsConsole.c | 42 ++++++++++++++----- > .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 + > 4 files changed, 59 insertions(+), 22 deletions(-) >=20 > -- > 2.21.0.windows.1