From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: hao.a.wu@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Sun, 09 Jun 2019 22:13:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 22:13:45 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 09 Jun 2019 22:13:45 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 22:13:44 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 22:13:44 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.6]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 13:13:42 +0800 From: "Wu, Hao A" To: "'devel@edk2.groups.io'" , 'Ard Biesheuvel' , 'Leif Lindholm' CC: "ming.huang@linaro.org" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Thread-Index: AQHVDufJaZPh6SooLkO1DEERXCqs3KZ+SvcAgBYOH0A= Date: Mon, 10 Jun 2019 05:13:42 +0000 Message-ID: References: <20190520084105.9028-1-hao.a.wu@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Ard and Leif, I saw Ming Huang validated the patch (OS boot): Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg https://edk2.groups.io/g/devel/message/41419 (Thanks a lot for the validation effort.) Do you have remaining concerns for review this series? Thanks in advance. Best Regards, Hao Wu > -----Original Message----- > From: Wu, Hao A > Sent: Monday, May 27, 2019 10:43 AM > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray; > guoheyi@huawei.com > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > IntelFramework[Module]Pkg dependency >=20 > Hello Ard and Leif, >=20 > Do you have comments on this series? >=20 > Also, for the below patch to Hisilicon platforms: > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in > MdeModulePkg >=20 > it is suggested to be verified on actual hardware: > https://edk2.groups.io/g/devel/topic/31614327#41188 >=20 > However, it seems that there is no accessible hardware for such verifica= tion > at this moment. Do you think it is fine to push this change anyway? >=20 > (Also CCed the stewards here for comments.) >=20 > Best Regards, > Hao Wu >=20 >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Wu, Hao A > > Sent: Monday, May 20, 2019 4:41 PM > > To: devel@edk2.groups.io > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > IntelFramework[Module]Pkg dependency > > > > The series is also available at: > > https://github.com/hwu25/edk2- > > platforms/commits/drop_intelframework_v2 > > > > V2 changes: > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, updat= e > > their DSC file to consume the null ReportStatusCodeLib in MdePkg. T= he > > change is done since these platforms do not have a StatusCode Route= r > > module; > > B. Add the change for platform RaspberryPi/RPi3 to drop its dependency > on > > the framework packages; > > C. Update the commit log message for patch > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg' > > to better reflect the commit impact. > > > > > > This series will drop the IntelFramework[Module]Pkg dependency for > > platforms within the edk2-platforms repo. > > packages. > > > > Tests done for the series: > > Platforms build verified with GCC5 toolchain: > > * Platform/AMD/OverdriveBoard > > * Platform/ARM/JunoPkg > > * Platform/ARM/SgiPkg > > * Platform/ARM/VExpressPkg > > * Platform/BeagleBoard > > * Platform/Hisilicon/D0x > > * Platform/Hisilicon/HiKey > > * Platform/Hisilicon/HiKey960 > > * Platform/LeMaker/CelloBoard > > * Platform/Marvell/Armada70x0Db (only AARCH64) > > * Platform/Marvell/Armada80x0Db (only AARCH64) > > * Platform/RaspberryPi/RPi3 > > * Platform/Socionext/DeveloperBox > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64) > > * Platform/SoftIron/Overdrive1000Board > > * Platform/SolidRun/Armada80x0McBin (only AARCH64) > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not > > verified): > > * Platform/Comcast/RDKQemu (ARM, AARCH64) > > * Platform/Marvell/Armada70x0Db (ARM) > > * Platform/Marvell/Armada80x0Db (ARM) > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64) > > * Platform/SolidRun/Armada80x0McBin (ARM) > > > > Cc: Ard Biesheuvel > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > > > Hao A Wu (18): > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance > > Platform/BeagleBoard: Drop the consume of PcdShellFile > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLib > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > Hisilicon/D06: Drop the consume of PcdShellFile > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in > MdeModulePkg > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg dependency > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon PlatformBdsL= ib > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg > > Platform/LeMaker: Use ReportStatusCodeLib null instance > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg > > Platform/SoftIron: Use ReportStatusCodeLib null instance > > Platform/RPi3: Use ReportStatusCodeLib null instance > > Platform/RaspberryPi: Drop the consume of PcdShellFile > > > > Silicon/Hisilicon/Hisilicon.dsc.inc = | 10 +- > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > | > > 2 +- > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > | 12 +- > > Platform/Hisilicon/D03/D03.dsc = | 10 +- > > Platform/Hisilicon/D05/D05.dsc = | 10 +- > > Platform/Hisilicon/D06/D06.dsc = | 8 +- > > Platform/LeMaker/CelloBoard/CelloBoard.dsc = | 10 > > +- > > Platform/RaspberryPi/RPi3/RPi3.dsc = | 7 +- > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > | 10 +- > > Platform/Hisilicon/D03/D03.fdf = | 6 +- > > Platform/Hisilicon/D05/D05.fdf = | 6 +- > > Platform/Hisilicon/D06/D06.fdf = | 6 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDxe. > > inf | 2 - > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClassD= x > > e.inf | 1 - > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > | 2 - > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > | 77 -- > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h > > | 1 - > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > | 55 -- > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.= h > > | 21 - > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass.= c > > | 4 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFu > > nction.c | 4 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManuf > > acturerFunction.c | 4 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardMa > > nufacturerFunction.c | 4 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufa > > cturerFunction.c | 2 +- > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotDes > > ignationFunction.c | 4 +- > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > | 957 -------------------- > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.= c > > | 112 --- > > 27 files changed, 48 insertions(+), 1299 deletions(-) > > delete mode 100644 > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.inf > > delete mode 100644 > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > delete mode 100644 > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > delete mode 100644 > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > delete mode 100644 > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > -- > > 2.12.0.windows.1 > > > > > >=20