Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

["Wu, Hao A" <hao.a.wu@intel.com>]

> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, June 10, 2019 2:13 PM
> To: devel@edk2.groups.io; Wu, Hao A; Zeng, Star; lersek@redhat.com; Ni,
> Ray; Gao, Liming; ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael
> D; Liu, Zhiguang; Justen, Jordan L; Andrew Fish
> Subject: RE: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> current speed
> 
> Good list.

Thanks Jiewen,

> 
> What does "memory" mean ? MemoryTest ?

Not only MemoryTest, I was intended to count components like memory
allocation, memory profile (contents within MdeModulePkg/Core/Pei/Memory &
MdeModulePkg/Core/Dxe/Mem) and etc. into this category as well.

But I am not sure if such classification makes sense.

> 
> How about put "LockBox" into "S3"?

Agree.

> 
> How about list "EBC" as standalone component?

Agree. Thanks for the reminder.

Best Regards,
Hao Wu

> 
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Wu, Hao A
> > Sent: Monday, June 10, 2019 2:02 PM
> > To: devel@edk2.groups.io; Zeng, Star <star.zeng@intel.com>;
> > lersek@redhat.com; Ni, Ray <ray.ni@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; ard.biesheuvel@linaro.org; Leif Lindholm
> > <leif.lindholm@linaro.org>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish
> > <afish@apple.com>
> > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > current speed
> >
> > > -----Original Message-----
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> Of
> > > Zeng, Star
> > > Sent: Wednesday, June 05, 2019 10:31 PM
> > > To: devel@edk2.groups.io; lersek@redhat.com; Ni, Ray; Gao, Liming;
> > > ard.biesheuvel@linaro.org; Leif Lindholm; Kinney, Michael D; Liu,
> > Zhiguang;
> > > Justen, Jordan L; Andrew Fish
> > > Cc: Zeng, Star
> > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > current speed
> > >
> > > > -----Original Message-----
> > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf
> > Of
> > > > Laszlo Ersek
> > > > Sent: Wednesday, June 5, 2019 4:03 PM
> > > > To: Ni, Ray <ray.ni@intel.com>; Gao, Liming <liming.gao@intel.com>;
> > > > ard.biesheuvel@linaro.org; Leif Lindholm <leif.lindholm@linaro.org>;
> > > Kinney,
> > > > Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> > > > <zhiguang.liu@intel.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>;
> > > > Andrew Fish <afish@apple.com>
> > > > Cc: devel@edk2.groups.io
> > > > Subject: Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu
> > > > current speed
> > > >
> > > > On 06/05/19 03:10, Ni, Ray wrote:
> > > > > Hi everyone,
> > > > >
> > > > > Hao pushed the patch because:
> > > > > 1. it's a bug fix
> > > > > 2. it got a R-b.
> > > > > I don't think it's his fault.
> > > > >
> > > > > For #1, it's gap in process.
> > > > > For #2, it's my fault. Because even the patch title says EmulatorPkg
> but
> > > the
> > > > patch itself changes MdeModulePkg, I am still the person who can
> > approve
> > > > changes in both packages.
> > > > >
> > > > > In Maintainers.txt:
> > > > > R: Ray Ni <ray.ni@intel.com>
> > > > >   (especially for Bus, Universal/Console, Universal/Disk,
> > > > >    Universal/BdsDxe and related libraries, header files)
> > > > >
> > > > > The UiApp actually is not in the "especially" part, but the word
> > > "especially"
> > > > > means I can also R-b to other components. In fact, I am not quite
> > > > > qualified on the other components, e.g.: UiApp.
> > > > > So I propose to assign clear reviewers for each components in
> > > > MdeModulePkg.
> > > > > What do you think?
> > > >
> > > > Fully agreed. MdeModulePkg is huge and we should have fine-grained
> > > > maintainership assignments.
> > >
> > > I also agree.
> >
> > Thanks all.
> >
> > For the review ownership refinement in the MdeModulePkg, how about
> the
> > below steps:
> >
> > 1. Work out a major feature list for the MdeModulePkg
> > 2. Call for owners for every item in the list.
> >
> >
> > A quick and coarse list of major features can be:
> >
> > (Just a draft, some key features may be missing or some listed features
> > may not be considered as major ones. Feedbacks are welcomed.)
> >
> > Acpi
> > Bds
> > Capsule
> > Compress
> > Console
> > Core (PeiCore, DxeCore, PiSmmCore and etc.)
> > Device (peripheral & storage)
> > Disk
> > HII
> > LockBox
> > Memory
> > PCD
> > PCI bus
> > Reset
> > S3
> > SMBIOS
> > SMM
> > Status Code
> > UI
> > Variable
> > Misc (all the components that do not fit in the above items)
> >
> >
> > Any feedbacks/suggestions for such proposal?
> >
> > Best Regards,
> > Hao Wu
> >
> > >
> > > >
> > > > Thanks
> > > > Laszlo
> > > >
> > > >
> > >
> > >
> > >
> >
> >
> >