From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: hao.a.wu@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Mon, 10 Jun 2019 23:19:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 23:19:53 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 10 Jun 2019 23:19:53 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 23:19:52 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 10 Jun 2019 23:19:52 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.137]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.192]) with mapi id 14.03.0415.000; Tue, 11 Jun 2019 14:19:50 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: 'Ard Biesheuvel' , "ming.huang@linaro.org" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Thread-Topic: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop IntelFramework[Module]Pkg dependency Thread-Index: AQHVDufJaZPh6SooLkO1DEERXCqs3KZ+SvcAgBYOH0CAAEDbgIABg08g Date: Tue, 11 Jun 2019 06:19:50 +0000 Message-ID: References: <20190520084105.9028-1-hao.a.wu@intel.com> <20190610151235.u73xywjsjqfo4fev@bivouac.eciton.net> In-Reply-To: <20190610151235.u73xywjsjqfo4fev@bivouac.eciton.net> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Monday, June 10, 2019 11:13 PM > To: Wu, Hao A > Cc: 'devel@edk2.groups.io'; 'Ard Biesheuvel'; ming.huang@linaro.org; Ni, > Ray > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > IntelFramework[Module]Pkg dependency >=20 > Hi Hao Wu, >=20 > Given Ming's confirmation regarding d06, I'm happy for this set to go > ahead. Also, we're just past the edk2 stable tag, so people should be > expecting some volatility :) >=20 > Acked-by: Leif Lindholm Thanks Leif, Can I go ahead to push this series? Or should I wait someone for additional review? Best Regards, Hao Wu >=20 > On Mon, Jun 10, 2019 at 05:13:42AM +0000, Wu, Hao A wrote: > > Hello Ard and Leif, > > > > I saw Ming Huang validated the patch (OS boot): > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > > > https://edk2.groups.io/g/devel/message/41419 > > (Thanks a lot for the validation effort.) > > > > Do you have remaining concerns for review this series? > > Thanks in advance. > > > > Best Regards, > > Hao Wu > > > > > > > -----Original Message----- > > > From: Wu, Hao A > > > Sent: Monday, May 27, 2019 10:43 AM > > > To: devel@edk2.groups.io; Ard Biesheuvel; Leif Lindholm > > > Cc: Kinney, Michael D; Andrew Fish; Laszlo Ersek; Ni, Ray; > > > guoheyi@huawei.com > > > Subject: RE: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > > IntelFramework[Module]Pkg dependency > > > > > > Hello Ard and Leif, > > > > > > Do you have comments on this series? > > > > > > Also, for the below patch to Hisilicon platforms: > > > [PATCH v2 06/18] Hisilicon/D0x: Use StatusCode Router & Handler in > > > MdeModulePkg > > > > > > it is suggested to be verified on actual hardware: > > > https://edk2.groups.io/g/devel/topic/31614327#41188 > > > > > > However, it seems that there is no accessible hardware for such > verification > > > at this moment. Do you think it is fine to push this change anyway? > > > > > > (Also CCed the stewards here for comments.) > > > > > > Best Regards, > > > Hao Wu > > > > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > Of > > > > Wu, Hao A > > > > Sent: Monday, May 20, 2019 4:41 PM > > > > To: devel@edk2.groups.io > > > > Cc: Wu, Hao A; Ard Biesheuvel; Leif Lindholm; Kinney, Michael D > > > > Subject: [edk2-devel] [edk2-platforms][PATCH v2 00/18] Drop > > > > IntelFramework[Module]Pkg dependency > > > > > > > > The series is also available at: > > > > https://github.com/hwu25/edk2- > > > > platforms/commits/drop_intelframework_v2 > > > > > > > > V2 changes: > > > > A. For platforms BeagleBoard, CelloBoard and Overdrive1000Board, > update > > > > their DSC file to consume the null ReportStatusCodeLib in MdePk= g. > The > > > > change is done since these platforms do not have a StatusCode > Router > > > > module; > > > > B. Add the change for platform RaspberryPi/RPi3 to drop its > dependency > > > on > > > > the framework packages; > > > > C. Update the commit log message for patch > > > > 'Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModuleP= kg' > > > > to better reflect the commit impact. > > > > > > > > > > > > This series will drop the IntelFramework[Module]Pkg dependency for > > > > platforms within the edk2-platforms repo. > > > > packages. > > > > > > > > Tests done for the series: > > > > Platforms build verified with GCC5 toolchain: > > > > * Platform/AMD/OverdriveBoard > > > > * Platform/ARM/JunoPkg > > > > * Platform/ARM/SgiPkg > > > > * Platform/ARM/VExpressPkg > > > > * Platform/BeagleBoard > > > > * Platform/Hisilicon/D0x > > > > * Platform/Hisilicon/HiKey > > > > * Platform/Hisilicon/HiKey960 > > > > * Platform/LeMaker/CelloBoard > > > > * Platform/Marvell/Armada70x0Db (only AARCH64) > > > > * Platform/Marvell/Armada80x0Db (only AARCH64) > > > > * Platform/RaspberryPi/RPi3 > > > > * Platform/Socionext/DeveloperBox > > > > * Platform/Socionext/SynQuacerEvalBoard (only AARCH64) > > > > * Platform/SoftIron/Overdrive1000Board > > > > * Platform/SolidRun/Armada80x0McBin (only AARCH64) > > > > > > > > Platforms originally cannot be built via GCC5 toolchain (thus, not > > > > verified): > > > > * Platform/Comcast/RDKQemu (ARM, AARCH64) > > > > * Platform/Marvell/Armada70x0Db (ARM) > > > > * Platform/Marvell/Armada80x0Db (ARM) > > > > * Platform/Socionext/SynQuacerEvalBoard (ARM, AARCH64) > > > > * Platform/SolidRun/Armada80x0McBin (ARM) > > > > > > > > Cc: Ard Biesheuvel > > > > Cc: Leif Lindholm > > > > Cc: Michael D Kinney > > > > > > > > Hao A Wu (18): > > > > Platform/AMD: Use Lzma decompress lib in MdeModulePkg > > > > Platform/BeagleBoard: Use ReportStatusCodeLib null instance > > > > Platform/BeagleBoard: Drop the consume of PcdShellFile > > > > Hisilicon/D0x: Use Lzma decompress lib in MdeModulePkg > > > > Hisilicon/D0x: Drop the consume of GenericBdsLib & PlatformBdsLi= b > > > > Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg > > > > Hisilicon/D06: Drop the consume of PcdShellFile > > > > Silicon/Hisilicon: Use Lzma decompress lib in MdeModulePkg > > > > Silicon/Hisilicon: Use ReportStatusCodeLib (DXE) in MdeModulePkg > > > > Silicon/Hisilicon: Use DebugLib (DXE_RUNTIME_DRIVER) in > > > MdeModulePkg > > > > Silicon/Hisilicon/Smbios: Drop IntelFramework[Module]Pkg > dependency > > > > Silicon/Hisilicon/PlatformIntelBdsLib: Remove Hisilicon > PlatformBdsLib > > > > Platform/LeMaker: Use Lzma decompress lib in MdeModulePkg > > > > Platform/LeMaker: Use ReportStatusCodeLib null instance > > > > Platform/SoftIron: Use Lzma decompress lib in MdeModulePkg > > > > Platform/SoftIron: Use ReportStatusCodeLib null instance > > > > Platform/RPi3: Use ReportStatusCodeLib null instance > > > > Platform/RaspberryPi: Drop the consume of PcdShellFile > > > > > > > > Silicon/Hisilicon/Hisilicon.dsc.inc = | 10 +- > > > > Platform/AMD/OverdriveBoard/OverdriveBoard.dsc > > > | > > > > 2 +- > > > > Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc > > > > | 12 +- > > > > Platform/Hisilicon/D03/D03.dsc = | 10 +- > > > > Platform/Hisilicon/D05/D05.dsc = | 10 +- > > > > Platform/Hisilicon/D06/D06.dsc = | 8 +- > > > > Platform/LeMaker/CelloBoard/CelloBoard.dsc = | > 10 > > > > +- > > > > Platform/RaspberryPi/RPi3/RPi3.dsc = | 7 +- > > > > Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc > > > > | 10 +- > > > > Platform/Hisilicon/D03/D03.fdf = | 6 +- > > > > Platform/Hisilicon/D05/D05.fdf = | 6 +- > > > > Platform/Hisilicon/D06/D06.fdf = | 6 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/MemorySubClassDxe/MemorySubClassDx > e. > > > > inf | 2 - > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass > Dx > > > > e.inf | 1 - > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf > > > > | 2 - > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib= .inf > > > > | 77 -- > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/SmbiosMisc.h > > > > | 1 - > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > > | 55 -- > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > > | 21 - > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/ProcessorSubClassDxe/ProcessorSubClass. > c > > > > | 4 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorF > u > > > > nction.c | 4 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type01/MiscSystemManu > f > > > > acturerFunction.c | 4 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardM > a > > > > nufacturerFunction.c | 4 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type03/MiscChassisManu > fa > > > > cturerFunction.c | 2 +- > > > > > > > > > > > > Silicon/Hisilicon/Drivers/Smbios/SmbiosMiscDxe/Type09/MiscSystemSlotD > es > > > > ignationFunction.c | 4 +- > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > > | 957 -------------------- > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > | 112 --- > > > > 27 files changed, 48 insertions(+), 1299 deletions(-) > > > > delete mode 100644 > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/PlatformIntelBdsLib.= inf > > > > delete mode 100644 > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.h > > > > delete mode 100644 > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.h > > > > delete mode 100644 > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatform.c > > > > delete mode 100644 > > > > > Silicon/Hisilicon/Library/PlatformIntelBdsLib/IntelBdsPlatformCommon.c > > > > > > > > -- > > > > 2.12.0.windows.1 > > > > > > > > > > > > > > >=20 >=20