Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

["Wu, Hao A" <hao.a.wu@intel.com>]

Hello Chao,

Do you have any comment/feedback on this series?

One comment with regard to the series below:

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Xu, Wei6
> Sent: Wednesday, June 05, 2019 11:42 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Kinney, Michael D; Gao, Liming; Zhang, Chao B
> Subject: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.
> 
> V2:
> Fix Ecc check failure.
> 
> V1:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852
> 
> This patch set implements Capsule On Disk.
> Depends on whether platform supports Capsule-In-Ram, Capsule On Disk
> feature is composed of 2 solutions:
> Solution A): Load capsules out of TCB, rely on UpdateCapsule() runtime
> service to deliver Capsule-On-Disk.
> Solution B): Relocate capsules into a temp file which will be stored in root
> directory on a platform specific storage device.
> Leverage existing storage stack in PEI to load all capsule on disk images and
> create capsule hobs for the capsules.
> This solution has bigger TCB, but can work without Capsule-In-RAM support.
> 
> 
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao B Zhang <chao.b.zhang@intel.com>
> 
> xuwei6 (7):
>   MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.
>   MdeModulePkg: Add Capsule On Disk related definition.
>   MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.
>   MdeModulePkg/BdsDxe: Support Capsule On Disk.
>   MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.
>   MdeModulePkg/DxeIpl: Support Capsule On Disk.
>   MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.


Please re-order the sequence of the patches.
I found that the below patch:
MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.

depends on some definitions added in patch (last one):
MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

Best Regards,
Hao Wu


> 
>  MdeModulePkg/Core/DxeIplPeim/DxeIpl.h              |    3 +-
>  MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf            |   20 +-
>  MdeModulePkg/Core/DxeIplPeim/DxeLoad.c             |   37 +-
>  MdeModulePkg/Include/Library/CapsuleLib.h          |   94 +-
>  MdeModulePkg/Include/Ppi/CapsuleOnDisk.h           |   48 +
>  .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.c       | 1983
> ++++++++++++++++++++
>  .../Library/DxeCapsuleLibFmp/CapsuleOnDisk.h       |   63 +
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c       |   56 +-
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf     |   21 +-
>  .../DxeCapsuleLibFmp/DxeCapsuleProcessLib.c        |  121 +-
>  .../Library/DxeCapsuleLibFmp/DxeCapsuleReportLib.c |   67 +-
>  .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf      |    3 +-
>  .../Library/DxeCapsuleLibNull/DxeCapsuleLibNull.c  |   85 +-
>  MdeModulePkg/MdeModulePkg.dec                      |   43 +
>  MdeModulePkg/MdeModulePkg.dsc                      |    4 +
>  MdeModulePkg/MdeModulePkg.uni                      |   32 +
>  MdeModulePkg/Universal/BdsDxe/BdsDxe.inf           |    3 +-
>  MdeModulePkg/Universal/BdsDxe/BdsEntry.c           |    6 +-
>  .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c    |  442 +++++
>  .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.inf  |   64 +
>  .../CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.uni  |   15 +
>  .../CapsuleOnDiskLoadPeiExtra.uni                  |   14 +
>  .../CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf        |    1 +
>  .../Universal/CapsuleRuntimeDxe/CapsuleService.c   |   10 +-
>  MdePkg/Include/Ppi/BootInRecoveryMode.h            |    9 +-
>  MdePkg/MdePkg.dec                                  |    3 +
>  26 files changed, 3205 insertions(+), 42 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Ppi/CapsuleOnDisk.h
>  create mode 100644
> MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.c
>  create mode 100644
> MdeModulePkg/Library/DxeCapsuleLibFmp/CapsuleOnDisk.h
>  create mode 100644
> MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.c
>  create mode 100644
> MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.i
> nf
>  create mode 100644
> MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPei.u
> ni
>  create mode 100644
> MdeModulePkg/Universal/CapsuleOnDiskLoadPei/CapsuleOnDiskLoadPeiE
> xtra.uni
> 
> --
> 2.16.2.windows.1
> 
> 
>