From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: hao.a.wu@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 12 Jun 2019 23:58:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Jun 2019 23:58:47 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 12 Jun 2019 23:58:46 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 23:58:46 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Jun 2019 23:58:45 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.104]) with mapi id 14.03.0439.000; Thu, 13 Jun 2019 14:58:44 +0800 From: "Wu, Hao A" To: "devel@edk2.groups.io" , "Wu, Hao A" , "Gao, Zhichao" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew , Laszlo Ersek Subject: Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Thread-Topic: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless Thread-Index: AQHVEdoeKy3ZU135pEWNytaSppsfGaZ+PlhAgBsIsfA= Date: Thu, 13 Jun 2019 06:58:43 +0000 Message-ID: References: <20190524024009.31600-1-zhichao.gao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: hao.a.wu@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, May 27, 2019 10:15 AM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew; Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen > seamless >=20 > For my understanding, the series looks like a feature rather than bug to= me. > I suggest to hold this one until the stable tag is created. Pushed via commits e85cfa2fa4..0a35997643. Best Regards, Hao Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Friday, May 24, 2019 10:40 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Br= ogan; > > Michael Turner; Bret Barkelew; Laszlo Ersek > > Subject: [PATCH V4 0/2] MdeModulePkg: Make the screen seamless > > > > For now most platforms support display function at PEI phase. > > But the conspliter and graphics console driver would clear the > > screen at BDS connect console phase. Maybe some platforms would > > show logo in the next or maybe not. For consumers, it looks like > > the screen flashed. > > So change the behavior of graphics console devices while connect > > console devices to maintain seamless screen from PEI. > > > > Test has done on MinPlatform Kabylake-RVP3 which support PEI > > display. > > > > V2: > > Make the SetMode not clear the screen only at the first boot during > > the first conncettion of graphics device. > > > > V3: > > Abandon V2. Directly set the output mode without clear the screen > > while initialize the graphics console device. Add clear screen operati= on > > in stop function of graphics console device. > > > > V4: > > Fix incorrect mode check in V3. > > Initialize the mode to an invalid mode. If no perfer mode is found, it > > is better to initialize its text mode to an invalid one. > > Remove the ClearScreen fuction in the BindingStop function in V3. > > The graphics output driver may disconnect before graphics console, tha= t > > may cause a system exception because of using released resource. > > Impact: the screen would not be cleared after reconnect the graphics > device > > thru software, such as 'reconnect -r' in shell. > > > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Cc: Laszlo Ersek > > > > Aaron Antone (1): > > MdeModulePkg/ConSplitterDxe: Optimize the > > ConSplitterTextOutSetMode > > > > Zhichao Gao (1): > > MdeModulePkg/GraphicsConsoleDxe: Initialize the output mode > > > > .../Console/ConSplitterDxe/ConSplitter.c | 33 ++++++++++----- > > .../Console/ConSplitterDxe/ConSplitter.h | 4 +- > > .../GraphicsConsoleDxe/GraphicsConsole.c | 42 ++++++++++++++----= - > > .../GraphicsConsoleDxe/GraphicsConsoleDxe.inf | 2 + > > 4 files changed, 59 insertions(+), 22 deletions(-) > > > > -- > > 2.21.0.windows.1 >=20 >=20 >=20