From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: hao.a.wu@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Thu, 13 Jun 2019 01:03:42 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jun 2019 01:03:42 -0700
X-ExtLoop1: 1
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga003.jf.intel.com with ESMTP; 13 Jun 2019 01:03:41 -0700
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 13 Jun 2019 01:03:40 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 13 Jun 2019 01:03:40 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.185]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.83]) with mapi id 14.03.0439.000;
 Thu, 13 Jun 2019 16:03:38 +0800
From: "Wu, Hao A" <hao.a.wu@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Bret Barkelew <Bret.Barkelew@microsoft.com>, "Gao, Liming"
	<liming.gao@intel.com>, Sean Brogan <sean.brogan@microsoft.com>, "Michael
 Turner" <Michael.Turner@microsoft.com>, Leif Lindholm
	<leif.lindholm@linaro.org>
Subject: Re: [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
Thread-Topic: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
 only
Thread-Index: AQHVIMgq2wsUrVFO8E2K1aT3BPTOKqaZOhsg
Date: Thu, 13 Jun 2019 08:03:38 +0000
Message-ID: <B80AF82E9BFB8E4FBD8C89DA810C6A093C8F026D@SHSMSX104.ccr.corp.intel.com>
References: <20190612023956.9180-1-zhichao.gao@intel.com>
 <20190612023956.9180-2-zhichao.gao@intel.com>
In-Reply-To: <20190612023956.9180-2-zhichao.gao@intel.com>
Accept-Language: zh-CN, en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: hao.a.wu@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Wednesday, June 12, 2019 10:40 AM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner; L=
eif
> Lindholm; Gao, Zhichao
> Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build onl=
y


With a similar suggestion at:
https://edk2.groups.io/g/devel/topic/32037312#42319

handled:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


>=20
> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1902
>=20
> Add the lacking instance to the [Components] of dsc file
> for build only.
>=20
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Zhichao gao <zhichao.gao@intel.com>
> ---
>  SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> index 8be6781296..a1a1b81d03 100644
> --- a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> +++ b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
> @@ -93,6 +93,8 @@
>=20
> ##########################################################
> #########################################
>=20
>  [Components.common]
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Dxe.inf
> +
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu
> nicationLibUsb3Pei.inf
>=20
> SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCo
> mmunicationLibSerialPort.inf
>=20
> SourceLevelDebugPkg/Library/DebugCommunicationLibUsb/DebugCommun
> icationLibUsb.inf
>=20
> SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActio
> nLibDebug.inf
> --
> 2.21.0.windows.1